Obviously also +1 from my side.

Am Mi., 2. Okt. 2019 um 13:40 Uhr schrieb Julian Feinauer <
j.feina...@pragmaticminds.de>:

> Hi all,
>
> sorry for being late to the party, my vote is
>
> +1 (binding, carries over to IPMC Vote also)
>
> great Job Anatole!
>
> I checked:
> - Hashes and Signature is are okay for apicore and extension (now with
> sha512 and asc)
> - NOTICE, LICENCE and DISCLAIMER look good
> - Checked instructions in readme
> - License headers on source codes look fine
> - No unexpected binaries
> - Able to compile both sources using 'mvn clean install' on MacOS Mojave
> using java 8.
>
> Minor Comment:
> - staged are also sha512 hashes for the asc files which is unnecessary and
> should be removed when we bring it to dist
>
> Best
> Julian
>
> Am 02.10.19, 09:32 schrieb "Werner Keil" <werner.k...@gmail.com>:
>
>     +1
>     Werner
>
>     P. Ottlinger <pottlin...@apache.org> schrieb am Mi., 2. Okt. 2019,
> 07:48:
>
>     > Am 25.09.19 um 14:41 schrieb Anatole Tresch:
>     > > The tag for this release candidate is available at [3] and [4]. It
> will
>     > be
>     > > renamed
>     > > once the vote passed.
>     > > Please take a look at the artifacts and vote!
>     >
>     > +1
>     >
>     > Works fine in my pet project.
>     >
>     > Cheers,
>     > Phil
>     >
>
>
>

-- 
*Anatole Tresch*
PPMC Member Apache Tamaya
JCP Star Spec Lead
*Switzerland, Europe Zurich, GMT+1*
*maketechsimple.wordpress.com <http://maketechsimple.wordpress.com/> *
*Twitter:  @atsticks, @tamayaconf*

Reply via email to