Re: @Value(required=false) and @Symbol(required=false)

2011-09-12 Thread Howard Lewis Ship
So what gets injected if the symbol isn't defined? tapestry-ioc already throws an exception if a symbol does not exist. Although we are not methodical about it, there is an intuitive split between service interfaces that other code uses vs. interfaces that user code implementes. SymbolSource wou

Re: @Value(required=false) and @Symbol(required=false)

2011-09-12 Thread Josh Canfield
This issue is in line with what I want to do: https://issues.apache.org/jira/browse/TAP5-1531 In order to preserve the interface I would add a specific runtime exception "SymbolNotFoundException" instead of adding a method to the SymbolSource interface. On Mon, Sep 12, 2011 at 1:51 PM, Josh Canfi

@Value(required=false) and @Symbol(required=false)

2011-09-12 Thread Josh Canfield
I don't always want to provide default values for symbols used throughout my application, especially when used to configure third party applications which provide their own defaults. I'd rather be able to detect null values. Any objections to adding a "required" attribute to @Value and @Symbol? J

Re: Alerts system... tests??

2011-09-12 Thread dragan.sahpas...@gmail.com
+1 on groovy tests On Sep 12, 2011 9:07 PM, "Howard Lewis Ship" wrote: > > On Mon, Sep 12, 2011 at 11:52 AM, Robert Zeigler > wrote: > > Aha! That's why I missed them. :) Thanks... keep forgetting about the groovy tests! > > Right ... and all new tests I write are in Groovy. > > > > > Robert > >

Re: Alerts system... tests??

2011-09-12 Thread Howard Lewis Ship
On Mon, Sep 12, 2011 at 11:52 AM, Robert Zeigler wrote: > Aha! That's why I missed them. :) Thanks... keep forgetting about the groovy > tests! Right ... and all new tests I write are in Groovy. > > Robert > > On Sep 12, 2011, at 9/1212:48 PM , Howard Lewis Ship wrote: > >> On Mon, Sep 12, 2011

Re: Alerts system... tests??

2011-09-12 Thread Robert Zeigler
Aha! That's why I missed them. :) Thanks... keep forgetting about the groovy tests! Robert On Sep 12, 2011, at 9/1212:48 PM , Howard Lewis Ship wrote: > On Mon, Sep 12, 2011 at 7:48 AM, Robert Zeigler > wrote: >> I was looking into the alerts system, for 1633 (hard coded "Dismiss all" >> labe

Re: ICLA Dragan Sahpaski

2011-09-12 Thread Kalle Korhonen
Dragan tells me he still doesn't have write access to Confluence. Can somebody with permissions put dragan.sahpaski to icla group please. Kalle On Mon, Aug 29, 2011 at 11:14 AM, Kalle Korhonen wrote: > Did anybody add Dragan to the icla group? I don't have the necessary > karma, I know at leas

Re: Alerts system... tests??

2011-09-12 Thread Howard Lewis Ship
On Mon, Sep 12, 2011 at 7:48 AM, Robert Zeigler wrote: > I was looking into the alerts system, for 1633 (hard coded "Dismiss all" > label). I found the "Alerts Demo" page, but I haven't been able to find any > tests that use the Alerts Demo page...?  Or any tests, period, of the alerts > system

Re: AlertManager

2011-09-12 Thread Dusko Jovanovski
Thanks to Robert for picking up the JIRA for the hardcoded "Dismiss all" label (https://issues.apache.org/jira/browse/TAP5-1633) I created another one for a more customizable duration of transient messages (https://issues.apache.org/jira/browse/TAP5-1640) -- Dusko On Wed, Sep 7, 2011 at 8:30 PM,

Alerts system... tests??

2011-09-12 Thread Robert Zeigler
I was looking into the alerts system, for 1633 (hard coded "Dismiss all" label). I found the "Alerts Demo" page, but I haven't been able to find any tests that use the Alerts Demo page...? Or any tests, period, of the alerts system, for that matter. I can't believe the alerts system would be ad