Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-14 Thread Denis Stepanov
> Are you suggesting a service to handle that, so we can override it if needed? > If yes, I agree. If not, I don't know what you're talking about. Yes > I don't think this is a good idea at all. In addition, what we're trying to > solve here is exactly the problem of handling context values wh

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-14 Thread Thiago H de Paula Figueiredo
On Thu, 14 Feb 2013 08:29:53 -0200, Denis Stepanov wrote: I like the idea also but implementation is not perfect. - You're using instanceof to check if context is empty, but I would say correct way is to check the size of the context. Agreed. - Not-handled response logic should be abstr

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-14 Thread Denis Stepanov
I like the idea also but implementation is not perfect. - You're using instanceof to check if context is empty, but I would say correct way is to check the size of the context. - Not-handled response logic should be abstract, what if someone wants a different response code or a different behavio

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Massimo Lusetti
Yes, pleas correct any stupid name. On Wed, Feb 13, 2013 at 4:16 PM, Bob Harner wrote: > A very minor issue: The "SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT" name > seems to miss the mark a bit. > > For consistency with other symbol names, maybe > "UNKNOWN_ACTIVATION_CONTEXT_CHECK_ENABLED" ? > > >

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Bob Harner
A very minor issue: The "SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT" name seems to miss the mark a bit. For consistency with other symbol names, maybe "UNKNOWN_ACTIVATION_CONTEXT_CHECK_ENABLED" ? http://tapestry.apache.org/current/apidocs/org/apache/tapestry5/SymbolConstants.html On Wed, Feb 1

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Massimo Lusetti
On Wed, Feb 13, 2013 at 3:36 PM, Ulrich Stärk wrote: +1 on the idea, -1 on the implementation. > > In PageActivatorImpl you set send404 from the symbol but never check on it. > > Right. The patch is wrong, It's not PRODUCTION_MODE that has to be check is SEND_404_TO_UNWANTED_ACTIVATION_CONTEXT...

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Ulrich Stärk
+1 on the idea, -1 on the implementation. In PageActivatorImpl you set send404 from the symbol but never check on it. Uli On 10.02.2013 23:18, Massimo Lusetti wrote: > Hi devs, > this ia vote to introduce a new behavior on how Tapestry5 handle incoming > requests. > > The issue you should loo

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Massimo Lusetti
On Wed, Feb 13, 2013 at 12:12 PM, Thiago H de Paula Figueiredo < thiag...@gmail.com> wrote: > The issue you should look at is: >> https://issues.apache.org/**jira/browse/TAP5-2070 >> > > Could you please describe the patch logic instead of just li

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Bob Harner
+1 On Sun, Feb 10, 2013 at 5:18 PM, Massimo Lusetti wrote: > Hi devs, > this ia vote to introduce a new behavior on how Tapestry5 handle incoming > requests. > > The issue you should look at is: > https://issues.apache.org/jira/browse/TAP5-2070 > > Basically the proposal is to introduce new log

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-13 Thread Thiago H de Paula Figueiredo
On Sun, 10 Feb 2013 20:18:27 -0200, Massimo Lusetti wrote: Hi devs, Hi! The issue you should look at is: https://issues.apache.org/jira/browse/TAP5-2070 Could you please describe the patch logic instead of just linking to it? -- Thiago H. de Paula Figueiredo --

Re: [VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-12 Thread Alejandro Scandroli
Alejandro Scandroli: +1 (non-binding) On Sun, Feb 10, 2013 at 11:18 PM, Massimo Lusetti wrote: > Hi devs, > this ia vote to introduce a new behavior on how Tapestry5 handle incoming > requests. > > The issue you should look at is: > https://issues.apache.org/jira/browse/TAP5-2070 > > Basicall

[VOTE] TAP5-2070 Implement logic to handle requests to unknown URL as 404

2013-02-10 Thread Massimo Lusetti
Hi devs, this ia vote to introduce a new behavior on how Tapestry5 handle incoming requests. The issue you should look at is: https://issues.apache.org/jira/browse/TAP5-2070 Basically the proposal is to introduce new logic to respond with HTTP 404 code to requests on unknown URL. The concept of