[ 
https://issues.apache.org/jira/browse/TAPESTRY-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473198
 ] 

Massimo Lusetti commented on TAPESTRY-1251:
-------------------------------------------

The statement at line 144: assertEquals(cookies.get(0), expectedCookie); 
doesn't take into account the domain part of the cookie.
Actually is the equals method of Cookie which probably doesn't, anyhow even 
commenting out line 142: expectedCookie.setDomain("fobar.com"); doesn't make 
the test fail.

So it's probably better to add something like: 
assertEquals(cookies.get(0).getDomain(), expectedCookie.getDomain()); as final 
assert for testing domain wide cookies.

> CookiesImplTest does specify a domain cookie with a domain not prefixed with 
> a . (dot)
> --------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1251
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1251
>             Project: Tapestry
>          Issue Type: Bug
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>            Priority: Trivial
>
> CookiesImplTest does specify a domain cookie with a domain not prefixed with 
> a . (dot) where the RFC 2109 explicitly says it should always do.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to