Getting some kind of warning would be nice, though. Maybe you could at least
add a log.warn statement to inform the developer?
Am 05.12.2011 um 02:34 schrieb Taha Hafeez Siddiqi:
Hi Igor,
I also thought of that but then I settled for this solution because 1) it
doesn't break 5.2 code 2)
Warnings are useless, at least when logged to the console. I'm
increasingly of the opinion that warnings should be logged to
AlertManager instead to force action from the developer.
Also, any plans to port this forward to 5.4 (trunk)?
On Mon, Dec 5, 2011 at 1:47 AM, Christian Riedel
Wouldn't it be better to validate each translator in TranslatorSourceImpl
and throw an IllegalRgumentException with a detailed message if a
translator doesn't provide a message key? This way the user would
immediately at startup know that he needs to provide a key. A default key
without any value
Hi Igor,
I also thought of that but then I settled for this solution because 1) it
doesn't break 5.2 code 2) we are already using translator-name in the
overriding messages 3) throwing an exception because of a missing message-key
doesn't seem right.
regards
Taha
On Dec 5, 2011, at 3:43 AM,
