Alright, we will look into this soon! Thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave-sgx-sdk/issues/386#issuecomment-1291540393
You are receiving this because you are subscribed to this thread.
Message ID:
Hi mingshen,
Thanks for your comments. I am fine with the codebase and the name.
The reason for putting it as a submodule in this PR is to have a clear view on
the modification to the original code. In one repo, it is not very clear what
we have done to rusty-leveldb. Do you have any advice?
Hi @henrysun007, thanks for the PR.
The reason we choose to put in the `common` directory is that we have changed
`rusty_leveldb` a lot, and we don't have any plan to upstream the changes.
Therefore, we'd like to keep it in the Teaclave codebase as a part of Teaclave.
I saw you're using a
## Description
Update leveldb to v1.0.4 and move the code to third_party as a submodule for a
clear view.
Fixes # (issue)
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds
