Re: [apache/incubator-teaclave-sgx-sdk] fix(sgx_types): correct improper c-types (#316)

2021-02-19 Thread Sammy
Any progress? @dingelish The commit msg should describe the PR, I think~ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/316#issuecomment-782511005

[apache/incubator-teaclave-sgx-sdk] fix(sgx_types): correct improper c-types (#316)

2021-02-08 Thread Sammy
You can view, comment on, or merge this pull request online at: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/316 -- Commit Summary -- * fix(sgx_types): correct improper c-types -- File Changes -- M sgx_types/src/function.rs (22) M sgx_types/src/types.rs (14) -- Patch

Re: [apache/incubator-teaclave-sgx-sdk] Using std Aware Cargo (#311)

2021-01-05 Thread Sammy
I think the `build-std` option will improve this SDK greatly, which will helps in stuff like removing the `std::prelude::v1::*` from SGX-ported crates. So I will give it a shot this weekend 😄 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or

[apache/incubator-teaclave-sgx-sdk] chore(samplecode): init test input for wasmi from makefile (#300)

2020-12-14 Thread Sammy
Remove the git submodule `samplecode/wasmi/test_input` so that it won't be pulled when used as a cargo dependency. You can view, comment on, or merge this pull request online at: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/300 -- Commit Summary -- * chore(samplecode): init tes

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

2020-05-14 Thread Sammy
It has been done at https://github.com/apache/incubator-teaclave-sgx-sdk/commit/df76765f586cf103189a5e62355672c96f4920ce -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#issuecommen

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

2020-05-14 Thread Sammy
Closed #224. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#event-3339156320

[apache/incubator-teaclave-sgx-sdk] fix(sgx_types): add the missing 'latest_issue_date' and 'earliest_expiration_date' to sgx_ql_qv_supplemental_t (#236)

2020-05-09 Thread Sammy
As of [intel/SGXDataCenterAttestationPrimitives@DCAP_1.5](https://github.com/intel/SGXDataCenterAttestationPrimitives/tree/DCAP_1.5), the `sgx_ql_qv_supplemental_t` has added two fields `latest_issue_date` and `earliest_expiration_date`. This patch synchronizes the `sgx_ql_qv_supplemental_t` wi

Re: [apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

2020-04-17 Thread Sammy
I would be better if the common folder can be put into that crate also~ @volcano0dr -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/issues/224#issuecomment-615540175

[apache/incubator-teaclave-sgx-sdk] What about arrange extended edl files with cargo? (#224)

2020-04-14 Thread Sammy
## Observation During daily development with this great SDK, we have to copy theses [edls](https://github.com/apache/incubator-teaclave-sgx-sdk/tree/master/edl) to local file system to use as extra searching paths for the `sgx_edger8r` tool for every project. There isn't any version control for

[apache/incubator-teaclave-sgx-sdk] refactor(sgx_tunittest): remove the necessary 'std' import for 'should_panic' macro (#217)

2020-04-04 Thread Sammy
## Problem The `should_panic!` macro in `sgx_tunittest` uses `std::panic`, which requires us the imports `std::panic` every time we use `should_panic!`. A demo project goes as [patch-sgx_tunittest](https://github.com/sammyne/patch-sgx_tunittest). To verify, just comment out the patch section o

Re: [apache/incubator-teaclave] A little idea about arranging the project structure (#236)

2020-03-10 Thread Sammy
Under every relevant folders (services/tests), the **cmake targets** to build enclaves should depend on the ones to build apps, and this dependency is achieved through CMakeLists.txt in the services/tests folders. So I don't get the following point~ > For the current proposal, I believe the te

[apache/incubator-teaclave] A little idea about arranging the project structure (#236)

2020-03-10 Thread Sammy
Currently, compiling the project relies heavily on the cmake, rendering CMakeLists.txt so large. That's not so friendly for starters to play with it. It would be nice if the the CMakeLists.txt is slimmed down, delegating part of its job to cargo workspaces, which would make the CMakeLists.txt e

[apache/incubator-teaclave] docs(attestation): fix a typo and add some doc (#233)

2020-03-09 Thread Sammy
## Description The built-in ECDSA is based on NIST P-256 (a.k.a. secp256r1), not secp256k1. This PR just fix that typo~ Relevant line of codes is https://github.com/apache/incubator-teaclave/blob/develop/attestation/src/key.rs#L25 ## Type of change (select applied and DELETE the others) - A