Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation for musl targets (#273)

2021-09-13 Thread Mingshen Sun
@mjquinlan Thank you so much! I'm wondering if there's any update on this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-918550411

Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation for musl targets (#273)

2020-10-16 Thread Michael Quinlan
Thanks! Let me add some documentation in a second commit. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710429444

Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation for musl targets (#273)

2020-10-16 Thread Yu Ding
sgtm :-) better if comes along with some description by either code comments or readme. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273#issuecomment-710422202

Re: [apache/incubator-teaclave-sgx-sdk] Added conditional compilation for musl targets (#273)

2020-10-16 Thread Mingshen Sun
Looks good to me. I think this can be documented somewhere so that other people may also interested. @dingelish, what do you think. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-teaclav

[apache/incubator-teaclave-sgx-sdk] Added conditional compilation for musl targets (#273)

2020-10-16 Thread Michael Quinlan
Allows building statically linked applications. This is useful for organizations needing to extend backwards compatibility to older OS releases. You can view, comment on, or merge this pull request online at: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/273 -- Commit Summary --