[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138222710 --- Diff: tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java --- @@ -22,11 +22,50 @@ * Thrown to indicate tran

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138237949 --- Diff: tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java --- @@ -22,11 +22,50 @@ * Thrown to indicate tran

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138270921 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -853,46 +867,45 @@ private void advanceWritePointer(long

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138238770 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java --- @@ -311,25 +304,16 @@ private void persist() throws Transac

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138239467 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionSystemClient.java --- @@ -89,21 +89,38 @@ * * @param tx trans

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162617#comment-16162617 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162614#comment-16162614 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162618#comment-16162618 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162615#comment-16162615 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162616#comment-16162616 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[GitHub] incubator-tephra pull request #56: (TEPHRA-258) Improve logging in thrift cl...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/56 ---

[jira] [Commented] (TEPHRA-258) Improve log message for Thrift client connection

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163184#comment-16163184 ] ASF GitHub Bot commented on TEPHRA-258: --- Github user asfgit closed the pull request

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138435657 --- Diff: tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java --- @@ -22,11 +22,50 @@ * Thrown to indicate transaction c

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138435693 --- Diff: tephra-api/src/main/java/org/apache/tephra/TransactionConflictException.java --- @@ -22,11 +22,50 @@ * Thrown to indicate transaction c

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138436222 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionContext.java --- @@ -311,25 +304,16 @@ private void persist() throws TransactionFailu

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138437669 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionSystemClient.java --- @@ -89,21 +89,38 @@ * * @param tx transaction to

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138437903 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -853,46 +867,45 @@ private void advanceWritePointer(long writePoin

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138477861 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -206,12 +210,19 @@ public TransactionManager(Configuratio

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138480498 --- Diff: tephra-core/src/main/thrift/transaction.thrift --- @@ -73,15 +79,21 @@ service TTransactionServer { // TODO remove this as it

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163804#comment-16163804 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163803#comment-16163803 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user poornachandra commented on a di

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138489380 --- Diff: tephra-core/src/main/thrift/transaction.thrift --- @@ -73,15 +79,21 @@ service TTransactionServer { // TODO remove this as it was repla

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163821#comment-16163821 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user anew commented on a diff in the

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/47#discussion_r138490048 --- Diff: tephra-core/src/main/java/org/apache/tephra/TransactionManager.java --- @@ -206,12 +210,19 @@ public TransactionManager(Configuration conf,

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163826#comment-16163826 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user anew commented on a diff in the

[GitHub] incubator-tephra issue #47: [TEPHRA-240] Include conflicting key and client ...

2017-09-12 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/47 squashed and rebased on latest master. ---

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163834#comment-16163834 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user anew commented on the issue:

[GitHub] incubator-tephra pull request #47: [TEPHRA-240] Include conflicting key and ...

2017-09-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/47 ---

[jira] [Commented] (TEPHRA-240) TransactionConflictException should contain the conflicting key and client id

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163839#comment-16163839 ] ASF GitHub Bot commented on TEPHRA-240: --- Github user asfgit closed the pull request

[GitHub] incubator-tephra pull request #53: (TEPHRA-243) Improve logging for slow log...

2017-09-12 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/53#discussion_r138534049 --- Diff: tephra-core/src/main/java/org/apache/tephra/persist/AbstractTransactionLog.java --- @@ -211,26 +212,36 @@ private void sync() throws IOExcep

[jira] [Commented] (TEPHRA-243) When transaction log sync is slow, the warning message should contain more information

2017-09-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164206#comment-16164206 ] ASF GitHub Bot commented on TEPHRA-243: --- Github user anew commented on a diff in the