[GitHub] incubator-tephra issue #37: TEPHRA-223 Encapsulate the two data structures u...

2017-02-21 Thread chtyim
Github user chtyim commented on the issue: https://github.com/apache/incubator-tephra/pull/37 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] incubator-tephra issue #37: TEPHRA-223 Encapsulate the two data structures u...

2017-02-21 Thread poornachandra
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/37 @chtyim I have addressed the comments, please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] incubator-tephra issue #37: TEPHRA-223 Encapsulate the two data structures u...

2017-02-20 Thread poornachandra
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/37 @anew @gokulavasan I have addressed the comments, please take another look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] incubator-tephra issue #37: TEPHRA-223 Encapsulate the two data structures u...

2017-02-20 Thread poornachandra
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/37 > Does the added synchronization add performance overhead? Extra synchronization is added in five places in this PR - 1. canCommit() - when transaction is not in in-progress