[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84386647 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceThriftClient.java --- @@ -112,7 +113,20 @@ public

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84399721 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84392263 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceThriftClient.java --- @@ -112,7 +113,20 @@ public Transaction

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84391234 --- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java --- @@ -124,4 +127,39 @@ protected TransactionSystemClient

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84390730 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84387667 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84388540 --- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java --- @@ -124,4 +127,39 @@ protected

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84387594 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84193226 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/thrift/TBoolean.java --- @@ -24,19 +24,29 @@ */ package

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

GitHub user anew opened a pull request: https://github.com/apache/incubator-tephra/pull/18 [TEPHRA-194] Make startShort() throw IllegalArgumentException … … consistently for invalid timeout values. Previously, it was throwing IllegalArgumentException in-memory and