[jira] Commented: (THRIFT-1047) rb_thrift_memory_buffer_write treats arg as string without check, segfaults if you pass non-string

2011-01-26 Thread Jake Donham (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987383#action_12987383 ] Jake Donham commented on THRIFT-1047: - There is no checking higher up in the call chai

Build failed in Hudson: Thrift #48

2011-01-26 Thread Apache Hudson Server
See Changes: [jake] revert accidental commit [jake] THRIFT-904: disable nagle and linger -- [...truncated 2415 lines...] -- Traceb

[jira] Assigned: (THRIFT-904) C# TSocket should disable nagle and linger

2011-01-26 Thread T Jake Luciani (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani reassigned THRIFT-904: - Assignee: Alexey Biryukov > C# TSocket should disable nagle and linger >

[jira] Resolved: (THRIFT-904) C# TSocket should disable nagle and linger

2011-01-26 Thread T Jake Luciani (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani resolved THRIFT-904. --- Resolution: Fixed Fix Version/s: 0.6 Thanks Alexey, committed > C# TSocket should dis

[jira] Updated: (THRIFT-681) The HTML generator does not handle JavaDoc style comments very well

2011-01-26 Thread Adrian Muraru (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Muraru updated THRIFT-681: - Attachment: Screenshot.png t_html_generator_JavaDoc.v2.patch > The HTML generator

[jira] Commented: (THRIFT-681) The HTML generator does not handle JavaDoc style comments very well

2011-01-26 Thread Adrian Muraru (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987321#action_12987321 ] Adrian Muraru commented on THRIFT-681: -- I enhanced John's patch to read the parameter

Build failed in Hudson: Thrift #47

2011-01-26 Thread Apache Hudson Server
See Changes: [bryanduxbury] THRIFT-994. build: Don't try to invoke phpize if we don't have it Patch: Richard Salz -- [...truncated 2425 lines...]

Build failed in Hudson: Thrift #46

2011-01-26 Thread Apache Hudson Server
See Changes: [bryanduxbury] THRIFT-1021. ocaml: Framed transport support for OCaml Patch: Richard Low -- [...truncated 2412 lines...]

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-26 Thread Wade Simmons
Bryan, I submitted four patches for the Node.js support last week that have been merged to trunk. Without these patches, the implementation has a lot of flaws. I think it would be nice to get this merged in to the 0.6.0 branch so that the first release of Node.js support doesn't go out the door wi

[jira] Closed: (THRIFT-1048) Thrift java library has redundant dependency on commons-lang.

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1048. - Resolution: Won't Fix Ah, right. I knew there was some dependency. > Thrift java library has re

[jira] Commented: (THRIFT-993) Some improvements in C++ stubs for oneway operations

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987297#action_12987297 ] Bryan Duxbury commented on THRIFT-993: -- Christian - is this patch ready to commit? >

[jira] Closed: (THRIFT-994) Don't try to invoke phpize if we don't have it

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-994. Resolution: Fixed Fix Version/s: 0.7 Assignee: Rich Salz I just committed this patc

[jira] Updated: (THRIFT-1007) Deserializer override for ByteBuffer input

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1007: -- Fix Version/s: 0.7 > Deserializer override for ByteBuffer input >

[jira] Updated: (THRIFT-1012) Transport for DataInput DataOutput interface

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1012: -- Fix Version/s: 0.7 Can you get revs in before the next release? > Transport for DataInput Dat

[jira] Commented: (THRIFT-1017) Cleanup whitespaces in sourcefiles

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987294#action_12987294 ] Bryan Duxbury commented on THRIFT-1017: --- I think I'd accept a patch for the necessar

[jira] Updated: (THRIFT-1017) Cleanup whitespaces in sourcefiles

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1017: -- Priority: Trivial (was: Major) > Cleanup whitespaces in sourcefiles > ---

[jira] Updated: (THRIFT-1019) java backend should use fully qualified names for domain types

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1019: -- Fix Version/s: 0.7 > java backend should use fully qualified names for domain types >

[jira] Closed: (THRIFT-1021) Framed transport support for OCaml

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1021. - Resolution: Fixed Fix Version/s: 0.7 Assignee: Richard Low I just committed this

[jira] Commented: (THRIFT-1048) Thrift java library has redundant dependency on commons-lang.

2011-01-26 Thread David Reiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987288#action_12987288 ] David Reiss commented on THRIFT-1048: - We still use it for HashCodeBuilder as well if

[jira] Updated: (THRIFT-1029) Function parameter documentation is not rendered to HTML

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1029: -- Fix Version/s: 0.7 > Function parameter documentation is not rendered to HTML > --

[jira] Updated: (THRIFT-1031) Patch to compile Thrift for vc++ 9.0 and 10.0

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1031: -- Fix Version/s: 0.7 Any CPP people out there who could pass judgment on this patch? > Patch to

[jira] Commented: (THRIFT-1047) rb_thrift_memory_buffer_write treats arg as string without check, segfaults if you pass non-string

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987286#action_12987286 ] Bryan Duxbury commented on THRIFT-1047: --- In what circumstances would a non-string ge

[jira] Updated: (THRIFT-1048) Thrift java library has redundant dependency on commons-lang.

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1048: -- Priority: Minor (was: Major) I'd accept a patch for this, though I'm not in any hurry to get

[jira] Commented: (THRIFT-1046) a python TSocketPool (ported from the php version)

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987283#action_12987283 ] Bryan Duxbury commented on THRIFT-1046: --- What other methods need to be ported to mak

[jira] Commented: (THRIFT-1039) Refactor methods accessing binary data

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987281#action_12987281 ] Bryan Duxbury commented on THRIFT-1039: --- Realistically, at least a month. Mostly it'

Build failed in Hudson: Thrift #45

2011-01-26 Thread Apache Hudson Server
See Changes: [bryanduxbury] update CHANGES file [bryanduxbury] THRIFT-1038. java: Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement ja

[jira] Commented: (THRIFT-1039) Refactor methods accessing binary data

2011-01-26 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987279#action_12987279 ] Mathias Herberts commented on THRIFT-1039: -- How far down the road do you foresee

[jira] Updated: (THRIFT-1016) using GSocket in c_glib library

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1016: -- Priority: Minor (was: Critical) > using GSocket in c_glib library > -

[VOTE] Thrift 0.6.0 RC1

2011-01-26 Thread Bryan Duxbury
All, I propose that we accept http://people.apache.org/~bryanduxbury/thrift-0.6.0-rc1.tar.gzas the official Thrift 0.6.0 release. This will be our first release since we graduated from the incubator. I generated this tarball by che

[jira] Updated: (THRIFT-363) Maven Deploy

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-363: - Fix Version/s: (was: 0.3) 0.7 > Maven Deploy > > >

[jira] Commented: (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987273#action_12987273 ] Bryan Duxbury commented on THRIFT-633: -- Is this still a problem? I know a lot of thing

[jira] Updated: (THRIFT-1039) Refactor methods accessing binary data

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1039: -- Fix Version/s: 0.7 I think we need to carefully decide if we want to break backwards compatibi

[jira] Closed: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializab

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1038. - Resolution: Fixed Fix Version/s: 0.7 I just committed this patch to the 0.6 branch and to

[jira] Commented: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Seriali

2011-01-26 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987180#action_12987180 ] Mathias Herberts commented on THRIFT-1038: -- I agree we can settle on TCompact and

Build failed in Hudson: Thrift #44

2011-01-26 Thread Apache Hudson Server
See Changes: [bryanduxbury] THRIFT-1041. java: TDeserializer holds onto a reference of the array it reads after it is done deserializing This patch makes sure that after using the bytes passed in, no references are retained. ---

Build failed in Hudson: Thrift #43

2011-01-26 Thread Apache Hudson Server
See Changes: [bryanduxbury] THRIFT-998. java: Using valueOf for base types in getFieldValue valueOf saves us on memory for 'small' primitive types and costs us nothing in other situations, so it's an all-around win. Patch: Takashi Yoneba

[jira] Closed: (THRIFT-1041) TDeserializer holds onto a reference of the array it reads after it is done deserializing

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1041. - Resolution: Fixed Fix Version/s: 0.7 I ended up committing a slightly different version o

[jira] Updated: (THRIFT-447) Make an abstract base Client class so we can generate less code

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-447: - Fix Version/s: 0.7 > Make an abstract base Client class so we can generate less code > --

[jira] Closed: (THRIFT-997) Using valueOf for base types in getFieldValue

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-997. Resolution: Fixed Fix Version/s: 0.7 I just committed this. Thanks for the patch, Takashi!

[jira] Closed: (THRIFT-999) Add TForkingServer

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-999. Resolution: Fixed Fix Version/s: 0.7 Assignee: Nick Jones (was: Bryan Duxbury) I j

[jira] Closed: (THRIFT-996) The clone method does not call super.clone()

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-996. Resolution: Fixed Clone method was removed, so this is no longer an issue. > The clone method does

[jira] Updated: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializa

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury updated THRIFT-1038: -- Attachment: thrift-1038-v2.patch Mathias - what do you think about this version of the patch?

Build failed in Hudson: Thrift #42

2011-01-26 Thread Apache Hudson Server
See Changes: [bryanduxbury] THRIFT-1049. py: Allow for TServerSocket python library to bind to a specific host This patch adds a new host argument to TServerSocket that allows it to bind to a specific host. Patch: Jake Farrell

[jira] Closed: (THRIFT-1049) Allow for TServerSocket python library to bind to a specific host

2011-01-26 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Duxbury closed THRIFT-1049. - Resolution: Fixed Fix Version/s: 0.7 Assignee: Jake Farrell I just committed thi

[jira] Updated: (THRIFT-1049) Allow for TServerSocket python library to bind to a specific host

2011-01-26 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-1049: - Attachment: thrift_1049.patch > Allow for TServerSocket python library to bind to a specific hos

[jira] Created: (THRIFT-1049) Allow for TServerSocket python library to bind to a specific host

2011-01-26 Thread Jake Farrell (JIRA)
Allow for TServerSocket python library to bind to a specific host - Key: THRIFT-1049 URL: https://issues.apache.org/jira/browse/THRIFT-1049 Project: Thrift Issue Type: Improveme

[jira] Created: (THRIFT-1048) Thrift java library has redundant dependency on commons-lang.

2011-01-26 Thread Vladimir Zhilyaev (JIRA)
Thrift java library has redundant dependency on commons-lang. - Key: THRIFT-1048 URL: https://issues.apache.org/jira/browse/THRIFT-1048 Project: Thrift Issue Type: Improvement