Re: Thrift on Apache Reviewboard

2011-07-07 Thread Diwaker Gupta
Thanks Jake. Tony was quick to set us up! Folks, I highly recommend using the Apache ReviewBoard to review patches. If you haven't used ReviewBoard before, it's a great tool for doing code reviews online. Once the code is ready for merging, you can still attach the diff to Jira (for the ASF licens

Review Request: Remove unused include in generated C++ code

2011-07-07 Thread Diwaker Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1034/ --- Review request for Thrift. Summary --- Remove unused include in generated C

[jira] [Issue Comment Edited] (THRIFT-1195) Allow users to act on client connects/disconnects

2011-07-07 Thread Dragan Okiljevic (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061343#comment-13061343 ] Dragan Okiljevic edited comment on THRIFT-1195 at 7/7/11 2:30 PM: -

[jira] [Updated] (THRIFT-1195) Allow users to act on client connects/disconnects

2011-07-07 Thread Dragan Okiljevic (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dragan Okiljevic updated THRIFT-1195: - Attachment: Java_Thrift_TestServer_patch_to_demonstrate_ServerEventHandler_functionality

[jira] [Updated] (THRIFT-1232) JavaScript TException should be a constructor function

2011-07-07 Thread Pascal Bach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Bach updated THRIFT-1232: Attachment: 1232-Improve-Exception-handling-and-make-error-hierarchy.patch I improved the prototyp

[jira] [Updated] (THRIFT-1232) JavaScript TException should be a constructor function

2011-07-07 Thread Pascal Bach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Bach updated THRIFT-1232: Attachment: 0001-Improve-Exception-handling.patch TException is now derived from JavaScripts Error