[
https://issues.apache.org/jira/browse/THRIFT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier reassigned THRIFT-1748:
---
Assignee: Roger Meier
> Guard and RWGuard macros defined in global namespace
> -
[
https://issues.apache.org/jira/browse/THRIFT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-1748.
-
Resolution: Fixed
global macros removed
> Guard and RWGuard macros defined in g
Thanks, I'd hate to patch this myself every release.
https://issues.apache.org/jira/browse/THRIFT-1748
Oh and sorry, I couldn't find "attach" in JIRA, maybe I don't have
permissions, so I had to post the code.
On Wed, Nov 7, 2012 at 5:23 AM, Henrique Mendonça wrote:
> Hi Bud,
>
> I wonder why we
[
https://issues.apache.org/jira/browse/THRIFT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492455#comment-13492455
]
Bud Bundy commented on THRIFT-1748:
---
{code}
Index: Mutex.h
[
https://issues.apache.org/jira/browse/THRIFT-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bud Bundy updated THRIFT-1748:
--
Labels: newbie patch (was: )
> Guard and RWGuard macros defined in global namespace
> ---
Bud Bundy created THRIFT-1748:
-
Summary: Guard and RWGuard macros defined in global namespace
Key: THRIFT-1748
URL: https://issues.apache.org/jira/browse/THRIFT-1748
Project: Thrift
Issue Type: B
I can sympathize with the author of the offending #defines, as I've seen
the bug that he references a number of times. I think that "Guard" is too
generic to #define away though. If only compilers would actually warn
about the offending usage...
From: Henrique Mendonça
To: u...@thrif
Hi Bud,
I wonder why we are not using boost mutex and scoped mutex instead but
those two macros are probably not necessary anyways.
Would you create a patch and copy/adapt those comments to the thrift Mutex
classes themselves?
Thank you!
http://thrift.apache.org/docs/HowToContribute/
Henrique
On
