[jira] [Commented] (THRIFT-1833) Thrift generates incorrect C++ writer for union

2013-02-04 Thread Alan Choi (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570869#comment-13570869 ] Alan Choi commented on THRIFT-1833: --- Hi, I've attached a patch to resolve this issue.

[jira] [Updated] (THRIFT-1833) Thrift generates incorrect C++ writer for union

2013-02-04 Thread Alan Choi (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Choi updated THRIFT-1833: -- Attachment: Thrift-1833.diff THRIFT-1833 Fix C++ union issue. Default field in an union should be tre

[jira] [Commented] (THRIFT-1732) Thrift should provide deep-validation of structures

2013-02-04 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570690#comment-13570690 ] Jens Geyer commented on THRIFT-1732: I had a problem applying the patch against trunk

[jira] [Commented] (THRIFT-1732) Thrift should provide deep-validation of structures

2013-02-04 Thread Kevin Stanton (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570616#comment-13570616 ] Kevin Stanton commented on THRIFT-1732: --- +1, thanks for this > Thr