[jira] [Commented] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951637#comment-13951637 ] Hudson commented on THRIFT-2430: SUCCESS: Integrated in Thrift #1099 (See [https://build

[jira] [Commented] (THRIFT-2009) Go redeclaration error

2014-03-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951609#comment-13951609 ] Jens Geyer commented on THRIFT-2009: http://www.golangpatterns.info/object-oriented/c

[jira] [Updated] (THRIFT-2398) Improve Node Server Library

2014-03-28 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy updated THRIFT-2398: Fix Version/s: 0.9.2 > Improve Node Server Library > --- > >

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951432#comment-13951432 ] Randy Abernethy commented on THRIFT-2429: - Hey Chris, More likely a bad explanat

[GitHub] thrift pull request: New option: reuse-objects for Java generator

2014-03-28 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/81#issuecomment-38967249 That would be great Adam! Maybe someone else has a better idea, but you can have a look on https://github.com/apache/thrift/blob/master/lib/java/build.xml \ perha

[jira] [Resolved] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2430. Resolution: Fixed LGTM, and if it solves the issue - committed. Thanks Lars! > Crash during TThr

[jira] [Commented] (THRIFT-1766) [Ruby] Provide support for binary types

2014-03-28 Thread Vanja Bucic (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951330#comment-13951330 ] Vanja Bucic commented on THRIFT-1766: - We are currently using my patched gem internal

[GitHub] thrift pull request: New option: reuse-objects for Java generator

2014-03-28 Thread adam-aph
Github user adam-aph commented on the pull request: https://github.com/apache/thrift/pull/81#issuecomment-38963405 unfortunatelly you are right ;) I can create updated unit test based on existing one for java - but I'm not familiar enough with Thrift to judge what I should use as t

[jira] [Commented] (THRIFT-2398) Improve Node Server Library

2014-03-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951312#comment-13951312 ] Hudson commented on THRIFT-2398: SUCCESS: Integrated in Thrift #1098 (See [https://build

[jira] [Reopened] (THRIFT-1766) [Ruby] Provide support for binary types

2014-03-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reopened THRIFT-1766: [~vanjabucic] made a good point. We should at least check this. > [Ruby] Provide support for binary t

[jira] [Assigned] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2430: -- Assignee: Jens Geyer > Crash during TThreadPoolServer shutdown > -

[GitHub] thrift pull request: New option: reuse-objects for Java generator

2014-03-28 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/81#issuecomment-38960936 in this case we should have at least unit-tests demonstrating, and testing, the correct usage. What do you think? --- If your project is set up for it, you can repl

[GitHub] thrift pull request: New option: reuse-objects for Java generator

2014-03-28 Thread adam-aph
Github user adam-aph commented on the pull request: https://github.com/apache/thrift/pull/81#issuecomment-38957593 Hi Henrique - I think this new parameter would be required - the patch is not breaking existing code, however it may reveal issues in existing applications (currently the

[jira] [Updated] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Lars Benner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Benner updated THRIFT-2430: Patch Info: Patch Available > Crash during TThreadPoolServer shutdown > --

[GitHub] thrift pull request: New option: reuse-objects for Java generator

2014-03-28 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/81#issuecomment-38956541 Hi Adam, thanks for the request. Do you think this new parameter is really necessary? I would take this change more as a direct improvement since it wouldn't break

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Chris Stylianou (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950914#comment-13950914 ] Chris Stylianou commented on THRIFT-2429: - Hi Randy, thanks for your response.

[jira] [Updated] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell updated THRIFT-2429: - Assignee: Randy Abernethy > Provide option to not write default values, rely on receiver default

[jira] [Commented] (THRIFT-878) Document "core" vs "extra" features

2014-03-28 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950679#comment-13950679 ] Randy Abernethy commented on THRIFT-878: Might be nice to have this md (or an impr

[GitHub] thrift pull request: Adds composer.json for Thrift dev-master bran...

2014-03-28 Thread jfarrell
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/91#issuecomment-38945719 Thanks for the patch @maurotdo, will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Dave Watson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951105#comment-13951105 ] Dave Watson commented on THRIFT-2429: - fbthrift branch implemented this almost exactl

[GitHub] thrift pull request: Adds composer.json for Thrift dev-master bran...

2014-03-28 Thread maurotdo
GitHub user maurotdo opened a pull request: https://github.com/apache/thrift/pull/91 Adds composer.json for Thrift dev-master branch Adds composer.json for Thrift dev-master branch Given that the next release will likely be 1.0.0, i've aliased the dev-master branch to 1.0.x

[jira] [Created] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Lars Benner (JIRA)
Lars Benner created THRIFT-2430: --- Summary: Crash during TThreadPoolServer shutdown Key: THRIFT-2430 URL: https://issues.apache.org/jira/browse/THRIFT-2430 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Lars Benner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950956#comment-13950956 ] Lars Benner commented on THRIFT-2430: - Hi Lars, just create a JIRA ticket and add th

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Chris Stylianou (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951050#comment-13951050 ] Chris Stylianou commented on THRIFT-2429: - Hi Randy, It might be a Friday aftern

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951003#comment-13951003 ] Randy Abernethy commented on THRIFT-2429: - Hey Chris, I see where you are coming

[jira] [Updated] (THRIFT-2430) Crash during TThreadPoolServer shutdown

2014-03-28 Thread Lars Benner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Benner updated THRIFT-2430: Attachment: thrift-2430-crash-fix.patch Added patch for fixing the crash. > Crash during TThread

[jira] [Commented] (THRIFT-1766) [Ruby] Provide support for binary types

2014-03-28 Thread Vanja Bucic (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950876#comment-13950876 ] Vanja Bucic commented on THRIFT-1766: - Can someone please reopen this issue, or shoul

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950816#comment-13950816 ] Randy Abernethy commented on THRIFT-2429: - Hi Chris, Default parameters (particu

[jira] [Created] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-03-28 Thread Chris Stylianou (JIRA)
Chris Stylianou created THRIFT-2429: --- Summary: Provide option to not write default values, rely on receiver default construction instead Key: THRIFT-2429 URL: https://issues.apache.org/jira/browse/THRIFT-2429

Re: Error while running nodejs test servers and clients

2014-03-28 Thread Randy Abernethy
Hi Chamila, Perhaps I can help on the Node.js front. I assume you are you working with the trunk, and if so: You do not want to npm install any part of thrift. Running npm install thrift will install the latest published branch of thrift for Node.js, which is 0.9.1 right now. Because the test

[GitHub] thrift pull request: Add Composer.json for Thrift 0.9.1 release

2014-03-28 Thread maurotdo
GitHub user maurotdo opened a pull request: https://github.com/apache/thrift/pull/90 Add Composer.json for Thrift 0.9.1 release The 0.9.1 release is missing composer.json. This patch applies the same composer.json from branch 0.9.x into branch 0.9.1 I do not know if it