[jira] [Commented] (THRIFT-2421) Tree/Recursive struct support in thrift

2014-04-07 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961832#comment-13961832 ] Ben Craig commented on THRIFT-2421: --- I don't have the time to personally test / commit

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961968#comment-13961968 ] Aleksey Pesternikov commented on THRIFT-2232: - I started changing my existing

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961980#comment-13961980 ] Ben Sigelman commented on THRIFT-2232: -- Hi [~apesternikov], A few responses: -

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961990#comment-13961990 ] Ben Sigelman commented on THRIFT-2451: -- A few responses. - It's not clear to me

[jira] [Reopened] (THRIFT-2325) SSL test certificates

2014-04-07 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier reopened THRIFT-2325: - I'm doing some rework on cpp documentation README.md, README.SSL.md and README_WINDOWS.md Have to

[jira] [Resolved] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2445. Resolution: Fixed Fix Version/s: 0.9.2 Committed. Folder structure subject to be

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962192#comment-13962192 ] Jens Geyer commented on THRIFT-2451: Hi [~apesternikov] and [~bensigelman], there

[jira] [Updated] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2451: --- Description: Currently, for optional fields in struct {code} struct pkt { 1: optional string s =

Build failed in Jenkins: Thrift #1119

2014-04-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift/1119/changes Changes: [jensg] THRIFT-2445 (code generation for go maps with binary keys) should be tested -- [...truncated 1779 lines...] libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../..

[jira] [Commented] (THRIFT-2445) THRIFT-2384 (code generation for go maps with binary keys) should be tested

2014-04-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962206#comment-13962206 ] Hudson commented on THRIFT-2445: FAILURE: Integrated in Thrift #1119 (See

Build failed in Jenkins: Thrift-Compiler-Windows #1171

2014-04-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift-Compiler-Windows/1171/changes Changes: [jensg] THRIFT-2445 (code generation for go maps with binary keys) should be tested -- [...truncated 250 lines...] checking for wchar.h... yes checking for pthread_create in

[jira] [Commented] (THRIFT-2452) Python doesn't handle unexpected Exceptions in server

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962209#comment-13962209 ] Jens Geyer commented on THRIFT-2452: -1 for [this

[jira] [Comment Edited] (THRIFT-2452) Python doesn't handle unexpected Exceptions in server

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962209#comment-13962209 ] Jens Geyer edited comment on THRIFT-2452 at 4/7/14 8:25 PM:

[jira] [Comment Edited] (THRIFT-2452) Python doesn't handle unexpected Exceptions in server

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962209#comment-13962209 ] Jens Geyer edited comment on THRIFT-2452 at 4/7/14 8:27 PM:

[jira] [Updated] (THRIFT-2452) Python doesn't handle unexpected Exceptions in server

2014-04-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2452: --- Description: Based on THRIFT-378, the appropriate behaviour is to throw a TApplicationException

[jira] [Updated] (THRIFT-2325) SSL test certificates

2014-04-07 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier updated THRIFT-2325: Attachment: 0001-THRIFT-2325-SSL-test-certificates.patch the patch SSL test certificates

[jira] [Resolved] (THRIFT-2325) SSL test certificates

2014-04-07 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2325. - Resolution: Fixed committed SSL test certificates -

Jenkins build is back to normal : Thrift-Compiler-Windows #1172

2014-04-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift-Compiler-Windows/1172/changes

Build failed in Jenkins: Thrift #1120

2014-04-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift/1120/changes Changes: [roger] THRIFT-2325: SSL test certificates -- [...truncated 1778 lines...] libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift -I../../lib/cpp/src -Igen-cpp

[jira] [Commented] (THRIFT-2325) SSL test certificates

2014-04-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962342#comment-13962342 ] Hudson commented on THRIFT-2325: FAILURE: Integrated in Thrift #1120 (See

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962357#comment-13962357 ] Aleksey Pesternikov commented on THRIFT-2451: - Per discussion in THRIFT-2429,

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962365#comment-13962365 ] Aleksey Pesternikov commented on THRIFT-2451: - After my attempt to use it, I

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962366#comment-13962366 ] Ben Sigelman commented on THRIFT-2451: -- I added the pointers to slices/maps partly

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962373#comment-13962373 ] Aleksey Pesternikov commented on THRIFT-2451: - to get in line with

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962376#comment-13962376 ] Ben Sigelman commented on THRIFT-2451: -- I'm not on the thrift team and will thus

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962377#comment-13962377 ] Aleksey Pesternikov commented on THRIFT-2451: - Ben, I understand that nil

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962386#comment-13962386 ] Ben Sigelman commented on THRIFT-2451: -- You and I have divergent opinions about the

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962394#comment-13962394 ] Aleksey Pesternikov commented on THRIFT-2451: - Using `nil` to represent both

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962396#comment-13962396 ] Ben Sigelman commented on THRIFT-2429: -- FYI, I am neither an official thrift

Jenkins build is back to normal : Thrift #1121

2014-04-07 Thread Apache Jenkins Server
See https://builds.apache.org/job/Thrift/1121/changes

[jira] [Commented] (THRIFT-847) Test Framework harmonization across all languages

2014-04-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962397#comment-13962397 ] Hudson commented on THRIFT-847: --- SUCCESS: Integrated in Thrift #1121 (See

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962399#comment-13962399 ] Ben Sigelman commented on THRIFT-2451: -- My point was that some people use a nil

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

2014-04-07 Thread Aleksey Pesternikov (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962446#comment-13962446 ] Aleksey Pesternikov commented on THRIFT-2451: - I come from the world of

[jira] [Commented] (THRIFT-2452) Python doesn't handle unexpected Exceptions in server

2014-04-07 Thread James Haggerty (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962477#comment-13962477 ] James Haggerty commented on THRIFT-2452: Thanks, Jens. Didn't check the comments

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-07 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962557#comment-13962557 ] Randy Abernethy commented on THRIFT-2429: - Hey Ben, Thanks for the thoughts.

[jira] [Created] (THRIFT-2453) haskell tutorial: fix up division by 0 example

2014-04-07 Thread John Chee (JIRA)
John Chee created THRIFT-2453: - Summary: haskell tutorial: fix up division by 0 example Key: THRIFT-2453 URL: https://issues.apache.org/jira/browse/THRIFT-2453 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-2453) haskell tutorial: fix up division by 0 example

2014-04-07 Thread John Chee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Chee updated THRIFT-2453: -- Attachment: 0001-haskell-tutorial-fix-up-division-by-0-example.patch haskell tutorial: fix up

[jira] [Updated] (THRIFT-2453) haskell tutorial: fix up division by 0 example

2014-04-07 Thread John Chee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Chee updated THRIFT-2453: -- Description: Fix the division by 0; exception example in the Haskell tutorial Running

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962575#comment-13962575 ] Ben Sigelman commented on THRIFT-2429: -- Using default values as a convenience is one

[jira] [Comment Edited] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-07 Thread Ben Sigelman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962575#comment-13962575 ] Ben Sigelman edited comment on THRIFT-2429 at 4/8/14 4:53 AM: