[jira] [Commented] (THRIFT-2478) Thrift c_glib binary protocol may go to infinite loop for bad input

2014-04-18 Thread Jaesang Kim (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973827#comment-13973827 ] Jaesang Kim commented on THRIFT-2478: - thrift_procotol.c is different from your

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973885#comment-13973885 ] Randy Abernethy commented on THRIFT-2471: - Hey Dave, In the C++ implementation

[jira] [Commented] (THRIFT-2460) unopened socket fd must be less than zero.

2014-04-18 Thread Jin-wook Jeong (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973935#comment-13973935 ] Jin-wook Jeong commented on THRIFT-2460: On Windows, SOCKET is unsigned int, and

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-18 Thread Nevo Hed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974016#comment-13974016 ] Nevo Hed commented on THRIFT-2473: -- So what is preventing you from adding the keyword

[jira] [Commented] (THRIFT-2009) Go redeclaration error

2014-04-18 Thread Chris Bannister (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974138#comment-13974138 ] Chris Bannister commented on THRIFT-2009: - This change causes service methods

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974247#comment-13974247 ] Jens Geyer commented on THRIFT-2473: Randy did a good job explaining this stuff over

[jira] [Commented] (THRIFT-2460) unopened socket fd must be less than zero.

2014-04-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974251#comment-13974251 ] Jens Geyer commented on THRIFT-2460: That's why I commented above. I still think it's

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Dave Watson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974267#comment-13974267 ] Dave Watson commented on THRIFT-2471: - Facebook's current use cases do not contain

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974274#comment-13974274 ] Ben Craig commented on THRIFT-2471: --- I'd rather not try to fix cycles magically. MSRPC

[jira] [Closed] (THRIFT-2456) THttpClient fails when using async support outside Silverlight

2014-04-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer closed THRIFT-2456. -- Resolution: Fixed Fix Version/s: 0.9.2 Committed a slightly modified version employing

[jira] [Commented] (THRIFT-2473) _isset entries shouldn't be generated for non-optional fields

2014-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974304#comment-13974304 ] Randy Abernethy commented on THRIFT-2473: - Default requiredness is a pretty

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974313#comment-13974313 ] Randy Abernethy commented on THRIFT-2471: - unique_ptr is a great implementation.

[jira] [Commented] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974315#comment-13974315 ] Jens Geyer commented on THRIFT-2471: {quote} I'd rather not try to fix cycles

[GitHub] thrift pull request: THRIFT-2456 Support async operations outside ...

2014-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2456) THttpClient fails when using async support outside Silverlight

2014-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974318#comment-13974318 ] ASF GitHub Bot commented on THRIFT-2456: Github user asfgit closed the pull

[jira] [Comment Edited] (THRIFT-2471) Make cpp.ref annotation language agnostic

2014-04-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974315#comment-13974315 ] Jens Geyer edited comment on THRIFT-2471 at 4/18/14 6:11 PM: -

[jira] [Commented] (THRIFT-2456) THttpClient fails when using async support outside Silverlight

2014-04-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974442#comment-13974442 ] Hudson commented on THRIFT-2456: SUCCESS: Integrated in Thrift #1137 (See

[jira] [Created] (THRIFT-2479) C++: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-2479: --- Summary: C++: Provide option to not write default values Key: THRIFT-2479 URL: https://issues.apache.org/jira/browse/THRIFT-2479 Project: Thrift Issue

[jira] [Created] (THRIFT-2481) Java: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-2481: --- Summary: Java: Provide option to not write default values Key: THRIFT-2481 URL: https://issues.apache.org/jira/browse/THRIFT-2481 Project: Thrift

[jira] [Updated] (THRIFT-2480) Python: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randy Abernethy updated THRIFT-2480: Description: The Python compiler updates needed to support =? default values. was:

[jira] [Created] (THRIFT-2482) C#: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-2482: --- Summary: C#: Provide option to not write default values Key: THRIFT-2482 URL: https://issues.apache.org/jira/browse/THRIFT-2482 Project: Thrift Issue

[jira] [Created] (THRIFT-2483) Go: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-2483: --- Summary: Go: Provide option to not write default values Key: THRIFT-2483 URL: https://issues.apache.org/jira/browse/THRIFT-2483 Project: Thrift Issue

[jira] [Created] (THRIFT-2484) Node.js: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-2484: --- Summary: Node.js: Provide option to not write default values Key: THRIFT-2484 URL: https://issues.apache.org/jira/browse/THRIFT-2484 Project: Thrift

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

2014-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974708#comment-13974708 ] Randy Abernethy commented on THRIFT-2429: - Sounds like there is support for

[jira] [Created] (THRIFT-2486) Markdown for: C++: Provide option to not write default values

2014-04-18 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-2486: --- Summary: Markdown for: C++: Provide option to not write default values Key: THRIFT-2486 URL: https://issues.apache.org/jira/browse/THRIFT-2486 Project: Thrift