[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...

2014-06-17 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46365166 Well spotted! We either have to stop the exceptions here, or TVirtualTransport has to allow throwing TTransportException's --- If your project is set up for it,

[jira] [Created] (THRIFT-2580) IIDs for generated Delphi interfaces

2014-06-17 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-2580: -- Summary: IIDs for generated Delphi interfaces Key: THRIFT-2580 URL: https://issues.apache.org/jira/browse/THRIFT-2580 Project: Thrift Issue Type: Improvement

[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...

2014-06-17 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46338660 The failing TFDTransport test is not about avoiding double-close but ensuring that the destructor throws. The problem is that C++11 defaults destructors to noexcept(true

Re: [jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-17 Thread Jake Farrell
+1 to pushing this to post 0.9.2 and we circle back and look at it then -Jake On Tue, Jun 17, 2014 at 9:42 AM, Henrique Mendonça wrote: > Hi guys, > > So just to clarify, what do you think about replacing the > "contrib/mingw-cross-compile.sh" by the cmake cross compilation in the > documentat

Re: [jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-17 Thread Henrique Mendonça
Hi guys, So just to clarify, what do you think about replacing the "contrib/mingw-cross-compile.sh" by the cmake cross compilation in the documentation like Roger suggested in the ticket? Anyone against it? Then do we delete the script to avoid redundancy or leave it? I'm also ok to first release

[jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2014-06-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033691#comment-14033691 ] Hudson commented on THRIFT-2571: SUCCESS: Integrated in Thrift #1185 (See [https://build

[jira] [Commented] (THRIFT-2570) Wrong URL given in http://thrift.apache.org/developers

2014-06-17 Thread Jingguo Yao (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033633#comment-14033633 ] Jingguo Yao commented on THRIFT-2570: - I tried http://git-wip-us.apache.org/repos/asf

[jira] [Updated] (THRIFT-2579) Windows CE support

2014-06-17 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2579: -- Attachment: THRIFT-2579-Windows-CE.patch This patch basically handles the lack of wind

[jira] [Created] (THRIFT-2579) Windows CE support

2014-06-17 Thread JIRA
Henrique Mendonça created THRIFT-2579: - Summary: Windows CE support Key: THRIFT-2579 URL: https://issues.apache.org/jira/browse/THRIFT-2579 Project: Thrift Issue Type: Improvement