[jira] [Commented] (THRIFT-2578) Moving 'make cross' from test.sh to test.py

2014-06-18 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036439#comment-14036439 ] Hudson commented on THRIFT-2578: SUCCESS: Integrated in Thrift #1186 (See [https://build

[jira] [Commented] (THRIFT-2582) "FileTransport error" exception is raised when trying to use Java's TFileTransport

2014-06-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036369#comment-14036369 ] Jens Geyer commented on THRIFT-2582: Yes, after taking a short look, the {{esize}} an

[jira] [Updated] (THRIFT-2582) "FileTransport error" exception is raised when trying to use Java's TFileTransport

2014-06-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2582: --- Description: I am trying to wrap a Java class to be called from Python using thrift's TFileTranspor

[jira] [Commented] (THRIFT-2578) Moving 'make cross' from test.sh to test.py

2014-06-18 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036350#comment-14036350 ] Roger Meier commented on THRIFT-2578: - please take care with trailing *whitespace*, I

[jira] [Updated] (THRIFT-2582) "FileTransport error" exception is raised when trying to use Java's TFileTransport

2014-06-18 Thread Ahmed Ali-Eldin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Ali-Eldin updated THRIFT-2582: Environment: (was: ) > "FileTransport error" exception is raised when trying to use J

[jira] [Created] (THRIFT-2582) "FileTransport error" exception is raised when trying to use Java's TFileTransport

2014-06-18 Thread Ahmed Ali-Eldin (JIRA)
Ahmed Ali-Eldin created THRIFT-2582: --- Summary: "FileTransport error" exception is raised when trying to use Java's TFileTransport Key: THRIFT-2582 URL: https://issues.apache.org/jira/browse/THRIFT-2582

[jira] [Updated] (THRIFT-2578) Moving 'make cross' from test.sh to test.py

2014-06-18 Thread Chamila Dilshan Wijayarathna (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chamila Dilshan Wijayarathna updated THRIFT-2578: - Attachment: 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-te

[jira] [Updated] (THRIFT-2578) Moving 'make cross' from test.sh to test.py

2014-06-18 Thread Chamila Dilshan Wijayarathna (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chamila Dilshan Wijayarathna updated THRIFT-2578: - Attachment: 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-te

[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...

2014-06-18 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46449069 Hi Ben, Have you had a look on the test case (and my small patch)? It does close a invalid fd on purpose to test the exception. We could delete the test but I th

[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...

2014-06-18 Thread ben-craig
Github user ben-craig commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46441037 Exceptions shouldn't leave close() or a destructor. I agree about that. I am still concerned about this sequence of events though: int rv = ::THRIFT_CLOSE(f

[jira] [Commented] (THRIFT-2581) TFDTransport destructor should not throw

2014-06-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14035517#comment-14035517 ] ASF GitHub Bot commented on THRIFT-2581: Github user henrique commented on the pu

[GitHub] thrift pull request: TFileTransport missuse of closesocket on wind...

2014-06-18 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/142#issuecomment-46415080 Could you guys comment on https://issues.apache.org/jira/browse/THRIFT-2581 ? Cheers, Henrique --- If your project is set up for it, you can reply to this email

[jira] [Updated] (THRIFT-2581) TFDTransport destructor should not throw

2014-06-18 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2581: -- Attachment: THRIFT-2581-TFDTransport-destructor.patch > TFDTransport destructor should

[jira] [Created] (THRIFT-2581) TFDTransport destructor should not throw

2014-06-18 Thread JIRA
Henrique Mendonça created THRIFT-2581: - Summary: TFDTransport destructor should not throw Key: THRIFT-2581 URL: https://issues.apache.org/jira/browse/THRIFT-2581 Project: Thrift Issue Ty