I hate thrift-0.9.2 and higher version

2015-04-16 Thread 易剑
too many compile erros in thrift-0.9.2 and higher, thrift-0.9.0 and lower is easy. Except erros, and there are many warnings.

AW: [jira] [Commented] (THRIFT-3067) C++ cppcheck performance related warnings

2015-04-16 Thread Jens Geyer
No, PR linked to JIRA is fine. Von: Arijit Chattopadhyay (JIRA) Gesendet: 16.04.2015 02:47 An: dev@thrift.apache.org Betreff: [jira] [Commented] (THRIFT-3067) C++ cppcheck performance related warnings [

AW: I hate thrift-0.9.2 and higher version

2015-04-16 Thread Jens Geyer
Very constructive. Thank you. Von: 易剑 Gesendet: 16.04.2015 08:02 An: dev@thrift.apache.org Betreff: I hate thrift-0.9.2 and higher version too many compile erros in thrift-0.9.2 and higher, thrift-0.9.0 and lower is easy. Except erros, and there are many

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-04-16 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/436#issuecomment-93725966 merged as 6d71dc868873691a62b3cb28bf48dcb0e225fa95 147a5a278a71e4652edb8f60043a057f26d60d1d --- If your project is set up for it, you can reply to this email and have

[GitHub] thrift pull request: THRIFT-3099 cmake build is broken on FreeBSD

2015-04-16 Thread marco-m
GitHub user marco-m opened a pull request: https://github.com/apache/thrift/pull/446 THRIFT-3099 cmake build is broken on FreeBSD See https://issues.apache.org/jira/browse/THRIFT-3099 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-3099) cmake build is broken on FreeBSD

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498025#comment-14498025 ] ASF GitHub Bot commented on THRIFT-3099: GitHub user marco-m opened a pull

[GitHub] thrift pull request: THRIFT-2946 Enhance usability of cross test f...

2015-04-16 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2946) Enhance usability of cross test framework

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498008#comment-14498008 ] ASF GitHub Bot commented on THRIFT-2946: Github user nsuke closed the pull

[jira] [Created] (THRIFT-3099) cmake build is broken on FreeBSD

2015-04-16 Thread Marco Molteni (JIRA)
Marco Molteni created THRIFT-3099: - Summary: cmake build is broken on FreeBSD Key: THRIFT-3099 URL: https://issues.apache.org/jira/browse/THRIFT-3099 Project: Thrift Issue Type: Bug

Re: I hate thrift-0.9.2 and higher version

2015-04-16 Thread Roger Meier
Dear 易剑 Recommended reading for you: - http://www.catb.org/esr/faqs/smart-questions.html - https://www.ietf.org/rfc/rfc1855.txt - http://en.wikipedia.org/wiki/Etiquette_in_technology - http://zh.wikipedia.org/wiki/%E7%B6%B2%E7%B5%A1%E7%A6%AE%E5%84%80 (should be the same as above in your

[jira] [Updated] (THRIFT-3099) cmake build is broken on FreeBSD

2015-04-16 Thread Marco Molteni (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Molteni updated THRIFT-3099: -- Description: Cmake build is broken on FreeBSD. Among the problems: h4. Building the c_glib

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-16 Thread abadcafe
Github user abadcafe commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r28510532 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1397,42 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection*

Re: [jira] [Commented] (THRIFT-3067) C++ cppcheck performance related warnings

2015-04-16 Thread arijit chattopadhyay
I could see that it is failed but the reason is not related to my changes. I will close and reopen it. Thanks. Arijit On Thu, Apr 16, 2015 at 10:34 AM, James E. King, III (JIRA) j...@apache.org wrote: [

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
Github user arijitvt closed the pull request at: https://github.com/apache/thrift/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
GitHub user arijitvt reopened a pull request: https://github.com/apache/thrift/pull/444 Thrift-3067 Implemented Changes related Thirft Jira Issue :3067 You can merge this pull request into a Git repository by running: $ git pull https://github.com/arijitvt/thrift THRIFT-3067

[jira] [Commented] (THRIFT-3080) C++ TNonblockingServer connection leak while accept huge number connections.

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498097#comment-14498097 ] ASF GitHub Bot commented on THRIFT-3080: Github user jeking3 commented on a diff

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-16 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r28515512 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1397,42 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection*

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
Github user arijitvt closed the pull request at: https://github.com/apache/thrift/pull/444 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
Github user arijitvt commented on the pull request: https://github.com/apache/thrift/pull/444#issuecomment-93773899 Build failed for non-related issues. Will be reopening. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (THRIFT-3067) C++ cppcheck performance related warnings

2015-04-16 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498086#comment-14498086 ] James E. King, III commented on THRIFT-3067: No, the pull request is enough.

[jira] [Commented] (THRIFT-3080) C++ TNonblockingServer connection leak while accept huge number connections.

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498053#comment-14498053 ] ASF GitHub Bot commented on THRIFT-3080: Github user abadcafe commented on a diff

[GitHub] thrift pull request: THRIFT-3080: fix connection leak of C++ Nonbl...

2015-04-16 Thread abadcafe
Github user abadcafe commented on a diff in the pull request: https://github.com/apache/thrift/pull/422#discussion_r28532945 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1393,9 +1397,42 @@ bool TNonblockingIOThread::notify(TNonblockingServer::TConnection*

[jira] [Commented] (THRIFT-3080) C++ TNonblockingServer connection leak while accept huge number connections.

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498373#comment-14498373 ] ASF GitHub Bot commented on THRIFT-3080: Github user abadcafe commented on a diff

[GitHub] thrift pull request: Thrift-3067

2015-04-16 Thread arijitvt
GitHub user arijitvt reopened a pull request: https://github.com/apache/thrift/pull/444 Thrift-3067 Implemented Changes related Thirft Jira Issue :3067 You can merge this pull request into a Git repository by running: $ git pull https://github.com/arijitvt/thrift THRIFT-3067

[GitHub] thrift pull request: Issue with IPv6 an IPv4 on windows machines

2015-04-16 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/377#issuecomment-93822001 @sharpdevel: Didn't recognize that PR, it somehow got lost in the mails. Could you file a JIRA ticket and reopen the PR mentioning the ticket number? I'll take a look at

[jira] [Created] (THRIFT-3100) Implement standard Thrift test for Cocoa

2015-04-16 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-3100: -- Summary: Implement standard Thrift test for Cocoa Key: THRIFT-3100 URL: https://issues.apache.org/jira/browse/THRIFT-3100 Project: Thrift Issue Type:

[jira] [Assigned] (THRIFT-3041) Generate asynchronous clients for Cocoa

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-3041: -- Assignee: Jens Geyer Generate asynchronous clients for Cocoa

[jira] [Commented] (THRIFT-3099) cmake build is broken on FreeBSD

2015-04-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498701#comment-14498701 ] Hudson commented on THRIFT-3099: SUCCESS: Integrated in Thrift #1511 (See

[jira] [Commented] (THRIFT-3041) Generate asynchronous clients for Cocoa

2015-04-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498702#comment-14498702 ] Hudson commented on THRIFT-3041: SUCCESS: Integrated in Thrift #1511 (See

[jira] [Commented] (THRIFT-3047) Uneven calls to indent_up and indent_down in Cocoa generator

2015-04-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498700#comment-14498700 ] Hudson commented on THRIFT-3047: SUCCESS: Integrated in Thrift #1511 (See

[jira] [Commented] (THRIFT-3047) Uneven calls to indent_up and indent_down in Cocoa generator

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498634#comment-14498634 ] ASF GitHub Bot commented on THRIFT-3047: Github user asfgit closed the pull

[jira] [Commented] (THRIFT-3041) Generate asynchronous clients for Cocoa

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498635#comment-14498635 ] ASF GitHub Bot commented on THRIFT-3041: Github user asfgit closed the pull

[jira] [Assigned] (THRIFT-3098) Thrift does not pretty print binary typedefs the way it does binary fields

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-3098: -- Assignee: Jens Geyer Thrift does not pretty print binary typedefs the way it does binary

[jira] [Commented] (THRIFT-3098) Thrift does not pretty print binary typedefs the way it does binary fields

2015-04-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498656#comment-14498656 ] Hudson commented on THRIFT-3098: SUCCESS: Integrated in Thrift #1510 (See

[jira] [Resolved] (THRIFT-1471) toString() does not print ByteBuffer values when nested in a List

2015-04-16 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-1471. - Resolution: Duplicate toString() does not print ByteBuffer values when nested in a List

[jira] [Resolved] (THRIFT-3047) Uneven calls to indent_up and indent_down in Cocoa generator

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3047. Resolution: Fixed Committed, thanks! Uneven calls to indent_up and indent_down in Cocoa

[jira] [Resolved] (THRIFT-3041) Generate asynchronous clients for Cocoa

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3041. Resolution: Fixed Committed, thanks! Generate asynchronous clients for Cocoa

[jira] [Commented] (THRIFT-2640) Compact Protocol in Cocoa

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498566#comment-14498566 ] Jens Geyer commented on THRIFT-2640: Hi [~rushi] and [~jeremyw.sherman], any comments

[GitHub] thrift pull request: THRIFT-3047: Fixing indentation for generated...

2015-04-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3098) Thrift does not pretty print binary typedefs the way it does binary fields

2015-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498560#comment-14498560 ] ASF GitHub Bot commented on THRIFT-3098: Github user asfgit closed the pull

[jira] [Resolved] (THRIFT-3098) Thrift does not pretty print binary typedefs the way it does binary fields

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3098. Resolution: Fixed Fix Version/s: 0.9.3 Committed, thank you! Thrift does not pretty print

[GitHub] thrift pull request: THRIFT-3098 Print binary typedefs the same wa...

2015-04-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (THRIFT-3047) Uneven calls to indent_up and indent_down in Cocoa generator

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-3047: -- Assignee: Jens Geyer Uneven calls to indent_up and indent_down in Cocoa generator

[jira] [Assigned] (THRIFT-2640) Compact Protocol in Cocoa

2015-04-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-2640: -- Assignee: Jens Geyer Compact Protocol in Cocoa -

[jira] [Commented] (THRIFT-2640) Compact Protocol in Cocoa

2015-04-16 Thread Jeremy W. Sherman (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499020#comment-14499020 ] Jeremy W. Sherman commented on THRIFT-2640: --- I'll add comments to the GitHub

[GitHub] thrift pull request: THRIFT-227 Pretty print binary collections in...

2015-04-16 Thread bpodgursky
Github user bpodgursky commented on the pull request: https://github.com/apache/thrift/pull/441#issuecomment-93883084 nice --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Comment Edited] (THRIFT-3013) make thrift compiler accept a list of input files

2015-04-16 Thread Xiaoshuang LU (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14497522#comment-14497522 ] Xiaoshuang LU edited comment on THRIFT-3013 at 4/17/15 2:28 AM: