Re: method names sent as strings

2015-04-19 Thread Randy Abernethy
Hey Dave, I can’t speak to the original motivations, but one view on the methods front might be that method ordinals would be a little more prone to collisions than method names in scenarios where service inheritance is in place (particularly if the service interfaces are controlled by separate

[jira] [Commented] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message

2015-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501976#comment-14501976 ] ASF GitHub Bot commented on THRIFT-2817: Github user Jens-G commented on the pull

[GitHub] thrift pull request: Fixes THRIFT-2817 and THRIFT-2839

2015-04-19 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/273#issuecomment-94287436 @bivas Could you provide a PR addressing these issues? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[jira] [Commented] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message

2015-04-19 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501857#comment-14501857 ] Jens Geyer commented on THRIFT-2817: Could you provide a PR addressing these issues?

AW: [GitHub] thrift pull request: THRIFT-2640: Compact Protocol in Cocoa

2015-04-19 Thread Jens Geyer
I do that anyway when doing the merge. But less commits mean less potential prbs. I would like to hear someone elses opinion before I'm going to merge. Von: creker Gesendet: 19.04.2015 04:05 An: dev@thrift.apache.org Betreff: [GitHub] thrift pull request: THRIFT-2

[jira] [Commented] (THRIFT-2820) Implement an alternative Transport for JS using the AngularJS $http-service

2015-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501833#comment-14501833 ] ASF GitHub Bot commented on THRIFT-2820: Github user henrique commented on a diff

[GitHub] thrift pull request: [THRIFT-2820] Implement an alternative Transp...

2015-04-19 Thread henrique
Github user henrique commented on a diff in the pull request: https://github.com/apache/thrift/pull/413#discussion_r28652449 --- Diff: lib/js/test/test-angular.html --- @@ -0,0 +1,58 @@ +http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";> + +http://www.w3.org/1999/xh

[jira] [Commented] (THRIFT-3101) Thrift cannot support the collection whose element is null

2015-04-19 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501823#comment-14501823 ] Henrique Mendonça commented on THRIFT-3101: --- [~xiaopeng] Please see the "Attach

[jira] [Updated] (THRIFT-2850) CMake for Apache Thrift

2015-04-19 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2850: -- Labels: cmake travis (was: ) > CMake for Apache Thrift > --- > >

[jira] [Commented] (THRIFT-2817) TSimpleJSONProtocol reads beyond end of message

2015-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501818#comment-14501818 ] ASF GitHub Bot commented on THRIFT-2817: Github user bivas commented on the pull

[GitHub] thrift pull request: Fixes THRIFT-2817 and THRIFT-2839

2015-04-19 Thread bivas
Github user bivas commented on the pull request: https://github.com/apache/thrift/pull/273#issuecomment-94269795 We're still experiencing read errors with this fix merged (`Not enough frame size 4085 to read 4096 bytes`) The commit is missing a `return` statement in case of `f

Re: C# .NET framework minimum version?

2015-04-19 Thread Roger Meier
Yes, it make sense to go for 4.5 cheers roger Quoting Jens Geyer : Hi *, the question raised what we should support as the minimum version for .NET with C#. Before THRIFT-3000 all projects were set to Framework 3.5. I’ve checked the mono support and found that 4.5 seems to be available

[jira] [Commented] (THRIFT-2571) Simplify cross compilation using CMake

2015-04-19 Thread Pascal Bach (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501733#comment-14501733 ] Pascal Bach commented on THRIFT-2571: - Is the issue with libevent or with thrift? I'm