[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510799#comment-14510799 ] ASF GitHub Bot commented on THRIFT-2441: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-2941) Convert processor to use switch instead of map

2015-04-24 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510808#comment-14510808 ] James E. King, III commented on THRIFT-2941: This pull request failed in

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511098#comment-14511098 ] Ben Craig commented on THRIFT-2441: --- committed. Thanks jeking3! Cannot shutdown

[jira] [Resolved] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-24 Thread Ben Craig (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Craig resolved THRIFT-2441. --- Resolution: Fixed Cannot shutdown TThreadedServer when clients are still connected

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-24 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511479#comment-14511479 ] James E. King, III commented on THRIFT-3081: I don't quite understand why

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511166#comment-14511166 ] ASF GitHub Bot commented on THRIFT-3081: GitHub user jeking3 opened a pull

[GitHub] thrift pull request: THRIFT-2441 prevent client connections from d...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/424#issuecomment-95952386 Committed - closing pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/460 bugfix/THRIFT-3081 consolidate client processing loops in simple and threaded servers This provides consistency to client handling throughout the client lifecycle across all the simple and

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-95976890 1249.8 failed in javascript - I did not touch javascript; recycling the pull request to kick a new build --- If your project is set up for it, you can reply to this

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/460 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-95959732 Actually the merge is correct; I don't know why github decided to make it difficult. The diffs are accurate. I did this work on top of THRIFT-2441 on my fork.

[GitHub] thrift pull request: Support negative hex literals in IDL

2015-04-24 Thread mreve
GitHub user mreve opened a pull request: https://github.com/apache/thrift/pull/461 Support negative hex literals in IDL As it is now, the parser doesn't allow hex constant values to be negative (it throws a 'bad syntax' error). The change updates the regex and the code that

[jira] [Commented] (THRIFT-233) IDL doesn't support negative hex literals

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511261#comment-14511261 ] ASF GitHub Bot commented on THRIFT-233: --- GitHub user mreve opened a pull request:

[jira] [Commented] (THRIFT-2441) Cannot shutdown TThreadedServer when clients are still connected

2015-04-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511148#comment-14511148 ] Hudson commented on THRIFT-2441: SUCCESS: Integrated in Thrift #1517 (See

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511268#comment-14511268 ] ASF GitHub Bot commented on THRIFT-3081: Github user jeking3 commented on the

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511270#comment-14511270 ] ASF GitHub Bot commented on THRIFT-3081: GitHub user jeking3 reopened a pull

[jira] [Commented] (THRIFT-3081) C++ Consolidate client processing loops in TServers

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511269#comment-14511269 ] ASF GitHub Bot commented on THRIFT-3081: Github user jeking3 closed the pull

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
GitHub user jeking3 reopened a pull request: https://github.com/apache/thrift/pull/460 bugfix/THRIFT-3081 consolidate client processing loops in simple and threaded servers This provides consistency to client handling throughout the client lifecycle across all the simple and

[GitHub] thrift pull request: bugfix/THRIFT-3081 consolidate client process...

2015-04-24 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/460#issuecomment-95956705 Yuck, bad merge. Something odd happened. Checking into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-24 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-96126819 No, Jenkins not calling cross tests made the difference. In fact, the log shows that Jenkins doesn't even **build** following languages at all (Building : no):

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-24 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-95990799 How about having unified base for testing ? Can we have build scripts **inside** the repository and invoke them from both Jenkins and Travis/Appveyer ? --- If your

[jira] [Commented] (THRIFT-3111) C# library requries .NET 4.5 compatible Mono

2015-04-24 Thread Nobuaki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511325#comment-14511325 ] Nobuaki Sukegawa commented on THRIFT-3111: -- I thought you were intending to

[jira] [Commented] (THRIFT-3000) .NET implementation has trouble with mixed IP modes

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511330#comment-14511330 ] ASF GitHub Bot commented on THRIFT-3000: Github user nsuke commented on the pull

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511345#comment-14511345 ] ASF GitHub Bot commented on THRIFT-2850: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-24 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/456#discussion_r29066107 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -319,7 +319,7 @@ void TSSLSocket::checkHandshake() { return; } ssl_ =

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511548#comment-14511548 ] ASF GitHub Bot commented on THRIFT-2850: Github user jeking3 commented on a diff

[GitHub] thrift pull request: THRIFT-2850 cmake win cpp library and unit te...

2015-04-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/456#discussion_r29076042 --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp --- @@ -319,7 +319,7 @@ void TSSLSocket::checkHandshake() { return; } ssl_ =

[GitHub] thrift pull request: THRIFT-3000 .NET implementation has trouble w...

2015-04-24 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/450#issuecomment-96044497 They both call the usual suspects: ```bootstrapsh configure make ...``` or ```cmake```. The environment makes the difference. --- If your project is set up for it,

[jira] [Commented] (THRIFT-3000) .NET implementation has trouble with mixed IP modes

2015-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511618#comment-14511618 ] ASF GitHub Bot commented on THRIFT-3000: Github user Jens-G commented on the pull