[
https://issues.apache.org/jira/browse/THRIFT-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick White updated THRIFT-3183:
---
Attachment: THRIFT-3183.patch
TJSONProtocol#writeBinary Shouldn't Assume ByteBuffer.array() is
Nick White created THRIFT-3183:
--
Summary: TJSONProtocol#writeBinary Shouldn't Assume
ByteBuffer.array() is supported
Key: THRIFT-3183
URL: https://issues.apache.org/jira/browse/THRIFT-3183
Project:
Good question. In addition to what Jake wrote, in my opinion it depends mainly
on two factors.
First, how quickly are language updates adopted in the field? Some language
ecosystems make it easy to migrate, these communities typically do update
quickly so one can assume new versions are wide
GitHub user i opened a pull request:
https://github.com/apache/thrift/pull/517
Always set response on THttpClient
Due to an early return, not setting response leads to a file descriptor
leak. This fixes that by letting the client close its transport every time.
You can merge this