[GitHub] thrift pull request: Thrift 2905 & - Modern Objective-C & Swift Su...

2015-10-07 Thread kdubb
Github user kdubb commented on the pull request: https://github.com/apache/thrift/pull/539#issuecomment-146314451 @Jens-G The entirety of the Objective-C changes are "complete" as far as I am concerned. We have been using them successfully for quite a while. --- If your project is

Re: Major feature suggestion/observation

2015-10-07 Thread Ben Craig
+1 to what Jens said. I've dealt with a number of code generators, and I can't say I really like any of them. With that in mind though, I've found it easier to embed strings into code (the Thrift way) than to embed code into strings (typically, the template way). I do think a template based

AW: Major feature suggestion/observation

2015-10-07 Thread Jens Geyer
Just two short notes: Xtend is industrial strength but does not use templates either. What could the lack of existing or known template based tools imply? Von: David Bennett Gesendet: 07.10.2015 02:11 An: u...@thrift.apache.org Cc: dev@thrift.apache.org Betreff:

[jira] [Commented] (THRIFT-3365) IDL Union structs nil dereferencing in Go

2015-10-07 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946462#comment-14946462 ] Jens Geyer commented on THRIFT-3365: [~jseaidoun], any chance you could [provide a patch or

RE: Major feature suggestion/observation

2015-10-07 Thread David Bennett
[Sorry -- I only just subscribed so missed any earlier commonents on the dev list] Your experience parallels mine, except that I'm a compiler guy so I've leant more towards language-based solutions, and I've written a couple of template engines. Re simple stuff: agreed. Simple stuff is

[jira] [Comment Edited] (THRIFT-3049) As an iOS developer, I want a generator and library that produces Swift code

2015-10-07 Thread Kevin Wooten (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948055#comment-14948055 ] Kevin Wooten edited comment on THRIFT-3049 at 10/8/15 4:30 AM: --- My PR for

Re: Major feature suggestion/observation

2015-10-07 Thread BCG
Perhaps an approach that wouldn't require completely rearchitecting the compiler could be implement a mechanism that allows filtering the generated code as it is being written out. For example, the compiler could make a call to some sort of filtering callback that has the capability of

[jira] [Commented] (THRIFT-3049) As an iOS developer, I want a generator and library that produces Swift code

2015-10-07 Thread Kevin Wooten (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948055#comment-14948055 ] Kevin Wooten commented on THRIFT-3049: -- My PR for Modern Objective-C & Swift Support now features a

[jira] [Comment Edited] (THRIFT-3049) As an iOS developer, I want a generator and library that produces Swift code

2015-10-07 Thread Kevin Wooten (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14948055#comment-14948055 ] Kevin Wooten edited comment on THRIFT-3049 at 10/8/15 4:31 AM: --- My PR for

[GitHub] thrift pull request: Thrift 2905 & - Modern Objective-C & Swift Su...

2015-10-07 Thread kdubb
Github user kdubb commented on the pull request: https://github.com/apache/thrift/pull/539#issuecomment-146394971 @Jens-G The Swift implementation is now fairly well tested. I used Objectice-C, Python and C++ to ensure it's compatibility. Basically there's not much left to

Re: Major feature suggestion/observation

2015-10-07 Thread Jens Geyer
Hi *, Please, FUP @ dev list. Thank you. I agree that the existing code generation code has some potential, in many ways. I even agree that it could be a good idea to rethink some of the concepts. But the question I raised a few hours earlier (on the dev list) was precisely targeted at what

[jira] [Commented] (THRIFT-2994) Node.js TJSONProtocol cannot be used for object serialization.

2015-10-07 Thread Tim Sebastian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947455#comment-14947455 ] Tim Sebastian commented on THRIFT-2994: --- i rebased the patch based on the current master and in

[jira] [Comment Edited] (THRIFT-2994) Node.js TJSONProtocol cannot be used for object serialization.

2015-10-07 Thread Tim Sebastian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947455#comment-14947455 ] Tim Sebastian edited comment on THRIFT-2994 at 10/7/15 7:43 PM: i rebased

[GitHub] thrift pull request: Thrift 2905 & - Modern Objective-C & Swift Su...

2015-10-07 Thread Jens-G
Github user Jens-G commented on the pull request: https://github.com/apache/thrift/pull/539#issuecomment-146309057 Hi all, first thank you for the contribution, we appreciate it. I have a few questions. * Is everybody of you guys happy with it, or are there any

[jira] [Created] (THRIFT-3368) Setting fields in structs via prototype

2015-10-07 Thread David Sautter (JIRA)
David Sautter created THRIFT-3368: - Summary: Setting fields in structs via prototype Key: THRIFT-3368 URL: https://issues.apache.org/jira/browse/THRIFT-3368 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-3368) Setting fields in structs via prototype

2015-10-07 Thread David Sautter (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Sautter updated THRIFT-3368: -- Attachment:

[jira] [Updated] (THRIFT-3369) Implement SSL/TLS support on C with g_lib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gonzalo Aguilar updated THRIFT-3369: Attachment: feature-thrift-3369-tls-impl.patch.bz2 The current implementation, work in

[jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with g_lib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14946990#comment-14946990 ] Gonzalo Aguilar commented on THRIFT-3369: - I forgot to say that's required to do this on init:

[jira] [Created] (THRIFT-3369) Implement SSL/TLS support on C with g_lib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
Gonzalo Aguilar created THRIFT-3369: --- Summary: Implement SSL/TLS support on C with g_lib Key: THRIFT-3369 URL: https://issues.apache.org/jira/browse/THRIFT-3369 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-3369) Implement SSL/TLS support on C with c_glib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gonzalo Aguilar updated THRIFT-3369: Summary: Implement SSL/TLS support on C with c_glib (was: Implement SSL/TLS support on C

[jira] [Updated] (THRIFT-3369) Implement SSL/TLS support on C with c_glib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gonzalo Aguilar updated THRIFT-3369: Affects Version/s: 1.0 > Implement SSL/TLS support on C with c_glib >

[jira] [Updated] (THRIFT-3369) Implement SSL/TLS support on C with c_glib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gonzalo Aguilar updated THRIFT-3369: Attachment: (was: feature-thrift-3369-tls-impl.patch.bz2) > Implement SSL/TLS support

[jira] [Commented] (THRIFT-1016) using GSocket in c_glib library

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14947120#comment-14947120 ] Gonzalo Aguilar commented on THRIFT-1016: - I don't know what's the effort of this but's not

[jira] [Updated] (THRIFT-3369) Implement SSL/TLS support on C with c_glib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gonzalo Aguilar updated THRIFT-3369: Attachment: feature-thrift-3369-tls-impl.patch.bz2 Server part is still under work. Tests

[jira] [Updated] (THRIFT-3369) Implement SSL/TLS support on C with c_glib

2015-10-07 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gonzalo Aguilar updated THRIFT-3369: Fix Version/s: 1.0 > Implement SSL/TLS support on C with c_glib >