[jira] [Updated] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Description: When a struct/object contains list, the thrift C++ server always return null/undef. Here

[jira] [Issue Comment Deleted] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Comment: was deleted (was: I test my code again and again, and finally I found that the "optional"

[jira] [Updated] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Description: Any "optional" modifier relates to a list will cause to a null/undef return value. Here

[jira] [Updated] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Description: When a struct/object contains list, the thrift C++ server always return null/undef. Here

[jira] [Updated] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Description: Any "optional" modifiers related to a list will cause to a null/undef return value. Here

[jira] [Updated] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Description: Any "optional" modifier relates to a list will cause to a null/undef return value. Here

[jira] [Commented] (THRIFT-1385) make install doesn't install java library in the setted folder

2015-12-05 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043577#comment-15043577 ] Roger Meier commented on THRIFT-1385: - [~tlippy01] does the attached patch work as expected? > make

[GitHub] thrift pull request: THRIFT-2869: Run JSON schema validator from t...

2015-12-05 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/299#discussion_r46765156 --- Diff: lib/json/schema.json --- @@ -20,66 +21,78 @@ "map", "union", "struct", -"exception",

[jira] [Commented] (THRIFT-2869) JSON: run schema validation from tests

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043601#comment-15043601 ] ASF GitHub Bot commented on THRIFT-2869: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3432 Add the TByteBuffer transport for...

2015-12-05 Thread nsuke
Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/705#issuecomment-162261013 @thomaslee thanks for this, just added a couple of nits. It looks quite neat :) --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-3432) Add a TByteBuffer transport to the Java library

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043608#comment-15043608 ] ASF GitHub Bot commented on THRIFT-3432: Github user nsuke commented on the pull request:

[jira] [Commented] (THRIFT-3432) Add a TByteBuffer transport to the Java library

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043607#comment-15043607 ] ASF GitHub Bot commented on THRIFT-3432: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3432 Add the TByteBuffer transport for...

2015-12-05 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/705#discussion_r46765197 --- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java --- @@ -0,0 +1,88 @@ +package org.apache.thrift.transport; + +import

[GitHub] thrift pull request: THRIFT-3435 Separate package for fullcamel th...

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-3435) Put generated Java code for fullcamel tests in a separate package/namespace

2015-12-05 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3435. -- Resolution: Fixed Fix Version/s: 1.0 > Put generated Java code for fullcamel tests in a

[jira] [Commented] (THRIFT-3435) Put generated Java code for fullcamel tests in a separate package/namespace

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043616#comment-15043616 ] ASF GitHub Bot commented on THRIFT-3435: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3464) Fix several defects in c_glib code generator

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043617#comment-15043617 ] ASF GitHub Bot commented on THRIFT-3464: Github user asfgit closed the pull request at:

[GitHub] thrift pull request: THRIFT-3464 c_glib fixes

2015-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-3464) Fix several defects in c_glib code generator

2015-12-05 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3464. -- Resolution: Fixed Fix Version/s: 1.0 > Fix several defects in c_glib code generator >

[jira] [Commented] (THRIFT-1805) Thrift should not swallow ALL exceptions

2015-12-05 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043579#comment-15043579 ] Roger Meier commented on THRIFT-1805: - You are welcome to help improving Java within Thrift, patches

[jira] [Commented] (THRIFT-3432) Add a TByteBuffer transport to the Java library

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043603#comment-15043603 ] ASF GitHub Bot commented on THRIFT-3432: Github user nsuke commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3432 Add the TByteBuffer transport for...

2015-12-05 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/705#discussion_r46765176 --- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java --- @@ -0,0 +1,88 @@ +package org.apache.thrift.transport; + +import

[jira] [Comment Edited] (THRIFT-3473) C++ server cannot correctly return a struct/object contains list

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042770#comment-15042770 ] YU Chang edited comment on THRIFT-3473 at 12/5/15 9:50 AM: --- I test my code

[jira] [Comment Edited] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042770#comment-15042770 ] YU Chang edited comment on THRIFT-3473 at 12/5/15 9:59 AM: --- I test my code

[jira] [Commented] (THRIFT-3473) C++ server cannot correctly return a struct/object contains list

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042770#comment-15042770 ] YU Chang commented on THRIFT-3473: -- I test my code again and again, and finally I found that the

[jira] [Updated] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YU Chang updated THRIFT-3473: - Summary: When use "optional' before a list, C++ server cannot return it correctly (was: C++ server

[jira] [Comment Edited] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042770#comment-15042770 ] YU Chang edited comment on THRIFT-3473 at 12/5/15 10:07 AM: I test my code

[jira] [Comment Edited] (THRIFT-3473) C++ server cannot correctly return a struct/object contains list

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042770#comment-15042770 ] YU Chang edited comment on THRIFT-3473 at 12/5/15 9:40 AM: --- I test my code

[jira] [Comment Edited] (THRIFT-3473) When use "optional' before a list, C++ server cannot return it correctly

2015-12-05 Thread YU Chang (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042770#comment-15042770 ] YU Chang edited comment on THRIFT-3473 at 12/5/15 10:15 AM: I test my code

[jira] [Commented] (THRIFT-1385) make install doesn't install java library in the setted folder

2015-12-05 Thread Tom Lippincott (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043658#comment-15043658 ] Tom Lippincott commented on THRIFT-1385: Yes it looks like it does: looks like it's been around a

[GitHub] thrift pull request: THRIFT-3432 Add the TByteBuffer transport for...

2015-12-05 Thread thomaslee
Github user thomaslee commented on the pull request: https://github.com/apache/thrift/pull/705#issuecomment-162265175 Thanks for the review @nsuke, will land the changes soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (THRIFT-3432) Add a TByteBuffer transport to the Java library

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043665#comment-15043665 ] ASF GitHub Bot commented on THRIFT-3432: Github user thomaslee commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3432 Add the TByteBuffer transport for...

2015-12-05 Thread thomaslee
Github user thomaslee commented on a diff in the pull request: https://github.com/apache/thrift/pull/705#discussion_r46765943 --- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java --- @@ -0,0 +1,88 @@ +package org.apache.thrift.transport; + +import

[GitHub] thrift pull request: THRIFT-3432 Add the TByteBuffer transport for...

2015-12-05 Thread thomaslee
Github user thomaslee commented on a diff in the pull request: https://github.com/apache/thrift/pull/705#discussion_r46765941 --- Diff: lib/java/src/org/apache/thrift/transport/TByteBuffer.java --- @@ -0,0 +1,88 @@ +package org.apache.thrift.transport; + +import

[jira] [Commented] (THRIFT-3154) tutorial/py.tornado throw EOF exception

2015-12-05 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043641#comment-15043641 ] Aki Sukegawa commented on THRIFT-3154: -- The pull request contains at least two fixes that are

[jira] [Commented] (THRIFT-3435) Put generated Java code for fullcamel tests in a separate package/namespace

2015-12-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043645#comment-15043645 ] Hudson commented on THRIFT-3435: SUCCESS: Integrated in Thrift #1758 (See

[jira] [Commented] (THRIFT-3464) Fix several defects in c_glib code generator

2015-12-05 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043644#comment-15043644 ] Hudson commented on THRIFT-3464: SUCCESS: Integrated in Thrift #1758 (See

Re: API Stability Guarantees?

2015-12-05 Thread Nobuaki Sukegawa
Hi Keith, Speaking about the particular case, it would make sense to me to restore the method possibly with deprecation. For the general question, agreed upon guarantee is semantic versioning https://issues.apache.org/jira/browse/THRIFT-6. However, since semver has nothing to say about 0.X.X

[jira] [Resolved] (THRIFT-3154) tutorial/py.tornado throw EOF exception

2015-12-05 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3154. -- Resolution: Fixed Fix Version/s: 1.0 > tutorial/py.tornado throw EOF exception >

[jira] [Commented] (THRIFT-3432) Add a TByteBuffer transport to the Java library

2015-12-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043667#comment-15043667 ] ASF GitHub Bot commented on THRIFT-3432: Github user thomaslee commented on the pull request: