[jira] [Commented] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046455#comment-15046455 ] Gordashnikov Artur commented on THRIFT-3477: Jens Geyer, thank you very much, it solved the

[jira] [Created] (THRIFT-3477) Parser fails on enum that starts with E

Gordashnikov Artur created THRIFT-3477: -- Summary: Parser fails on enum that starts with E Key: THRIFT-3477 URL: https://issues.apache.org/jira/browse/THRIFT-3477 Project: Thrift Issue

[jira] [Updated] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordashnikov Artur updated THRIFT-3477: --- Description: Consider simple enum: enum Test { E10 } It will fail with message

[jira] [Updated] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordashnikov Artur updated THRIFT-3477: --- Summary: Parser fails on enum item that starts with 'E' letter and continues with

[jira] [Commented] (THRIFT-3328) A callback is not called when a server is down.

[ https://issues.apache.org/jira/browse/THRIFT-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044548#comment-15044548 ] ASF GitHub Bot commented on THRIFT-3328: GitHub user HIRANO-Satoshi opened a pull request:

[GitHub] thrift pull request: THRIFT-3328 A callback is not called when a s...

GitHub user HIRANO-Satoshi opened a pull request: https://github.com/apache/thrift/pull/734 THRIFT-3328 A callback is not called when a server is down. https://issues.apache.org/jira/browse/THRIFT-3328 You can merge this pull request into a Git repository by running: $ git

[jira] [Created] (THRIFT-3476) Missing include in ./src/thrift/protocol/TJSONProtocol.cpp

Martin Werner created THRIFT-3476: - Summary: Missing include in ./src/thrift/protocol/TJSONProtocol.cpp Key: THRIFT-3476 URL: https://issues.apache.org/jira/browse/THRIFT-3476 Project: Thrift

[jira] [Commented] (THRIFT-2457) fbthrift float

[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044738#comment-15044738 ] Jens Geyer commented on THRIFT-2457: @[~andrewcox79] & [~roger.meier], re other languages: IMHO we

[jira] [Comment Edited] (THRIFT-2457) fbthrift float

[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044738#comment-15044738 ] Jens Geyer edited comment on THRIFT-2457 at 12/7/15 10:47 AM: --

[jira] [Commented] (THRIFT-3472) Missing semi-colon in IDL leads to non-deterministic builds

[ https://issues.apache.org/jira/browse/THRIFT-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045527#comment-15045527 ] Jason Heimann commented on THRIFT-3472: --- Also, why close the bug before you understand the intent

[jira] [Updated] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3477: --- Attachment: THRIFT-3477-Parser-fails-on-enum-item-that-starts-wi.patch > Parser fails on enum item

[GitHub] thrift pull request: Support for float type (part 1: cpp)

Github user andrewcox commented on the pull request: https://github.com/apache/thrift/pull/731#issuecomment-162639103 Updated the commit name to have the correct prefix (the current commit is otherwise unchanged) Yes, I was just checking whether this looks like what you want,

[GitHub] thrift pull request: Support for float type (part 1: cpp)

Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/731#issuecomment-162651073 Yes, CI will re-run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (THRIFT-3476) Missing include in ./src/thrift/protocol/TJSONProtocol.cpp

[ https://issues.apache.org/jira/browse/THRIFT-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045781#comment-15045781 ] Roger Meier commented on THRIFT-3476: - Thanks Martin for reporting this. It is always worth to

[jira] [Comment Edited] (THRIFT-3476) Missing include in ./src/thrift/protocol/TJSONProtocol.cpp

[ https://issues.apache.org/jira/browse/THRIFT-3476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045781#comment-15045781 ] Roger Meier edited comment on THRIFT-3476 at 12/7/15 9:33 PM: -- Thanks Martin

[jira] [Commented] (THRIFT-3472) Missing semi-colon in IDL leads to non-deterministic builds

[ https://issues.apache.org/jira/browse/THRIFT-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045835#comment-15045835 ] Jens Geyer commented on THRIFT-3472: {quote} Let's take a step back from this specific example. Why

[jira] [Updated] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3477: --- Description: Consider simple enum: {code} enum Test { E10 } {code} It will fail with message

[jira] [Commented] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045863#comment-15045863 ] Jens Geyer commented on THRIFT-3477: That's a cool one. > Parser fails on enum item that starts

Re: API Stability Guarantees?

On Sun, Dec 6, 2015 at 7:27 AM, Roger Meier wrote: > > Quoting Nobuaki Sukegawa : > > Hi Keith, >> >> Speaking about the particular case, it would make sense to me to restore >> the method possibly with deprecation. >> > yes, if this is beneficial for

[jira] [Commented] (THRIFT-3472) Missing semi-colon in IDL leads to non-deterministic builds

[ https://issues.apache.org/jira/browse/THRIFT-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045521#comment-15045521 ] Jason Heimann commented on THRIFT-3472: --- Let's take a step back from this specific example. Why is

[jira] [Updated] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3477: --- Attachment: (was: THRIFT-3477-Parser-fails-on-enum-item-that-starts-wi.patch) > Parser fails on

[jira] [Commented] (THRIFT-3472) Missing semi-colon in IDL leads to non-deterministic builds

[ https://issues.apache.org/jira/browse/THRIFT-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15045525#comment-15045525 ] Jason Heimann commented on THRIFT-3472: --- Here is the include file (I can't seem to attach a file

Re: API Stability Guarantees?

On Sat, Dec 5, 2015 at 9:05 PM, Nobuaki Sukegawa wrote: > Hi Keith, > > Speaking about the particular case, it would make sense to me to restore > the method possibly with deprecation. > yeah that makes sense. > > For the general question, agreed upon guarantee is semantic

[jira] [Updated] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3477: --- Attachment: THRIFT-3477-Parser-fails-on-enum-item-that-starts-wi.patch > Parser fails on enum item

[jira] [Commented] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046066#comment-15046066 ] Jens Geyer commented on THRIFT-3477: {code:title=test.thrift} enum test { _e10

[jira] [Comment Edited] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046066#comment-15046066 ] Jens Geyer edited comment on THRIFT-3477 at 12/8/15 12:48 AM: --

[jira] [Commented] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046057#comment-15046057 ] Jens Geyer commented on THRIFT-3477: [Proposed

[jira] [Assigned] (THRIFT-3477) Parser fails on enum item that starts with 'E' letter and continues with number

[ https://issues.apache.org/jira/browse/THRIFT-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-3477: -- Assignee: Jens Geyer > Parser fails on enum item that starts with 'E' letter and continues