Benjamin Gould created THRIFT-3521:
--
Summary: TSimpleJSONProtocolTest is not deterministic (fails when
run on JDK 8)
Key: THRIFT-3521
URL: https://issues.apache.org/jira/browse/THRIFT-3521
Project:
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083412#comment-15083412
]
ASF GitHub Bot commented on THRIFT-3521:
GitHub user bgould opened a pull request:
GitHub user bgould opened a pull request:
https://github.com/apache/thrift/pull/772
THRIFT-3521 : TSimpleJSONProtocolTest is not deterministic (fails when run
on JDK 8)
This PR removes fields that cause TSimpleJSONProtocolTest to fail when run
using different version of the Java
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083620#comment-15083620
]
ASF GitHub Bot commented on THRIFT-3521:
Github user nsuke commented on the pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa resolved THRIFT-3519.
--
Resolution: Fixed
Fix Version/s: 1.0
> fastbinary does not work with -gen
Amos Chen created THRIFT-3522:
-
Summary: In multiplexer mode, when data gets big, error occurs in
accepting data
Key: THRIFT-3522
URL: https://issues.apache.org/jira/browse/THRIFT-3522
Project: Thrift
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/772#issuecomment-169105689
I was mainly concerned about completely losing map/set tests.
Of course preserving all tests for those element types is great, but I
think it's fine to unset most of
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/772#issuecomment-169092979
@bgould, thanks for looking into this.
Would it be tedious and/or complicate the code if we match against regex
instead of removing them ?
---
If your project is set
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083540#comment-15083540
]
ASF GitHub Bot commented on THRIFT-3521:
Github user nsuke commented on the pull request:
Github user bgould commented on the pull request:
https://github.com/apache/thrift/pull/772#issuecomment-169096832
I thought about that too but didn't have time to do it this morning and
just wanted to get a working build. I think that perhaps better than a regex
might be to
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083559#comment-15083559
]
ASF GitHub Bot commented on THRIFT-3521:
Github user bgould commented on the pull request:
[
https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083628#comment-15083628
]
ASF GitHub Bot commented on THRIFT-2994:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa resolved THRIFT-2994.
--
Resolution: Fixed
Assignee: Jan Brauer (was: Randy Abernethy)
Fix Version/s:
GitHub user mice530 opened a pull request:
https://github.com/apache/thrift/pull/773
THRIFT-:In multiplexer mode, when data gets big, error occurs in
accepting data
THRIFT-:In multiplexer mode, when data gets big, delete hash of seqId
may lead to wrong client.
You can
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/769
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083629#comment-15083629
]
ASF GitHub Bot commented on THRIFT-3519:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083627#comment-15083627
]
ASF GitHub Bot commented on THRIFT-3437:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/379
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa resolved THRIFT-3437.
--
Resolution: Fixed
Fix Version/s: 1.0
Committed.
The patch presumably resolves 2 other
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084585#comment-15084585
]
ASF GitHub Bot commented on THRIFT-3521:
Github user nsuke commented on the pull request:
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/772#issuecomment-169204403
You're right, you were already keeping those which still work for JDK8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/THRIFT-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084953#comment-15084953
]
Nikita Dolgov commented on THRIFT-2427:
---
In case it might inspire someone to do a code review, I'd
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aki Sukegawa resolved THRIFT-3521.
--
Resolution: Fixed
committed, thanks
> TSimpleJSONProtocolTest is not deterministic (fails
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084592#comment-15084592
]
ASF GitHub Bot commented on THRIFT-3521:
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Gould updated THRIFT-3523:
---
Description:
I've put together an XML model for Thrift IDL that is very similar in concept
Benjamin Gould created THRIFT-3523:
--
Summary: XML Generator
Key: THRIFT-3523
URL: https://issues.apache.org/jira/browse/THRIFT-3523
Project: Thrift
Issue Type: New Feature
GitHub user bgould opened a pull request:
https://github.com/apache/thrift/pull/774
THRIFT-3523 : XML Generator
I've put together an XML model for Thrift IDL that is very similar in
concept and structure to the model created by the JSON generator of the Thrift
compiler. The code
[
https://issues.apache.org/jira/browse/THRIFT-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084574#comment-15084574
]
ASF GitHub Bot commented on THRIFT-3523:
GitHub user bgould opened a pull request:
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/773#issuecomment-169119235
Could you please follow our small set of [contribution
guidelines](http://thrift.apache.org/docs/HowToContribute) and file a valid
JIRA ticket for it, ideally including
[
https://issues.apache.org/jira/browse/THRIFT-3466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083997#comment-15083997
]
Tom Deering commented on THRIFT-3466:
-
This appears to affect lists as well as sets.
> Set
[
https://issues.apache.org/jira/browse/THRIFT-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083921#comment-15083921
]
ASF GitHub Bot commented on THRIFT-3514:
Github user dsp commented on the pull request:
Github user dsp commented on the pull request:
https://github.com/apache/thrift/pull/765#issuecomment-169147175
The contbuild error seem to be in java-csharp and perl-py3 which are
unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bgould commented on the pull request:
https://github.com/apache/thrift/pull/772#issuecomment-169139570
I see... in that I think that the tests should be ok as they are because
there still exist maps and sets in the `testSanePartsOfCompactProtoTestStruct`
test method.
[
https://issues.apache.org/jira/browse/THRIFT-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083838#comment-15083838
]
ASF GitHub Bot commented on THRIFT-3521:
Github user bgould commented on the pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082972#comment-15082972
]
ASF GitHub Bot commented on THRIFT-3514:
Github user ovr commented on the pull request:
Github user ovr commented on the pull request:
https://github.com/apache/thrift/pull/765#issuecomment-168986427
Awesome!! :cake: :beers:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084531#comment-15084531
]
ASF GitHub Bot commented on THRIFT-3474:
Github user jfarrell commented on the pull request:
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/733#issuecomment-169193943
@nsuke correct, gofmt is called in the compiler
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/THRIFT-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-2426:
-
Fix Version/s: (was: 0.9.2)
1.0
> clarify IP rights and contributions
[
https://issues.apache.org/jira/browse/THRIFT-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-3449:
-
Fix Version/s: (was: 0.9.3)
0.9.4
> TBaseAsyncProcessor
[
https://issues.apache.org/jira/browse/THRIFT-3518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-3518.
Resolution: Fixed
committed, thanks for the patch
> TConcurrentClientSyncInfo files were missing
[
https://issues.apache.org/jira/browse/THRIFT-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell updated THRIFT-3517:
-
Component/s: Tutorial
> Default value of enum is starting at zero in Java
>
[
https://issues.apache.org/jira/browse/THRIFT-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-1007.
Resolution: Won't Fix
Assignee: Jake Farrell
closing as this has been around since 0.5 and
[
https://issues.apache.org/jira/browse/THRIFT-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jake Farrell closed THRIFT-449.
---
Resolution: Won't Fix
Assignee: Jake Farrell
Fix Version/s: 0.9.4
closing as this has
45 matches
Mail list logo
