[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229593#comment-15229593 ] ASF GitHub Bot commented on THRIFT-3768: Github user tpcwang commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r58814042 --- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp --- @@ -92,29 +97,42 @@ TThreadedServer::~TThreadedServer() { void TThreadedServer::serve() {

[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229335#comment-15229335 ] Hudson commented on THRIFT-3038: FAILURE: Integrated in Thrift-precommit #392 (See

[jira] [Commented] (THRIFT-3781) Thrift::Client can become permanently corrupt when Thrift::ProtocolException is raised

[ https://issues.apache.org/jira/browse/THRIFT-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229172#comment-15229172 ] Justin Mills commented on THRIFT-3781: -- I believe I was wrong in my original claim that

[jira] [Commented] (THRIFT-3781) Thrift::Client can become permanently corrupt when Thrift::ProtocolException is raised

[ https://issues.apache.org/jira/browse/THRIFT-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229109#comment-15229109 ] Jens Geyer commented on THRIFT-3781: Re exceptions: The usual pattern in Thrift is to have all

[jira] [Updated] (THRIFT-3781) Thrift::Client can become permanently corrupt when Thrift::ProtocolException is raised

[ https://issues.apache.org/jira/browse/THRIFT-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3781: --- Summary: Thrift::Client can become permanently corrupt when Thrift::ProtocolException is raised

[jira] [Resolved] (THRIFT-3467) Go Maps for Thrift Sets Should Have Values of Type struct{}

[ https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3467. Resolution: Fixed Fix Version/s: 0.11.0 Ok, thanks, committed. > Go Maps for Thrift Sets

[jira] [Commented] (THRIFT-3467) Go Maps for Thrift Sets Should Have Values of Type struct{}

[ https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229084#comment-15229084 ] ASF GitHub Bot commented on THRIFT-3467: Github user asfgit closed the pull request at:

[GitHub] thrift pull request: THRIFT-3467 Go Maps for Thrift Sets Should Ha...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/976 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-3746) JSON protocol left in incorrect state on read errors

[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3746. Resolution: Fixed Assignee: Tyler Treat Fix Version/s: 0.11.0 Committed. Thanks

[jira] [Commented] (THRIFT-3746) JSON protocol left in incorrect state on read errors

[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229059#comment-15229059 ] ASF GitHub Bot commented on THRIFT-3746: Github user asfgit closed the pull request at:

[GitHub] thrift pull request: THRIFT-3746 JSON protocol left in incorrect s...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3779 Qt Client Android and Windows QTc...

Github user Gjergj commented on the pull request: https://github.com/apache/thrift/pull/979#issuecomment-206486758 I'll have a look at TQIODeviceTransport and see how it works as a client. As per config.h the idea is the same as in Windows port I guess. My cmake exprience is

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228737#comment-15228737 ] ASF GitHub Bot commented on THRIFT-3779: Github user Gjergj commented on the pull request:

[jira] [Commented] (THRIFT-3746) JSON protocol left in incorrect state on read errors

[ https://issues.apache.org/jira/browse/THRIFT-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228720#comment-15228720 ] ASF GitHub Bot commented on THRIFT-3746: Github user nsuke commented on the pull request:

[GitHub] thrift pull request: THRIFT-3746 JSON protocol left in incorrect s...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/955#issuecomment-206483193 LGTM @Jens-G any concern for this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228696#comment-15228696 ] ASF GitHub Bot commented on THRIFT-3779: Github user nsuke commented on the pull request:

[GitHub] thrift pull request: THRIFT-3779 Qt Client Android and Windows QTc...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/979#issuecomment-206477110 Why not enhance lib/cpp/src/thrift/qt/TQIODeviceTransport.cpp instead ? As to the qmake file, I don't think we want to introduce yet another build system. As

Build failed in Jenkins: Thrift-precommit #388

See -- GitHub pull request #979 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu yahoo-not-h2) in workspace

Build failed in Jenkins: Thrift-precommit #390

See Changes: [sam901] Go Maps for Thrift Sets Should Have Values of Type struct{} [sam901] Fix tests for the new Set representation [sam901] Use {} to initialize empty structs in initializers

Build failed in Jenkins: Thrift-precommit #387

See Changes: [v.markovtsev] Add binary protocol support for asyncio [v.markovtsev] Add support for Compact proto and fix bugs [v.markovtsev] Add py3.asyncio test client [v.markovtsev] Use python3 version of flake8 [v.markovtsev]

Build failed in Jenkins: Thrift-precommit #391

See -- GitHub pull request #980 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on H10 (docker Ubuntu ubuntu yahoo-not-h2) in workspace

Build failed in Jenkins: Thrift-precommit #389

See -- GitHub pull request #972 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on ubuntu-6 (docker Ubuntu ubuntu yahoo-not-h2) in workspace

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228616#comment-15228616 ] Hudson commented on THRIFT-3779: FAILURE: Integrated in Thrift-precommit #386 (See

Build failed in Jenkins: Thrift-precommit #386

See Changes: [gjergjiramku] THRIFT-3779 Qt Client Android and Windows QTcpSocket [gjergjiramku] Forgot to add the port class TQtcpSocket [gjergjiramku] THRIFT-3779 more informatin to link against the library and

Travis CI - Build Failures

The list of open pull requests have all failed over the last few days. The last successful build was 5 days ago. Things look horribly unreliable. This needs to be fixed up. What's the current status of this? [Description: Description: simplivity-lg-xsmall] James E. King, III Architect 8

[GitHub] thrift pull request: THRIFT-3038: fix up some volatiles in cpp

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/981 THRIFT-3038: fix up some volatiles in cpp I addressed the concerns in TFileTransport (forceFlush_) and in TThreadPoolServer, so items #2, #4, #5 from the original issue description. You can merge

[jira] [Commented] (THRIFT-3038) Use of volatile in cpp library

[ https://issues.apache.org/jira/browse/THRIFT-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228442#comment-15228442 ] James E. King, III commented on THRIFT-3038: I believe you meant, use std::atomic when

[jira] [Commented] (THRIFT-3467) Go Maps for Thrift Sets Should Have Values of Type struct{}

[ https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228371#comment-15228371 ] artem antonenko commented on THRIFT-3467: - "FYI, in an initializer, one can use {} as shorthand

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228370#comment-15228370 ] James E. King, III commented on THRIFT-3768: I decided to wrap the client object and put it

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228369#comment-15228369 ] ASF GitHub Bot commented on THRIFT-3768: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/980 THRIFT-3768: ensure TThreadedServer guarantees the lifetime of the client TThreadedServer now guarantees the lifetime of the TConnectedClient. You can merge this pull request into a Git repository

[jira] [Created] (THRIFT-3781) [ruby] Thrift::Client can become permanently corrupt when Thrift::ProtocolException is raised

Justin Mills created THRIFT-3781: Summary: [ruby] Thrift::Client can become permanently corrupt when Thrift::ProtocolException is raised Key: THRIFT-3781 URL: https://issues.apache.org/jira/browse/THRIFT-3781

[jira] [Comment Edited] (THRIFT-3467) Go Maps for Thrift Sets Should Have Values of Type struct{}

[ https://issues.apache.org/jira/browse/THRIFT-3467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228245#comment-15228245 ] Tom Deering edited comment on THRIFT-3467 at 4/6/16 1:35 PM: - [~jensg], I

[GitHub] thrift pull request: THRIFT-3768 fix TThreadedServer refactoring i...

Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/977 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228203#comment-15228203 ] ASF GitHub Bot commented on THRIFT-3768: Github user jeking3 commented on the pull request:

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228201#comment-15228201 ] James E. King, III commented on THRIFT-3768: I have a much, much simpler fix for this that I

[GitHub] thrift pull request: THRIFT-3768 fix TThreadedServer refactoring i...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/977#issuecomment-206358845 Declining this pull request - I have a far simpler one to submit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Updated] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connect

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3768: --- Description: Here's a sequence that shows the race: Thread-1 (Users of

[jira] [Updated] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3768: --- Summary: TThreadedServer may crash if it is destroyed immediately after it returns

[jira] [Updated] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connect

[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3768: --- Summary: TThreadedServer may crash if it is destroyed immediately after it returns

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228104#comment-15228104 ] ASF GitHub Bot commented on THRIFT-3779: Github user Gjergj commented on a diff in the pull

[GitHub] thrift pull request: THRIFT-3779 Qt Client Android and Windows QTc...

Github user Gjergj commented on a diff in the pull request: https://github.com/apache/thrift/pull/979#discussion_r58687272 --- Diff: lib/cpp/libthriftQt.pro --- @@ -0,0 +1,161 @@ +QT += core network + +CONFIG += c++11 + +greaterThan(QT_MAJOR_VERSION, 4):

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228044#comment-15228044 ] ASF GitHub Bot commented on THRIFT-3779: Github user bufferoverflow commented on a diff in the

[GitHub] thrift pull request: THRIFT-3779 Qt Client Android and Windows QTc...

Github user bufferoverflow commented on a diff in the pull request: https://github.com/apache/thrift/pull/979#discussion_r58678766 --- Diff: lib/cpp/libthriftQt.pro --- @@ -0,0 +1,161 @@ +QT += core network + +CONFIG += c++11 +

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227919#comment-15227919 ] Hudson commented on THRIFT-3779: FAILURE: Integrated in Thrift-precommit #385 (See

Build failed in Jenkins: Thrift-precommit #385

See Changes: [gjergjiramku] THRIFT-3779 Qt Client Android and Windows QTcpSocket [gjergjiramku] Forgot to add the port class TQtcpSocket -- [...truncated 3858 lines...] [artifact:dependencies]

[jira] [Commented] (THRIFT-1972) Add support for async processors

[ https://issues.apache.org/jira/browse/THRIFT-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227891#comment-15227891 ] Dongchao Ding commented on THRIFT-1972: --- Are there some tutorials or wiki about this feature ？

[jira] [Issue Comment Deleted] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gjergji Ramku updated THRIFT-3779: -- Comment: was deleted (was: I just created a pull request on Github THRIFT-3779 Qt Client

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227878#comment-15227878 ] Gjergji Ramku commented on THRIFT-3779: --- I just created a pull request on Github THRIFT-3779 Qt

[jira] [Commented] (THRIFT-3779) Qt Client Android and Windows QTcpSocket

[ https://issues.apache.org/jira/browse/THRIFT-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227876#comment-15227876 ] ASF GitHub Bot commented on THRIFT-3779: GitHub user Gjergj opened a pull request:

[GitHub] thrift pull request: THRIFT-3779 Qt Client Android and Windows QTc...

GitHub user Gjergj opened a pull request: https://github.com/apache/thrift/pull/979 THRIFT-3779 Qt Client Android and Windows QTcpSocket libthriftQt.pro creates .dll and .lib for Windows but also .so and .a libraries for Android. To generate .lib or .a library uncomment CONFIG