[
https://issues.apache.org/jira/browse/THRIFT-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387149#comment-15387149
]
James E. King, III commented on THRIFT-3885:
Does the bug end up causing us to disable some
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1022
@jeking3 rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
[
https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387142#comment-15387142
]
ASF GitHub Bot commented on THRIFT-3845:
Github user RobberPhex commented on the issue:
Ready to merge and code reviewed:
THRIFT-3855: (go) fix the blocked bug when call Stop() twice or more #1028
https://issues.apache.org/jira/browse/THRIFT-3855
https://github.com/apache/thrift/pull/1028
James E. King, III
Architect
8 Technology Drive, 2nd Floor
Westborough, MA 01581-1756
Ph:
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1028#discussion_r71641738
--- Diff: lib/go/thrift/simple_server.go ---
@@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error {
}
func (p *TSimpleServer) Stop()
Chen Zhiming created THRIFT-3885:
Summary: PHP: Error when readI64 in TCompactProtocol
Key: THRIFT-3885
URL: https://issues.apache.org/jira/browse/THRIFT-3885
Project: Thrift
Issue Type: Bug
Github user huaiyun commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1028#discussion_r71634947
--- Diff: lib/go/thrift/simple_server.go ---
@@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error {
}
func (p *TSimpleServer) Stop()
[
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386559#comment-15386559
]
James E. King, III commented on THRIFT-2156:
The code as-is is correct, even if a bit odd,
[
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
]
Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:13 PM:
-
{code}
char
[
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
]
Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:13 PM:
-
{code}
char
[
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
]
Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:11 PM:
-
{code}
char
[
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
]
Jens Geyer edited comment on THRIFT-2156 at 7/20/16 8:10 PM:
-
{code}
char
[
https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386530#comment-15386530
]
Jens Geyer commented on THRIFT-2156:
{code}
char port[sizeof("65535")];
std::memset(, 0,
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386261#comment-15386261
]
James E. King, III commented on THRIFT-3855:
Hi, sorry, I used this thrift ticket number in
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1052
I'm also wondering if this was causing any "make cross" errors that have
been ignored and whether we can re-enable some of those tests.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386259#comment-15386259
]
ASF GitHub Bot commented on THRIFT-3855:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1052
Please create an Apache Jira ticket in the THRIFT project to cover the
defect, and put a link to the pull request in there. In the future if you open
a ticket first and put the name of the Jira
The following pull requests passed CI builds and have been code reviewed:
THRIFT-2156: (C++) fix errno handling in server socket #1033
https://issues.apache.org/jira/browse/THRIFT-2156
https://github.com/apache/thrift/pull/1033
THRIFT-3038: (C++) fix up some volatiles in cpp #981
GitHub user czm1989 opened a pull request:
https://github.com/apache/thrift/pull/1052
fix bug of TCompactProtocol of php
fix bug when readI64 in TCompactProtocol of php.
You can merge this pull request into a Git repository by running:
$ git pull
Github user zeayes closed the pull request at:
https://github.com/apache/thrift/pull/1016
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385821#comment-15385821
]
James E. King, III commented on THRIFT-3088:
The pull request for this issue is still open -
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385816#comment-15385816
]
James E. King, III commented on THRIFT-3090:
The pull request is still open - could someone
[
https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385812#comment-15385812
]
James E. King, III commented on THRIFT-3830:
[~jensg] or [~jfarrell] the pull request for
[
https://issues.apache.org/jira/browse/THRIFT-3880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3880:
---
Assignee: Aki Sukegawa
> Erlang Compact protocol - boolean values inverted
>
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1011
@caty please open an Apache Thrift Jira ticket for this issue and rebase
the pull request against master so we get a clean CI build.
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/THRIFT-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385801#comment-15385801
]
ASF GitHub Bot commented on THRIFT-3830:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1012
This fix was declined per the thrift discussion due to security concerns.
Please decline this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1014
Yes, continue to rebase against master and force push until it passes; if
there are no changes to pick up add an extra blank line to the end of one of
the files, commit, rebase/fixup and force
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1015
This needs an Apache Jira ticket in the Thrift project, and needs to be
rebased against master so that it gets a clean CI build.
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385790#comment-15385790
]
ASF GitHub Bot commented on THRIFT-3845:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1016
This needs to be rebased against master to get a good CI build, and needs a
Thrift project Jira ticket.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1022
@RobberPhex could you rebase this against master so we can get a build that
passes all tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/THRIFT-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385785#comment-15385785
]
ASF GitHub Bot commented on THRIFT-3844:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1021
@RobberPhex could you rebase this against master and re-submit to get a
build that passes CI tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1028#discussion_r71516249
--- Diff: lib/go/thrift/simple_server.go ---
@@ -149,8 +151,10 @@ func (p *TSimpleServer) Serve() error {
}
func (p *TSimpleServer) Stop()
[
https://issues.apache.org/jira/browse/THRIFT-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385778#comment-15385778
]
ASF GitHub Bot commented on THRIFT-3876:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1045
Was this set of changes tested with "make cross" as part of the build?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/THRIFT-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3232:
---
Summary: Cannot deserialize json messages created with fieldNamesAsString
(was: Cannot deserialize
[
https://issues.apache.org/jira/browse/THRIFT-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-3232.
--
Resolution: Fixed
> Cannot deserialize json messages created with fieldNamesAsString
>
[
https://issues.apache.org/jira/browse/THRIFT-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-3232:
> Cannot deserialize json messages created with
> --
>
>
40 matches
Mail list logo
