Re: interesting Bond features

2016-07-24 Thread Jens Geyer
https://microsoft.github.io/bond/manual/compiler.html#generic-struct Generic structs are parameterized with one or more type parameters which can be used within the struct definition in any place where a concrete type could be used (e.g. base struct, field type, container element type,

interesting Bond features

2016-07-24 Thread Jens Geyer
https://microsoft.github.io/bond/why_bond.html In terms of mapping to target languages, Bond again is much more similar to Thrift than Protocol Buffers. Like Thrift, Bond generates native types to represent schemas in the target language and uses native collections. Bond however doesn’t

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391110#comment-15391110 ] ASF GitHub Bot commented on THRIFT-2156: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391109#comment-15391109 ] ASF GitHub Bot commented on THRIFT-2156: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-24 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-2156. Resolution: Fixed Fix Version/s: 0.10.0 Committed, thank you both. >

[GitHub] thrift pull request #1033: THRIFT-2156: fix errno handling in server socket

2016-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1033 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1055: THRIFT-2156

2016-07-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391083#comment-15391083 ] ASF GitHub Bot commented on THRIFT-2156: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1055: THRIFT-2156

2016-07-24 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1055 Agree :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391078#comment-15391078 ] ASF GitHub Bot commented on THRIFT-2156: Github user tpcwang commented on the issue:

[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

2016-07-24 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1039 @dtmuller thanks, the new changes look good. As you uncovered another defect on includes, I've devised simple integration test using `diff` and resolved a few issues too. I've pushed some

[jira] [Commented] (THRIFT-2835) Add possibility to distribute generators separately from thrift core, and load them dynamically

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391037#comment-15391037 ] ASF GitHub Bot commented on THRIFT-2835: Github user nsuke commented on the issue:

[GitHub] thrift issue #368: THRIFT-2835 Add possibility to distribute generators sepa...

2016-07-24 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/368 TODO: * Remove `sleep 0.2` in cpp_plugin_test.sh without breaking it * Build with static boost unittest (need to do the same as some tests in lib/cpp/test) --- If your project is set up for

[GitHub] thrift issue #1055: THRIFT-2156

2016-07-24 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1055 @jeking + @tpcwang please feel free to comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (THRIFT-2156) TServerSocket::listen() is throwing exceptions with misleading information

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391019#comment-15391019 ] ASF GitHub Bot commented on THRIFT-2156: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1055: THRIFT-2156

2016-07-24 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1055 THRIFT-2156 code from pull request #1033 plus some refactoring added You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-2156

[GitHub] thrift issue #1052: THRIFT-3885 PHP: Error when readI64 in TCompactProtocol

2016-07-24 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1052 Also I noticed that `if (true)` part below inside the existing function seems completely redundant. `else` code even uses different set of variables. We can clean it up without losing any

[jira] [Commented] (THRIFT-3885) PHP: Error when readI64 in TCompactProtocol

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390966#comment-15390966 ] ASF GitHub Bot commented on THRIFT-3885: Github user nsuke commented on the issue:

[jira] [Commented] (THRIFT-3885) PHP: Error when readI64 in TCompactProtocol

2016-07-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390962#comment-15390962 ] ASF GitHub Bot commented on THRIFT-3885: Github user nsuke commented on the issue:

[GitHub] thrift issue #1052: THRIFT-3885 PHP: Error when readI64 in TCompactProtocol

2016-07-24 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1052 I'm inclined to make it stupid simple... ``` php // Shift hi and lo together. if ($shift < 28) { $lo |= (($byte & 0x7f) << $shift); } elseif ($shift == 28) { $lo |= (($byte