Github user CompileMaster commented on the issue:
https://github.com/apache/thrift/pull/1096
@Jens-G windows+msvc has no "snprintf" funtion, but has "_snprintf"
funtion. so should use "_snprintf" function replace the "snprintf" function.
---
If your project is set up for it, you
Github user CompileMaster commented on the issue:
https://github.com/apache/thrift/pull/1096
Compiling under VS2013
error C3861: âsnprintfâ: Can't find the identifier , line 282, 527,
528 in TServerSocket.cpp
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525072#comment-15525072
]
Paul Finkelshteyn commented on THRIFT-3855:
---
Thank you! Now we're waiting for 0.10 version!
>
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3855:
---
Assignee: Paul Finkelshteyn (was: James E. King, III)
> In the go simple server, if Stop() is
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524043#comment-15524043
]
ASF GitHub Bot commented on THRIFT-3855:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3855.
Resolution: Fixed
Committed
> In the go simple server, if Stop() is called multiple times it
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1094
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3507.
Resolution: Duplicate
Assignee: Martin Wilck
Fix Version/s: 0.10.0
Closed due to
[
https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3798:
---
Priority: Major (was: Critical)
> THttpClient does not use proxy from http_proxy, https_proxy
[
https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3798:
---
Summary: THttpClient does not use proxy from http_proxy, https_proxy
environment variables (was:
[
https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3798.
Resolution: Fixed
Assignee: Martin Wilck
Fix Version/s: 0.10.0
Committed.
> CLONE
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1096
Hi @CompileMaster, a bit more information about the problem would be nice.
Aside from that, we have a nice [contribution
guide](http://thrift.apache.org/docs/HowToContribute) that we would like you
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523824#comment-15523824
]
James E. King, III edited comment on THRIFT-1310 at 9/26/16 6:33 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523824#comment-15523824
]
James E. King, III edited comment on THRIFT-1310 at 9/26/16 6:29 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-1310:
---
Priority: Critical (was: Major)
> Generate PHP client code not check sequence ID in
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-1310:
---
Labels: security-issue (was: )
> Generate PHP client code not check sequence ID in
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523824#comment-15523824
]
James E. King, III commented on THRIFT-1310:
It sounds like the issue is in the server side.
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-1310:
---
Component/s: (was: PHP - Compiler)
PHP - Library
> Generate PHP
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523411#comment-15523411
]
Buğra Gedik commented on THRIFT-3932:
-
Btw, the change I made to the initialization of
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523383#comment-15523383
]
Buğra Gedik commented on THRIFT-3932:
-
Please go ahead.
> C++ ThreadManager has a rare termination
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523358#comment-15523358
]
James E. King, III commented on THRIFT-3932:
I am planning on reviewing this, apply it
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: thrift-patch
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: (was: thrift-patch)
> C++ ThreadManager has a rare termination race
>
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80496721
--- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocol.php ---
@@ -246,6 +257,10 @@ public function readMessageBegin(&$name, &$type,
&$seqid)
}
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: thrift-patch
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: (was: thrift-patch)
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: thrift-patch
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: patch.rtf
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: (was: patch.rtf)
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: patch.rtf
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Description:
{{ThreadManger::join}} calls {{stopImpl(true)}}, which in turn calls
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: (was: patch.rtf)
> C++ ThreadManager has a rare termination race
>
GitHub user CompileMaster opened a pull request:
https://github.com/apache/thrift/pull/1096
Update TServerSocket.cpp
fix snprintf error in vs2013
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/CompileMaster/thrift master
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Buğra Gedik updated THRIFT-3932:
Attachment: (was: thrift-patch)
> C++ ThreadManager has a rare termination race
>
Github user sstach commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80483149
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -255,6 +255,16 @@ public function close()
}
/**
+ * Close the socket and
[
https://issues.apache.org/jira/browse/THRIFT-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523170#comment-15523170
]
ASF GitHub Bot commented on THRIFT-1310:
Github user sstach commented on a diff in the pull
Github user sstach commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80482717
--- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocol.php ---
@@ -246,6 +257,10 @@ public function readMessageBegin(&$name, &$type,
&$seqid)
}
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80467634
--- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocol.php ---
@@ -246,6 +257,10 @@ public function readMessageBegin(&$name, &$type,
&$seqid)
}
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80468446
--- Diff: lib/php/lib/Thrift/Transport/TSocket.php ---
@@ -255,6 +255,16 @@ public function close()
}
/**
+ * Close the socket and
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80467137
--- Diff: compiler/cpp/src/generate/t_php_generator.cc ---
@@ -1720,6 +1720,7 @@ void
t_php_generator::generate_service_client(t_service* tservice) {
Github user sstach commented on the issue:
https://github.com/apache/thrift/pull/1014
Oh, have overseen that, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nsuke commented on the issue:
https://github.com/apache/thrift/pull/1014
@sstach it's closed because it's merged to the master dd9885e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sstach commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1093#discussion_r80425129
--- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocol.php ---
@@ -246,6 +257,10 @@ public function readMessageBegin(&$name, &$type,
&$seqid)
}
[
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522369#comment-15522369
]
Martin Wilck edited comment on THRIFT-3507 at 9/26/16 7:51 AM:
---
1.
[
https://issues.apache.org/jira/browse/THRIFT-3507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522369#comment-15522369
]
Martin Wilck commented on THRIFT-3507:
--
1.
Github user sstach commented on the issue:
https://github.com/apache/thrift/pull/1014
@asfgit Why did you closed the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user asm0dey commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1094#discussion_r80414179
--- Diff: lib/go/thrift/simple_server.go ---
@@ -183,9 +186,6 @@ func (p *TSimpleServer) processRequests(client
TTransport) error {
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1554#comment-1554
]
ASF GitHub Bot commented on THRIFT-3855:
Github user asm0dey commented on a diff in the pull
Github user dtmuller commented on the issue:
https://github.com/apache/thrift/pull/1039
@nsuke Thanks a lot for your effort - I really enjoyed working with you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/THRIFT-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522166#comment-15522166
]
ASF GitHub Bot commented on THRIFT-2835:
Github user dtmuller commented on the issue:
50 matches
Mail list logo
