[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534873#comment-15534873
]
James E. King, III commented on THRIFT-3855:
A fix was put into the stop logic for 0.10.0
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534859#comment-15534859
]
Patrick Bennett commented on THRIFT-3855:
-
I wasn't using an old version at all. I was just
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534011#comment-15534011
]
James E. King, III commented on THRIFT-3932:
I agree; this is not providing the protection
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833
]
Buğra Gedik edited comment on THRIFT-3932 at 9/29/16 7:40 PM:
--
You are
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833
]
Buğra Gedik edited comment on THRIFT-3932 at 9/29/16 7:40 PM:
--
You are
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833
]
Buğra Gedik edited comment on THRIFT-3932 at 9/29/16 7:40 PM:
--
You are
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833
]
Buğra Gedik commented on THRIFT-3932:
-
You are right, that one addresses the same issue. However,
[
https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3878:
---
Summary: Compile error in TSSLSocket.cpp with new OpenSSL
[CRYPTO_num_locks] (was:
[
https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3878:
---
Summary: Compile error in TSSLSocket.cpp with new OpenSSL (was: Compile
error in
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1044
I'll rebase on master once THRIFT-3936 is merged, since something odd
happened with the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533821#comment-15533821
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533811#comment-15533811
]
James E. King, III commented on THRIFT-3937:
[~jfarrell] The apache web site says you need
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533814#comment-15533814
]
James E. King, III commented on THRIFT-3937:
Deprecating autoconf gets you a like...
>
[
https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533809#comment-15533809
]
Jens Geyer commented on THRIFT-3882:
@[~nsuke], I guess you have more knowledge about this that I
[
https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3882:
---
Assignee: (was: Jens Geyer)
> As a developer, I would like a mode in the cross-test tool that
[
https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3882:
---
Summary: As a developer, I would like a mode in the cross-test tool that
re-enables
[
https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3882:
---
Assignee: Jens Geyer (was: James E. King, III)
> Enable make cross tests that pass
[
https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382247#comment-15382247
]
James E. King, III edited comment on THRIFT-3882 at 9/29/16 7:26 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382247#comment-15382247
]
James E. King, III edited comment on THRIFT-3882 at 9/29/16 7:25 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3932:
---
Component/s: C++ - Library
> C++ ThreadManager has a rare termination race
>
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533786#comment-15533786
]
James E. King, III commented on THRIFT-3932:
Could you rework your patch on master? The code
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533769#comment-15533769
]
Jake Farrell commented on THRIFT-3937:
--
[~jking3] we can not use the autoconf macro that you linked
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533762#comment-15533762
]
ASF GitHub Bot commented on THRIFT-3937:
Github user jeking3 commented on the issue:
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1101
I'll back out the autoconf changes then and we'll leave the CMake ones...
we should probably document on the thrift web site that although gcc-4.2 or
later is required, gcc-4.8 or later is required
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533727#comment-15533727
]
Paul Finkelshteyn commented on THRIFT-3855:
---
[~patrickb] looks like you're using old version of
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1102
THRIFT-3878: fix interop with newer OpenSSL libraries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3878
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533751#comment-15533751
]
ASF GitHub Bot commented on THRIFT-3937:
Github user jfarrell commented on the issue:
Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/1101
License on this autoconf macro is GPLWithACException, we can not include it
with Apache Thrift. see http://www.apache.org/legal/resolved.html#category-x
---
If your project is set up for it, you
[
https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-3932:
--
Assignee: James E. King, III
> C++ ThreadManager has a rare termination race
[
https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3878:
---
Affects Version/s: (was: 1.0)
0.10.0
[
https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533733#comment-15533733
]
ASF GitHub Bot commented on THRIFT-3878:
GitHub user jeking3 opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533694#comment-15533694
]
Jens Geyer commented on THRIFT-3855:
Hi [~patrickb], did you check this against current master?
> In
[
https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3935:
---
Affects Version/s: (was: 1.0)
0.9.3
> Incorrect skipping of map and set
>
[
https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3935.
Resolution: Fixed
Fix Version/s: 0.10.0
Committed, thank you.
> Incorrect skipping of map
[
https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3935:
---
Assignee: Matej Kupljen
> Incorrect skipping of map and set
> -
>
>
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1101
THRIFT-3937: if the compiler is too old (gcc before 4.8) disable new
compiler plugin during configuration
This will disable building the new compiler plug-in code if the compiler is
too old (gcc
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533647#comment-15533647
]
James E. King, III commented on THRIFT-3937:
Hopefully I got the autoconf stuff right.
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533477#comment-15533477
]
Jake Farrell commented on THRIFT-3937:
--
sounds like you have most of this worked out all ready, lets
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3937:
---
Summary: Cannot compile 0.10.0 development tip with gcc-4.6.x (was: Cannot
compile
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533432#comment-15533432
]
James E. King, III edited comment on THRIFT-3937 at 9/29/16 5:36 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3937:
---
Description:
While building the tip using cmake:
{noformat}
[ 51%] Building CXX
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533428#comment-15533428
]
James E. King, III commented on THRIFT-3937:
Confirmed: 4.8.4 builds fine; 4.6.4 builds fine
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533362#comment-15533362
]
Jake Farrell commented on THRIFT-3937:
--
I would say that if its not working for VS2010 don't try and
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533328#comment-15533328
]
James E. King, III commented on THRIFT-3937:
Let me verify that if I switch to the default
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533278#comment-15533278
]
Aki Sukegawa edited comment on THRIFT-3937 at 9/29/16 4:57 PM:
---
[~jking3]
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533278#comment-15533278
]
Aki Sukegawa commented on THRIFT-3937:
--
[~jking3] our CI uses boost 1.53 on CentOS 7
[
https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533092#comment-15533092
]
James E. King, III commented on THRIFT-3775:
I removed my fix from THRIFT-3936 for appveyor
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533085#comment-15533085
]
James E. King, III commented on THRIFT-3937:
Assigned to @nsuke initially; I can help out
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3937:
---
Assignee: Aki Sukegawa
> Cannot compile 0.10.0 development tip with gcc-4.6.3 and
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-3937:
---
Environment: Ubuntu 12.04.5 LTS with gcc-4.6.3 and boost 1.53.0, Ubuntu
14.04.2 LTS
James E. King, III created THRIFT-3939:
--
Summary: VS2010 complains about incorrect exception handling mode
during cmake build
Key: THRIFT-3939
URL: https://issues.apache.org/jira/browse/THRIFT-3939
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1044
Rebasing again on THRIFT-3936 so it compiles on VS2010 after THRIFT-2836
was introduced... so we'll want THRIFT-3936 to be merged before this one.
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532688#comment-15532688
]
ASF GitHub Bot commented on THRIFT-3873:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532663#comment-15532663
]
ASF GitHub Bot commented on THRIFT-3936:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532662#comment-15532662
]
James E. King, III commented on THRIFT-3937:
[~nsuke] any suggestions here? It looks like
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1099#discussion_r81125635
--- Diff: lib/cpp/src/thrift/TApplicationException.h ---
@@ -21,6 +21,7 @@
#define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1
#include
+#include
[
https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532570#comment-15532570
]
ASF GitHub Bot commented on THRIFT-3936:
Github user jeking3 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Kupljen updated THRIFT-3935:
--
Attachment: add-set-and-fix-map-skip.patch
> Incorrect skipping of map and set
>
[
https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532170#comment-15532170
]
Matej Kupljen commented on THRIFT-3935:
---
I have uploaded the patch that:
* adds the {{T_SET}} to
59 matches
Mail list logo