[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534873#comment-15534873 ] James E. King, III commented on THRIFT-3855: A fix was put into the stop logic for 0.10.0

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-29 Thread Patrick Bennett (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534859#comment-15534859 ] Patrick Bennett commented on THRIFT-3855: - I wasn't using an old version at all. I was just

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534011#comment-15534011 ] James E. King, III commented on THRIFT-3932: I agree; this is not providing the protection

[jira] [Comment Edited] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833 ] Buğra Gedik edited comment on THRIFT-3932 at 9/29/16 7:40 PM: -- You are

[jira] [Comment Edited] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833 ] Buğra Gedik edited comment on THRIFT-3932 at 9/29/16 7:40 PM: -- You are

[jira] [Comment Edited] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833 ] Buğra Gedik edited comment on THRIFT-3932 at 9/29/16 7:40 PM: -- You are

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533833#comment-15533833 ] Buğra Gedik commented on THRIFT-3932: - You are right, that one addresses the same issue. However,

[jira] [Updated] (THRIFT-3878) Compile error in TSSLSocket.cpp with new OpenSSL [CRYPTO_num_locks]

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3878: --- Summary: Compile error in TSSLSocket.cpp with new OpenSSL [CRYPTO_num_locks] (was:

[jira] [Updated] (THRIFT-3878) Compile error in TSSLSocket.cpp with new OpenSSL

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3878: --- Summary: Compile error in TSSLSocket.cpp with new OpenSSL (was: Compile error in

[GitHub] thrift issue #1044: THRIFT-3873: fix compiler warnings on windows with VS201...

2016-09-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1044 I'll rebase on master once THRIFT-3936 is merged, since something odd happened with the build. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533821#comment-15533821 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533811#comment-15533811 ] James E. King, III commented on THRIFT-3937: [~jfarrell] The apache web site says you need

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533814#comment-15533814 ] James E. King, III commented on THRIFT-3937: Deprecating autoconf gets you a like... >

[jira] [Commented] (THRIFT-3882) As a developer, I would like a mode in the cross-test tool that re-enables any stable test combination automatically

2016-09-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533809#comment-15533809 ] Jens Geyer commented on THRIFT-3882: @[~nsuke], I guess you have more knowledge about this that I

[jira] [Updated] (THRIFT-3882) As a developer, I would like a mode in the cross-test tool that re-enables any stable test combination automatically

2016-09-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3882: --- Assignee: (was: Jens Geyer) > As a developer, I would like a mode in the cross-test tool that

[jira] [Updated] (THRIFT-3882) As a developer, I would like a mode in the cross-test tool that re-enables any stable test combination automatically

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3882: --- Summary: As a developer, I would like a mode in the cross-test tool that re-enables

[jira] [Updated] (THRIFT-3882) Enable make cross tests that pass now

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3882: --- Assignee: Jens Geyer (was: James E. King, III) > Enable make cross tests that pass

[jira] [Comment Edited] (THRIFT-3882) Enable make cross tests that pass now

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382247#comment-15382247 ] James E. King, III edited comment on THRIFT-3882 at 9/29/16 7:26 PM: -

[jira] [Comment Edited] (THRIFT-3882) Enable make cross tests that pass now

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382247#comment-15382247 ] James E. King, III edited comment on THRIFT-3882 at 9/29/16 7:25 PM: -

[jira] [Updated] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3932: --- Component/s: C++ - Library > C++ ThreadManager has a rare termination race >

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533786#comment-15533786 ] James E. King, III commented on THRIFT-3932: Could you rework your patch on master? The code

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533769#comment-15533769 ] Jake Farrell commented on THRIFT-3937: -- [~jking3] we can not use the autoconf macro that you linked

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533762#comment-15533762 ] ASF GitHub Bot commented on THRIFT-3937: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1101: THRIFT-3937: if the compiler is too old (gcc before 4.8)...

2016-09-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1101 I'll back out the autoconf changes then and we'll leave the CMake ones... we should probably document on the thrift web site that although gcc-4.2 or later is required, gcc-4.8 or later is required

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-29 Thread Paul Finkelshteyn (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533727#comment-15533727 ] Paul Finkelshteyn commented on THRIFT-3855: --- [~patrickb] looks like you're using old version of

[GitHub] thrift pull request #1102: THRIFT-3878: fix interop with newer OpenSSL libra...

2016-09-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1102 THRIFT-3878: fix interop with newer OpenSSL libraries You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift defect/THRIFT-3878

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533751#comment-15533751 ] ASF GitHub Bot commented on THRIFT-3937: Github user jfarrell commented on the issue:

[GitHub] thrift issue #1101: THRIFT-3937: if the compiler is too old (gcc before 4.8)...

2016-09-29 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1101 License on this autoconf macro is GPLWithACException, we can not include it with Apache Thrift. see http://www.apache.org/legal/resolved.html#category-x --- If your project is set up for it, you

[jira] [Assigned] (THRIFT-3932) C++ ThreadManager has a rare termination race

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3932: -- Assignee: James E. King, III > C++ ThreadManager has a rare termination race

[jira] [Updated] (THRIFT-3878) Compile error in TSSLSocket.cpp

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3878: --- Affects Version/s: (was: 1.0) 0.10.0

[jira] [Commented] (THRIFT-3878) Compile error in TSSLSocket.cpp

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533733#comment-15533733 ] ASF GitHub Bot commented on THRIFT-3878: GitHub user jeking3 opened a pull request:

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

2016-09-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533694#comment-15533694 ] Jens Geyer commented on THRIFT-3855: Hi [~patrickb], did you check this against current master? > In

[jira] [Updated] (THRIFT-3935) Incorrect skipping of map and set

2016-09-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3935: --- Affects Version/s: (was: 1.0) 0.9.3 > Incorrect skipping of map and set >

[jira] [Resolved] (THRIFT-3935) Incorrect skipping of map and set

2016-09-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3935. Resolution: Fixed Fix Version/s: 0.10.0 Committed, thank you. > Incorrect skipping of map

[jira] [Updated] (THRIFT-3935) Incorrect skipping of map and set

2016-09-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3935: --- Assignee: Matej Kupljen > Incorrect skipping of map and set > - > >

[GitHub] thrift pull request #1101: THRIFT-3937: if the compiler is too old (gcc befo...

2016-09-29 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1101 THRIFT-3937: if the compiler is too old (gcc before 4.8) disable new compiler plugin during configuration This will disable building the new compiler plug-in code if the compiler is too old (gcc

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533647#comment-15533647 ] James E. King, III commented on THRIFT-3937: Hopefully I got the autoconf stuff right.

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533477#comment-15533477 ] Jake Farrell commented on THRIFT-3937: -- sounds like you have most of this worked out all ready, lets

[jira] [Updated] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3937: --- Summary: Cannot compile 0.10.0 development tip with gcc-4.6.x (was: Cannot compile

[jira] [Comment Edited] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533432#comment-15533432 ] James E. King, III edited comment on THRIFT-3937 at 9/29/16 5:36 PM: -

[jira] [Updated] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3937: --- Description: While building the tip using cmake: {noformat} [ 51%] Building CXX

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533428#comment-15533428 ] James E. King, III commented on THRIFT-3937: Confirmed: 4.8.4 builds fine; 4.6.4 builds fine

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533362#comment-15533362 ] Jake Farrell commented on THRIFT-3937: -- I would say that if its not working for VS2010 don't try and

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533328#comment-15533328 ] James E. King, III commented on THRIFT-3937: Let me verify that if I switch to the default

[jira] [Comment Edited] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533278#comment-15533278 ] Aki Sukegawa edited comment on THRIFT-3937 at 9/29/16 4:57 PM: --- [~jking3]

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread Aki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533278#comment-15533278 ] Aki Sukegawa commented on THRIFT-3937: -- [~jking3] our CI uses boost 1.53 on CentOS 7

[jira] [Commented] (THRIFT-3775) 0.10.0 release candidate

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533092#comment-15533092 ] James E. King, III commented on THRIFT-3775: I removed my fix from THRIFT-3936 for appveyor

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533085#comment-15533085 ] James E. King, III commented on THRIFT-3937: Assigned to @nsuke initially; I can help out

[jira] [Updated] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3937: --- Assignee: Aki Sukegawa > Cannot compile 0.10.0 development tip with gcc-4.6.3 and

[jira] [Updated] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3937: --- Environment: Ubuntu 12.04.5 LTS with gcc-4.6.3 and boost 1.53.0, Ubuntu 14.04.2 LTS

[jira] [Created] (THRIFT-3939) VS2010 complains about incorrect exception handling mode during cmake build

2016-09-29 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-3939: -- Summary: VS2010 complains about incorrect exception handling mode during cmake build Key: THRIFT-3939 URL: https://issues.apache.org/jira/browse/THRIFT-3939

[GitHub] thrift issue #1044: THRIFT-3873: fix compiler warnings on windows with VS201...

2016-09-29 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1044 Rebasing again on THRIFT-3936 so it compiles on VS2010 after THRIFT-2836 was introduced... so we'll want THRIFT-3936 to be merged before this one. --- If your project is set up for it, you can

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532688#comment-15532688 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3936) Cannot compile 0.10.0 development tip with VS2013 and earlier (snprintf, uint32_t)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532663#comment-15532663 ] ASF GitHub Bot commented on THRIFT-3936: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.3 and boost-1.53

2016-09-29 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532662#comment-15532662 ] James E. King, III commented on THRIFT-3937: [~nsuke] any suggestions here? It looks like

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-29 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r81125635 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[jira] [Commented] (THRIFT-3936) Cannot compile 0.10.0 development tip with VS2013 and earlier (snprintf, uint32_t)

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532570#comment-15532570 ] ASF GitHub Bot commented on THRIFT-3936: Github user jeking3 commented on a diff in the pull

[jira] [Updated] (THRIFT-3935) Incorrect skipping of map and set

2016-09-29 Thread Matej Kupljen (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matej Kupljen updated THRIFT-3935: -- Attachment: add-set-and-fix-map-skip.patch > Incorrect skipping of map and set >

[jira] [Commented] (THRIFT-3935) Incorrect skipping of map and set

2016-09-29 Thread Matej Kupljen (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532170#comment-15532170 ] Matej Kupljen commented on THRIFT-3935: --- I have uploaded the patch that: * adds the {{T_SET}} to