[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15539293#comment-15539293 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 By removing the THRIFT_SLEEP_USEC(1) calls in the test it gets much faster, which is great, however as part of this effort I have discovered our boost implementation is broken in some way. I

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15539162#comment-15539162 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 I think I found the reason for the poor test performance on Windows - the minimum granularity of a sleep call on Windows as defined by thrift_usleep() is 1 millisecond. So in a test where we

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15539134#comment-15539134 ] James E. King, III commented on THRIFT-3932: I tried to re-enable some tests on appveyor. It

[jira] [Comment Edited] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537938#comment-15537938 ] James E. King, III edited comment on THRIFT-3932 at 10/1/16 6:15 PM: -

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538952#comment-15538952 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 It looks like we have a number of tests disabled on Appveyor that were not behaving well... I'm going to re-enable as many as I can since they seem to be pretty stable for me locally, starting with

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538754#comment-15538754 ] James E. King, III commented on THRIFT-3873: Marking this blocked by THRIFT-3932 because it

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538745#comment-15538745 ] James E. King, III commented on THRIFT-3932: Done. > C++ ThreadManager has a rare

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538724#comment-15538724 ] James E. King, III commented on THRIFT-3932: Ah, the original logic in removeExpiredTasks was

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538711#comment-15538711 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1044: THRIFT-3873: fix compiler warnings on windows with VS201...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1044 I'm closing this to re-submit it without THRIFT-3936 in it since it was merged to master, but when I rebased it's still here. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (THRIFT-3873) Fix various compiler warnings when using VS2010

[ https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538710#comment-15538710 ] ASF GitHub Bot commented on THRIFT-3873: Github user jeking3 closed the pull request at:

[GitHub] thrift pull request #1044: THRIFT-3873: fix compiler warnings on windows wit...

Github user jeking3 closed the pull request at: https://github.com/apache/thrift/pull/1044 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3937) Cannot compile 0.10.0 development tip with gcc-4.6.x

[ https://issues.apache.org/jira/browse/THRIFT-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538698#comment-15538698 ] James E. King, III commented on THRIFT-3937: [~nsuke] This is ready to be merged. I also

[jira] [Resolved] (THRIFT-3936) Cannot compile 0.10.0 development tip with VS2013 and earlier (snprintf, uint32_t)

[ https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3936. -- Resolution: Fixed Fix Version/s: 0.10.0 committed, thanks. > Cannot compile 0.10.0

[jira] [Resolved] (THRIFT-3878) Compile error in TSSLSocket.cpp with new OpenSSL [CRYPTO_num_locks]

[ https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3878. -- Resolution: Fixed Fix Version/s: 0.10.0 committed, thanks. > Compile error in

[jira] [Resolved] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions

[ https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3831. -- Resolution: Fixed Assignee: Cody Schafer Fix Version/s: 0.10.0 committed,

[jira] [Commented] (THRIFT-3831) build of test/cpp/src/TestClient.cpp fails with newer gcc on platforms with unsigned char due to narrowing conversions

[ https://issues.apache.org/jira/browse/THRIFT-3831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538645#comment-15538645 ] ASF GitHub Bot commented on THRIFT-3831: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3936) Cannot compile 0.10.0 development tip with VS2013 and earlier (snprintf, uint32_t)

[ https://issues.apache.org/jira/browse/THRIFT-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538644#comment-15538644 ] ASF GitHub Bot commented on THRIFT-3936: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-3878) Compile error in TSSLSocket.cpp with new OpenSSL [CRYPTO_num_locks]

[ https://issues.apache.org/jira/browse/THRIFT-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538646#comment-15538646 ] ASF GitHub Bot commented on THRIFT-3878: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1099 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1085: THRIFT-3831 in test/cpp explicitly use `signed ch...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1102: THRIFT-3878: fix interop with newer OpenSSL libra...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3902) TFramedTransport.open throws NullPointerException

[ https://issues.apache.org/jira/browse/THRIFT-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538563#comment-15538563 ] ASF GitHub Bot commented on THRIFT-3902: GitHub user nsuke opened a pull request:

[GitHub] thrift pull request #1105: THRIFT-3902 TFramedTransport.open throws NullPoin...

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1105 THRIFT-3902 TFramedTransport.open throws NullPointerException You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3902

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538551#comment-15538551 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 It is pretty frustrating when you build, test, repeat many many times and everything looks good, and then the CI build fails, but that's why it's there right? --- If your project is set up for

[jira] [Commented] (THRIFT-3940) Visual Studio project file for compiler is broken

[ https://issues.apache.org/jira/browse/THRIFT-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538509#comment-15538509 ] ASF GitHub Bot commented on THRIFT-3940: GitHub user nsuke opened a pull request:

[GitHub] thrift pull request #1104: THRIFT-3940 Visual Studio project file for compil...

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1104 THRIFT-3940 Visual Studio project file for compiler is broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3940

[jira] [Created] (THRIFT-3940) Visual Studio project file for compiler is broken

Aki Sukegawa created THRIFT-3940: Summary: Visual Studio project file for compiler is broken Key: THRIFT-3940 URL: https://issues.apache.org/jira/browse/THRIFT-3940 Project: Thrift Issue

[jira] [Commented] (THRIFT-3855) In the go simple server, if Stop() is called multiple times it hangs

[ https://issues.apache.org/jira/browse/THRIFT-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538486#comment-15538486 ] Aki Sukegawa commented on THRIFT-3855: -- [~patrickb] thanks for describing the problems. It seems to

[jira] [Comment Edited] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538134#comment-15538134 ] Buğra Gedik edited comment on THRIFT-3932 at 10/1/16 8:02 AM: -- Looks good to

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538134#comment-15538134 ] Buğra Gedik commented on THRIFT-3932: - Looks good to me. > C++ ThreadManager has a rare termination