Re: make vs make all

On 10/17/2016 05:12 PM, Jens Geyer wrote: Hi all, I just recognized that “make” does no longer build the Thrift compiler anymore, only “make all” does. Is it my setup, is it by design or is there something wrong with the build scripts? Have fun, JensG On Linux, I just did: git clone https:

[jira] [Commented] (THRIFT-2954) calling function with parameter type different as defined in idl breaks the connection

[ https://issues.apache.org/jira/browse/THRIFT-2954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583935#comment-15583935 ] David Lieberman commented on THRIFT-2954: - I can reproduce this in my production

[jira] [Resolved] (THRIFT-3946) Java 1.5 compatibility broken for binary fields (java5 option)

[ https://issues.apache.org/jira/browse/THRIFT-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3946. Resolution: Fixed Fix Version/s: 0.11.0 Committed. > Java 1.5 compatibility broken for bina

[jira] [Updated] (THRIFT-3946) Java 1.5 compatibility broken for binary fields (java5 option)

[ https://issues.apache.org/jira/browse/THRIFT-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3946: --- Assignee: Philip Hamer > Java 1.5 compatibility broken for binary fields (java5 option) > ---

make vs make all

Hi all, I just recognized that “make” does no longer build the Thrift compiler anymore, only “make all” does. Is it my setup, is it by design or is there something wrong with the build scripts? Have fun, JensG

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582594#comment-15582594 ] ASF GitHub Bot commented on THRIFT-3932: Github user ben-craig commented on the i

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user ben-craig commented on the issue: https://github.com/apache/thrift/pull/1103 I'm fine with you adding back setDetached and marking it deprecated. If you really want, you could even put in some logic so that you assert or throw an error if someone calls setDetached after a

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582535#comment-15582535 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the iss

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 What you described is a failing in the original set of thread factories to provide common functionality (detached, policy, priority) in the base class. Only PosixThreadFactory has policy and priori

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user ben-craig commented on the issue: https://github.com/apache/thrift/pull/1103 PlatformThreadFactory f; f.setDetached(false); Prior to this change, that was the only way to portably change the detached state. The PosixThreadFactory didn't have a ctor that would

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582485#comment-15582485 ] ASF GitHub Bot commented on THRIFT-3932: Github user ben-craig commented on the i

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582271#comment-15582271 ] James E. King, III commented on THRIFT-3932: [~jfarrell] sounds good. > C++

[jira] [Commented] (THRIFT-3932) C++ ThreadManager has a rare termination race

[ https://issues.apache.org/jira/browse/THRIFT-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582164#comment-15582164 ] ASF GitHub Bot commented on THRIFT-3932: Github user jeking3 commented on the iss

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1103 @ben-craig changing the "detached" behavior of an active thread manager seems like a bug to me which is why I removed it. What is the use case for it? --- If your project is set up for it, you can

[jira] [Resolved] (THRIFT-1944) Binding to zero port

[ https://issues.apache.org/jira/browse/THRIFT-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-1944. Resolution: Cannot Reproduce Fix Version/s: 0.9.2 I opened THRIFT-3947 and T

[jira] [Created] (THRIFT-3948) errno is not the correct method of getting the error in windows

James E. King, III created THRIFT-3948: -- Summary: errno is not the correct method of getting the error in windows Key: THRIFT-3948 URL: https://issues.apache.org/jira/browse/THRIFT-3948 Project:

[jira] [Created] (THRIFT-3947) sockaddr type isn't always large enough for the return of getsockname

James E. King, III created THRIFT-3947: -- Summary: sockaddr type isn't always large enough for the return of getsockname Key: THRIFT-3947 URL: https://issues.apache.org/jira/browse/THRIFT-3947 Pro