[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620861#comment-15620861 ] ASF GitHub Bot commented on THRIFT-3301: Github user bgould commented on the issue:

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-30 Thread bgould
Github user bgould commented on the issue: https://github.com/apache/thrift/pull/1119 @Jens-G IMO this is a valid use case but it is not necessarily a great idea because in general its not very user friendly to design an API that clashes names in java.lang.* ... it is even

Re: How do I test code-generation?

2016-10-30 Thread Randy Abernethy
The Thrift test suit comes with a cross test that runs languages through a complex set of idl tests, with themselves (client to server) and with other languages. Take a look at make cross. On Monday, October 31, 2016, Allen George wrote: > Hi, > > I've just started

[jira] [Commented] (THRIFT-3954) Enable the usage of structs called "Object" in Java

2016-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15620384#comment-15620384 ] ASF GitHub Bot commented on THRIFT-3954: Github user ne0h commented on the issue:

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-30 Thread ne0h
Github user ne0h commented on the issue: https://github.com/apache/thrift/pull/1119 Hi Jens-G, of course: https://issues.apache.org/jira/browse/THRIFT-3954 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Created] (THRIFT-3954) Enable the usage of structs called"Object" in Java

2016-10-30 Thread Maximilian Hess (JIRA)
Maximilian Hess created THRIFT-3954: --- Summary: Enable the usage of structs called"Object" in Java Key: THRIFT-3954 URL: https://issues.apache.org/jira/browse/THRIFT-3954 Project: Thrift

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-30 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1119 Hi @ne0h, could you just [create a JIRA ticket for this](http://thrift.apache.org/docs/HowToContribute)? @Java devs: Comments anyone? --- If your project is set up for it, you

How do I test code-generation?

2016-10-30 Thread Allen George
Hi, I've just started writing a language binding, and I don't know how I'd go about testing that my autogen'd files look right. Is there an automated test hook for this? Or do I have to make the binary and test it out manually? (On that note, seems like configure ignores --prefix and installs