[GitHub] thrift issue #1120: THRIFT-3301: Naming collisions possible in generated Jav...

2016-10-31 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1120 @bgould the failing CI job is make dist tarball verification. It's typically caused by missing `EXTRA_DIST` entries for newly added files in `Makefile.am`. --- If your project is set up for it,

[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624433#comment-15624433 ] ASF GitHub Bot commented on THRIFT-3301: Github user nsuke commented on the issue:

[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624404#comment-15624404 ] ASF GitHub Bot commented on THRIFT-3301: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1120: THRIFT-3301: Naming collisions possible in generated Jav...

2016-10-31 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1120 > The following tests FAILED: >40 - JavaTest (Failed) > Errors while running CTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15624295#comment-15624295 ] ASF GitHub Bot commented on THRIFT-3301: GitHub user bgould opened a pull request:

[GitHub] thrift pull request #1120: THRIFT-3301: Naming collisions possible in genera...

2016-10-31 Thread bgould
GitHub user bgould opened a pull request: https://github.com/apache/thrift/pull/1120 THRIFT-3301: Naming collisions possible in generated Java code Switched to fully-qualified names for all class name references in generated code. Added test IDL to verify generated code compiles

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-31 Thread bgould
Github user bgould commented on the issue: https://github.com/apache/thrift/pull/1119 @jeking3 I agree completely. Didn't mean to give the impression that it shouldn't be supported. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Resolved] (THRIFT-3954) Enable the usage of structs called "Object" in Java

2016-10-31 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3954. Resolution: Fixed Assignee: Maximilian Hess Fix Version/s: 0.11.0 Committed. >

[jira] [Commented] (THRIFT-3954) Enable the usage of structs called "Object" in Java

2016-10-31 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622845#comment-15622845 ] Jens Geyer commented on THRIFT-3954: GitHub user ne0h opened a pull request:

[jira] [Commented] (THRIFT-3955) TThreadedServer Memory Leak

2016-10-31 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622389#comment-15622389 ] James E. King, III commented on THRIFT-3955: Hi, thanks. I will take a look. >

[jira] [Commented] (THRIFT-3301) Java generated code uses imports that can lead to class name collisions with IDL defined types

2016-10-31 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15622384#comment-15622384 ] James E. King, III commented on THRIFT-3301: I would add java.lang.Object to this list,

[GitHub] thrift issue #1119: Java generator: Added "java.lang." to all generated inst...

2016-10-31 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1119 @bgould Generated code should always be explicitly fully pathed or namespaced and never make any assumptions. Thrift already uses namespaces so I would have no problem with org.king.Object as a

[jira] [Commented] (THRIFT-3955) TThreadedServer Memory Leak

2016-10-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621911#comment-15621911 ] ASF GitHub Bot commented on THRIFT-3955: Github user tzongw commented on the issue:

[GitHub] thrift issue #1117: Fixed TThreadedServer Memory Leak

2016-10-31 Thread tzongw
Github user tzongw commented on the issue: https://github.com/apache/thrift/pull/1117 Added a ticket https://issues.apache.org/jira/browse/THRIFT-3955 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Created] (THRIFT-3955) TThreadedServer Memory Leak

2016-10-31 Thread zoowee (JIRA)
zoowee created THRIFT-3955: -- Summary: TThreadedServer Memory Leak Key: THRIFT-3955 URL: https://issues.apache.org/jira/browse/THRIFT-3955 Project: Thrift Issue Type: Improvement