[GitHub] thrift pull request #1137: Implement CONST support

GitHub user przygienda opened a pull request: https://github.com/apache/thrift/pull/1137 Implement CONST support You can merge this pull request into a Git repository by running: $ git pull https://github.com/maximg/thrift dev-rust-thrift Alternatively you can review and

Re: Why are there no unions in ThriftTest.thrift?

Hi Jen, Ah. That makes sense. Absolutely - I'd be happy to toss up a PR in the next few days. Allen Terminal Musings: http://www.allengeorge.com/ Raft in Java: https://github.com/allengeorge/libraft/ Twitter: https://twitter.com/allenageorge/ On Wed, Dec 7, 2016 at 3:09 AM, Jens Geyer

Re: Why are there no unions in ThriftTest.thrift?

Ooops. My bad - "Jens" not "Jen". So sorry for the misspelling :( Terminal Musings: http://www.allengeorge.com/ Raft in Java: https://github.com/allengeorge/libraft/ Twitter: https://twitter.com/allenageorge/ On Wed, Dec 7, 2016 at 10:48 PM, Allen George wrote: > Hi Jen,

Re: Why are there no unions in ThriftTest.thrift?

Hi George, good question. Main reason is very likely because a) they were added later and b) they work a lot like structs. Nevertheless you are absolutely right, they should be, as they are a core part of the language. Would you mind adding them and some test cases in one or two languages of