[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823014#comment-15823014
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
@anatol No worries! I was glad to do it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822993#comment-15822993
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on the issue:
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
@allengeorge Hi Allen, I was intended to send only `.gitignore` comments
related to `erl`. The other two comments were create a long time ago and for
some reason github decided to publish it this
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822990#comment-15822990
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
@anatol My apologies for the earlier spam. FWIW, the latest version of the
PR has the following:
- The "thrift" crate name (I do not use "rift" anywhere)
- I use the "_" suffix
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126537
--- Diff: .gitignore ---
@@ -206,6 +206,7 @@ project.lock.json
/lib/delphi/test/typeregistry/*.local
/lib/delphi/test/typeregistry/*.dcu
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822985#comment-15822985
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822987#comment-15822987
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126534
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -2722,7 +2756,30 @@ string t_rs_generator::rust_namespace(t_service*
tservice) {
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126542
--- Diff: .gitignore ---
@@ -281,6 +293,7 @@ project.lock.json
/test/log/
/test/test.log
/test/erl/.generated
+/test/erl/.rebar
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822986#comment-15822986
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822984#comment-15822984
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96126529
--- Diff: lib/rs/Cargo.toml ---
@@ -0,0 +1,17 @@
+[package]
+name = "rift"
--- End diff --
@anatol I've previously changed this -
Benoit Sigoure created THRIFT-4031:
--
Summary: Go plugin generates invalid code for lists of typedef'ed
built-in types
Key: THRIFT-4031
URL: https://issues.apache.org/jira/browse/THRIFT-4031
Project:
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822950#comment-15822950
]
John Sirois commented on THRIFT-4029:
-
This really is the behavior you want - mutable artifacts cause
[
https://issues.apache.org/jira/browse/THRIFT-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822948#comment-15822948
]
Jake Farrell commented on THRIFT-4029:
--
Uploaded a new package which has the headers in it. It is a
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
[puzzled] I removed the reserved prefix and added an underscore suffix as
you requested. Perhaps I didn't commit that. Let me check. Sorry about that!
And, BTW - I would be very happy to
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822944#comment-15822944
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822943#comment-15822943
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
Sorry @anatol - I thought I'd changed the package name everywhere! I must
have missed that. Let me fix it ASAP. Sorry!
On Sat, Jan 14, 2017 at 3:20 PM -0500,
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822942#comment-15822942
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on the issue:
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
This patch looks really good. Thank you @allengeorge for your work! Thrift
team, is there anything left that prevents rust library from merging?
Is there a such status as 'thrift library
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822937#comment-15822937
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822938#comment-15822938
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822935#comment-15822935
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on a diff in the pull
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96123137
--- Diff: .gitignore ---
@@ -206,6 +206,7 @@ project.lock.json
/lib/delphi/test/typeregistry/*.local
/lib/delphi/test/typeregistry/*.dcu
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r96123141
--- Diff: .gitignore ---
@@ -281,6 +293,7 @@ project.lock.json
/test/log/
/test/test.log
/test/erl/.generated
+/test/erl/.rebar
--- End
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r94457731
--- Diff: compiler/cpp/src/thrift/generate/t_rs_generator.cc ---
@@ -2722,7 +2756,30 @@ string t_rs_generator::rust_namespace(t_service*
tservice) {
}
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822876#comment-15822876
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
Hi guys - any comments on this PR? I think I've addressed all review
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user vgotra commented on the issue:
https://github.com/apache/thrift/pull/1088
Hi @Jens-G
You can use .NET Core SDK 1.0 Preview 4 build 004233
(https://github.com/dotnet/core/blob/master/release-notes/preview4-download.md)
- this package supports new csproj format
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1088
I can't get it to work. The most recent build I found for Windows is
telling me
```
.NET Command Line Tools (1.0.0-preview2-1-003177)
Product Information:
Version:
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1088
The first thing I noticed is that there are a bunch of one-line changes
where an UTF-8 BOM has been added to certain files. Not that I'm against it,
but can we at least have it consistently? E.g.
34 matches
Mail list logo
