[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833249#comment-15833249
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
@anatol Thanks for the clippy output! I'll look through all of the items
and fix them. I'd no idea that `new()` without `Default` was considered a code
smell. Interesting.
---
If your project
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833247#comment-15833247
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211560
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833239#comment-15833239
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on the issue:
Github user anatol commented on the issue:
https://github.com/apache/thrift/pull/1147
FYI: run the code through `clippy` checker and [here is its
output](http://pastebin.com/icvD3yNA) Some of the warnings (but not all) look
interesting.
---
If your project is set up for it, you
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833237#comment-15833237
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on a diff in the pull
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211272
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833229#comment-15833229
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97211074
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210978
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833222#comment-15833222
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on a diff in the pull
Github user allengeorge commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210903
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833221#comment-15833221
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833220#comment-15833220
]
ASF GitHub Bot commented on THRIFT-2945:
Github user anatol commented on a diff in the pull
Github user anatol commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1147#discussion_r97210872
--- Diff: lib/rs/src/errors.rs ---
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833207#comment-15833207
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
Updated:
- Auto-generate constructors for all public structs
- Auto-generate `Default` impl for structs with all-optional fields
- Add constructors for protocol/transport
[
https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833081#comment-15833081
]
ASF GitHub Bot commented on THRIFT-3973:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1162#discussion_r97203001
--- Diff: build/wincpp/build-thrift-compiler.bat ---
@@ -0,0 +1,80 @@
+::
+:: Licensed under the Apache License, Version 2.0 (the "License");
+::
[
https://issues.apache.org/jira/browse/THRIFT-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833079#comment-15833079
]
ASF GitHub Bot commented on THRIFT-3973:
Github user jeking3 commented on a diff in the pull
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1162#discussion_r97203010
--- Diff: build/wincpp/build-thrift-compiler.bat ---
@@ -0,0 +1,80 @@
+::
+:: Licensed under the Apache License, Version 2.0 (the "License");
+::
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833075#comment-15833075
]
James E. King, III commented on THRIFT-2504:
Sorry, process leakage from corporate
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Summary: I want a server-side upgrade to MultiplexedProtocol to maintain
backwards
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Summary: I want a server-side upgrade to MultiplexedProtocol to allow an
older
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833052#comment-15833052
]
Jens Geyer edited comment on THRIFT-2504 at 1/21/17 4:54 PM:
-
**As a
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833052#comment-15833052
]
Jens Geyer commented on THRIFT-2504:
As a developer I coninue to ask myself whether other folks (i.e.
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Description:
Multiplexed Protocol provides a number of benefits. It would be useful
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III reassigned THRIFT-2504:
--
Assignee: James E. King, III
> As a developer, I want a server-side upgrade
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Description:
Multiplexed Protocol provides a number of benefits. It would be useful
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Summary: As a developer, I want a server-side upgrade to
MultiplexedProtocol to
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Description: Multiplexed Protocol provides a number of benefits. It would
be useful
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2504:
---
Summary: As a developer, I want a server-side upgrade to
MultiplexedProtocol to
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833044#comment-15833044
]
James E. King, III commented on THRIFT-2504:
I like the concept of having a backwards
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833031#comment-15833031
]
Aleksey Pesternikov commented on THRIFT-2504:
-
[~jking], after 2 years I don't even have a
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833017#comment-15833017
]
James E. King, III commented on THRIFT-3013:
I understand where folks are coming from, so
[
https://issues.apache.org/jira/browse/THRIFT-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833008#comment-15833008
]
James E. King, III commented on THRIFT-3581:
I just wanted to make sure we would not be
[
https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832996#comment-15832996
]
ASF GitHub Bot commented on THRIFT-2945:
Github user allengeorge commented on the issue:
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1147
Any thoughts on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832918#comment-15832918
]
Jens Geyer commented on THRIFT-3013:
[~jking3], when cmake is able to create an VCSPROJ for the
[
https://issues.apache.org/jira/browse/THRIFT-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832915#comment-15832915
]
Jens Geyer commented on THRIFT-3000:
You're probably right. Only caveat is mono, I'll have to check
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832913#comment-15832913
]
Jens Geyer edited comment on THRIFT-3013 at 1/21/17 10:07 AM:
--
{quote}
Also
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832913#comment-15832913
]
Jens Geyer edited comment on THRIFT-3013 at 1/21/17 10:02 AM:
--
{quote}
Also
[
https://issues.apache.org/jira/browse/THRIFT-3013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832913#comment-15832913
]
Jens Geyer commented on THRIFT-3013:
{quote}
Also FWIW I actually appreciate how simple it is to
44 matches
Mail list logo
