[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 @jeking3 I think `/CMakeList.txt` is the only entrance, we can just improve document, to fix this issue, is it? --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833942#comment-15833942 ] ASF GitHub Bot commented on THRIFT-4034: Github user RobberPhex commented on the issue:

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833919#comment-15833919 ] ASF GitHub Bot commented on THRIFT-4034: Github user RobberPhex commented on the issue:

[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 @jeking3 fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833864#comment-15833864 ] ASF GitHub Bot commented on THRIFT-4034: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1161#discussion_r97247885 --- Diff: compiler/cpp/CMakeLists.txt --- @@ -53,6 +53,7 @@ set(compiler_core set(thrift-compiler_SOURCES src/thrift/main.cc

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833757#comment-15833757 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 Yay! Build passed :) Any thoughts on whether this is OK to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833725#comment-15833725 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 Fixed makefile errors with `make distdir` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Assigned] (THRIFT-4039) Update of Apache Thrift .Net Core lib

[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4039: -- Assignee: Jens Geyer > Update of Apache Thrift .Net Core lib >

[jira] [Commented] (THRIFT-4039) Update of Apache Thrift .Net Core lib

[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833634#comment-15833634 ] Jens Geyer commented on THRIFT-4039: GitHub user vgotra opened a pull request:

[jira] [Commented] (THRIFT-4039) Update of Apache Thrift .Net Core lib

[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833626#comment-15833626 ] ASF GitHub Bot commented on THRIFT-4039: Github user vgotra commented on the issue:

[GitHub] thrift issue #1163: THRIFT-4039: Update of Apache Thrift .Net Core lib

Github user vgotra commented on the issue: https://github.com/apache/thrift/pull/1163 Hi @Jens-G Added pull request with changes described in Jira task and in pull request. Later after stabilizing and release of .NET Standard 2.0 I will create new request with

[jira] [Created] (THRIFT-4039) Update of Apache Thrift .Net Core lib

Volodymyr Gotra created THRIFT-4039: --- Summary: Update of Apache Thrift .Net Core lib Key: THRIFT-4039 URL: https://issues.apache.org/jira/browse/THRIFT-4039 Project: Thrift Issue Type:

[GitHub] thrift issue #1163: Update of Apache Thrift .Net Core lib

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1163 http://thrift.apache.org/docs/HowToContribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] thrift pull request #1163: Update of Apache Thrift .Net Core lib

GitHub user vgotra opened a pull request: https://github.com/apache/thrift/pull/1163 Update of Apache Thrift .Net Core lib Changes to library: - Updated tutorial (added samples of usage of multiplexed protocol to server and client side and other) - Added framed transport to

[jira] [Commented] (THRIFT-4034) CMake doesn't work to build compiler

[ https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833618#comment-15833618 ] ASF GitHub Bot commented on THRIFT-4034: Github user RobberPhex commented on the issue:

[GitHub] thrift issue #1161: THRIFT-4034 CMake doesn't work to build compiler

Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1161 All ci have passed, finally. Please merge this pr. :) --- change list: * appveyor have installed openssl, removed installation of openssl * remove HACK of

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833537#comment-15833537 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 More updates: - Minor cleanups to Rust code generators - Confirmed that all Rust code does not trigger any clippy lint warnings --- If your project is set up for it, you can reply

[GitHub] thrift issue #1147: THRIFT-2945 Add Rust support

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1147 @anatol Code has been updated with the following changes: - All usage of `try!` converted to `?` - Fix all but two clippy lint warnings (I thought the existing code was clearer)

[jira] [Commented] (THRIFT-2945) Implement support for Rust language

[ https://issues.apache.org/jira/browse/THRIFT-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833497#comment-15833497 ] ASF GitHub Bot commented on THRIFT-2945: Github user allengeorge commented on the issue:

[jira] [Resolved] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails

[ https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4038. Resolution: Fixed Assignee: Jens Geyer Fix Version/s: 0.11.0 Committed. > socket

[GitHub] thrift pull request #1153: fix a bug in windows

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails

[ https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833485#comment-15833485 ] Jens Geyer commented on THRIFT-4038: fix a bug in windows The `SOCKET` type is defined as a

[jira] [Commented] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails

[ https://issues.apache.org/jira/browse/THRIFT-4038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833460#comment-15833460 ] ASF GitHub Bot commented on THRIFT-4038: Github user Jens-G commented on the issue:

[GitHub] thrift issue #1153: fix a bug in windows

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1153 Tracked in THRIFT-4038 @GZShi: next time please have a look at our [contrib guidelines](http://thrift.apache.org/docs/HowToContribute) --- If your project is set up for it, you can reply to

[jira] [Created] (THRIFT-4038) socket check: checking an unsigned number against >= 0 never fails

Jens Geyer created THRIFT-4038: -- Summary: socket check: checking an unsigned number against >= 0 never fails Key: THRIFT-4038 URL: https://issues.apache.org/jira/browse/THRIFT-4038 Project: Thrift