[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837225#comment-15837225 ] ASF GitHub Bot commented on THRIFT-3891: Github user bgedik commented on a diff in the pull

[jira] [Commented] (THRIFT-3891) TNonblockingServer configured with more than one IO threads does not always return from serve() upon stop()

2017-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837222#comment-15837222 ] ASF GitHub Bot commented on THRIFT-3891: Github user bgedik commented on a diff in the pull

[GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...

2017-01-24 Thread bgedik
Github user bgedik commented on a diff in the pull request: https://github.com/apache/thrift/pull/1080#discussion_r97712383 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) { }

[GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...

2017-01-24 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1080#discussion_r97708735 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1524,7 +1532,7 @@ void TNonblockingIOThread::breakLoop(bool error) { }

[jira] [Commented] (THRIFT-3926) There should be an error emitted when http status code is not 200

2017-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837176#comment-15837176 ] ASF GitHub Bot commented on THRIFT-3926: Github user asfgit closed the pull request at:

[jira] [Resolved] (THRIFT-3926) There should be an error emitted when http status code is not 200

2017-01-24 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3926. Resolution: Fixed Fix Version/s: 0.11.0 > There should be an error emitted

[GitHub] thrift pull request #1086: THRIFT-3926 Emit an error for bad http status cod...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1086 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-4039) Update of Apache Thrift .Net Core lib

2017-01-24 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4039. Resolution: Fixed Assignee: Volodymyr Gotra (was: Jens Geyer) Fix Version/s:

[jira] [Commented] (THRIFT-4039) Update of Apache Thrift .Net Core lib

2017-01-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836896#comment-15836896 ] ASF GitHub Bot commented on THRIFT-4039: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1163: THRIFT-4039: Update of Apache Thrift .Net Core li...

2017-01-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #930: THRIFT-3369 : Implement SSL/TLS support on C with c_glib

2017-01-24 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/930 It looks like you merged instead of rebasing. If memory serves you had 11 commits originally. What I would recommend is that you: 1. git checkout master 2. git fetch upstream

[GitHub] thrift issue #930: THRIFT-3369 : Implement SSL/TLS support on C with c_glib

2017-01-24 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/930 This is unmanageable. Now it fails because something in Java is not properly working. Would I be able to merge? --- If your project is set up for it, you can reply to this email and have your

[GitHub] thrift issue #930: THRIFT-3369 : Implement SSL/TLS support on C with c_glib

2017-01-24 Thread gadLinux
Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/930 As I told, there problem on CI is not because something we did. But it seem that it was already in the branch we forked from, cause it gave in a place we didn't touch. Anyway I rebased. Hope did it