[GitHub] thrift issue #422: THRIFT-3080: fix connection leak of C++ Nonblocking Serve...

2017-02-23 Thread xiaosuo
Github user xiaosuo commented on the issue: https://github.com/apache/thrift/pull/422 This patch may introduce a more serious problem in theory. No standard defines writing to a socket is an atomic operation, so if writing is interleaved by other threads, the reading end will

[jira] [Commented] (THRIFT-3080) C++ TNonblockingServer connection leak while accept huge number connections.

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882093#comment-15882093 ] ASF GitHub Bot commented on THRIFT-3080: Github user xiaosuo commented on the issue:

[jira] [Commented] (THRIFT-4102) TBufferedTransport performance issue since 0.10.0

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881589#comment-15881589 ] ASF GitHub Bot commented on THRIFT-4102: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1203: THRIFT-4102 TBufferedTransport performance issue since 0...

2017-02-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1203 Wow this build hasn't started for about 18 hours! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881249#comment-15881249 ] ASF GitHub Bot commented on THRIFT-3921: Github user alexandruavadanii commented on the issue:

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-23 Thread alexandruavadanii
Github user alexandruavadanii commented on the issue: https://github.com/apache/thrift/pull/1083 To be honest, my C++ is a bit rusty, I got here indirectly while investigating a downstream bug (https://jira.opnfv.org/browse/ARMBAND-224). Btw, OS/compiler info: Ubuntu Xenial

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881236#comment-15881236 ] ASF GitHub Bot commented on THRIFT-3921: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1083 @alexandruavadanii thanks, I reopened the ticket. Looks like it might be a C++11 issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2017-02-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881234#comment-15881234 ] James E. King, III commented on THRIFT-3921: Re-opening based on the failure. > C++ code

[jira] [Commented] (THRIFT-3921) C++ code should print enums as strings

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881231#comment-15881231 ] ASF GitHub Bot commented on THRIFT-3921: Github user alexandruavadanii commented on the issue:

[GitHub] thrift issue #1083: THRIFT-3921 Add C++ ostream operator<< functions for enu...

2017-02-23 Thread alexandruavadanii
Github user alexandruavadanii commented on the issue: https://github.com/apache/thrift/pull/1083 Hi, This seems to have caused a regression on AArch64. I didn't investigate it yet, usually it's some signed vs unsigned char in compiler defaults, maybe some other type mismatches.

[jira] [Commented] (THRIFT-4102) TBufferedTransport performance issue since 0.10.0

2017-02-23 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881124#comment-15881124 ] Jens Geyer commented on THRIFT-4102: Introduced by THRIFT-1857 > TBufferedTransport performance

Looking for Code Reviews on

2017-02-23 Thread Jim King
THRIFT-1805: [Java - exception handling] https://github.com/apache/thrift/pull/1186 THRIFT-3891: [C++ - Nonblocking Server stop] https://github.com/apache/thrift/pull/1196 These passed our CI build gates and just need approval(s) from folks so they can be merged. Thanks.

[jira] [Assigned] (THRIFT-4102) TBufferedTransport performance issue since 0.10.0

2017-02-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4102: -- Assignee: James E. King, III > TBufferedTransport performance issue since

[jira] [Commented] (THRIFT-3984) PHP7 extension causes segfault

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880816#comment-15880816 ] ASF GitHub Bot commented on THRIFT-3984: Github user asfgit closed the pull request at:

[jira] [Assigned] (THRIFT-3984) PHP7 extension causes segfault

2017-02-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3984: -- Assignee: James E. King, III > PHP7 extension causes segfault >

[jira] [Resolved] (THRIFT-3984) PHP7 extension causes segfault

2017-02-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3984. Resolution: Fixed Fix Version/s: 0.11.0 > PHP7 extension causes segfault >

[GitHub] thrift pull request #1152: THRIFT-3984 PHP7 extension causes segfault

2017-02-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1152 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (THRIFT-3984) PHP7 extension causes segfault

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880798#comment-15880798 ] ASF GitHub Bot commented on THRIFT-3984: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1152: THRIFT-3984 PHP7 extension causes segfault

2017-02-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1152 Thanks for the reminder. Things with failures often slip (as you can see from the current backlog). I will merge this. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (THRIFT-3369) Implement SSL/TLS support on C with c_glib

2017-02-23 Thread Gonzalo Aguilar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880746#comment-15880746 ] Gonzalo Aguilar commented on THRIFT-3369: - Please James, add the bug report. I will do the job on

[jira] [Commented] (THRIFT-3984) PHP7 extension causes segfault

2017-02-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880491#comment-15880491 ] ASF GitHub Bot commented on THRIFT-3984: Github user zhaakhi commented on the issue:

[GitHub] thrift issue #1152: THRIFT-3984 PHP7 extension causes segfault

2017-02-23 Thread zhaakhi
Github user zhaakhi commented on the issue: https://github.com/apache/thrift/pull/1152 Ping. It would be nice to get this fix in since the double free is potentially a data corrupting bug. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Updated] (THRIFT-4105) used too much memory randomly

2017-02-23 Thread chengning (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chengning updated THRIFT-4105: -- Description: In my golang project used thrift, high memory usage once or twice a week. Use go tool

[jira] [Updated] (THRIFT-4105) used too much memory randomly

2017-02-23 Thread chengning (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chengning updated THRIFT-4105: -- Attachment: pprof.txt > used too much memory randomly > - > >

[jira] [Updated] (THRIFT-4105) used too much memory randomly

2017-02-23 Thread chengning (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chengning updated THRIFT-4105: -- Attachment: (was: pprof.txt) > used too much memory randomly > - > >

[jira] [Updated] (THRIFT-4105) used too much memory randomly

2017-02-23 Thread chengning (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chengning updated THRIFT-4105: -- Attachment: pprof.txt > used too much memory randomly > - > >

[jira] [Created] (THRIFT-4105) used too much memory randomly

2017-02-23 Thread chengning (JIRA)
chengning created THRIFT-4105: - Summary: used too much memory randomly Key: THRIFT-4105 URL: https://issues.apache.org/jira/browse/THRIFT-4105 Project: Thrift Issue Type: Bug