[jira] [Commented] (THRIFT-4147) Rust: protocol should accept transports with non-static lifetime

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944529#comment-15944529 ] ASF GitHub Bot commented on THRIFT-4147: Github user sunchao commented on the issue:

[GitHub] thrift issue #1226: THRIFT-4147: Rust: protocol should accept transports wit...

2017-03-27 Thread sunchao
Github user sunchao commented on the issue: https://github.com/apache/thrift/pull/1226 cc @allengeorge to take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (THRIFT-4147) Rust: protocol should accept transports with non-static lifetime

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944528#comment-15944528 ] ASF GitHub Bot commented on THRIFT-4147: GitHub user sunchao opened a pull request:

[GitHub] thrift pull request #1226: THRIFT-4147: Rust: protocol should accept transpo...

2017-03-27 Thread sunchao
GitHub user sunchao opened a pull request: https://github.com/apache/thrift/pull/1226 THRIFT-4147: Rust: protocol should accept transports with non-static … …lifetime You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (THRIFT-4147) Rust: protocol should accept transports with non-static lifetime

2017-03-27 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944525#comment-15944525 ] Chao Sun commented on THRIFT-4147: -- Strange. Why I can't assign this JIRA to myself? > Rust: protocol

[jira] [Created] (THRIFT-4147) Rust: protocol should accept transports with non-static lifetime

2017-03-27 Thread Chao Sun (JIRA)
Chao Sun created THRIFT-4147: Summary: Rust: protocol should accept transports with non-static lifetime Key: THRIFT-4147 URL: https://issues.apache.org/jira/browse/THRIFT-4147 Project: Thrift

[jira] [Comment Edited] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

2017-03-27 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944022#comment-15944022 ] Jens Geyer edited comment on THRIFT-4137 at 3/27/17 8:56 PM: - Committed,

[jira] [Commented] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15944032#comment-15944032 ] ASF GitHub Bot commented on THRIFT-4137: Github user Jens-G closed the pull request at:

[GitHub] thrift pull request #1223: THRIFT-4137 vptr @ compiler

2017-03-27 Thread Jens-G
Github user Jens-G closed the pull request at: https://github.com/apache/thrift/pull/1223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

2017-03-27 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4137. Resolution: Fixed Fix Version/s: 0.11.0 Committed, except the usbsan.sh change (for obvious

[jira] [Closed] (THRIFT-4146) Appveyor builds are being triggered by apache master pushes

2017-03-27 Thread Jake Farrell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jake Farrell closed THRIFT-4146. Resolution: Fixed Fix Version/s: 0.11.0 Updated config to run all except branch master >

[GitHub] thrift issue #1215: Thrift 4126

2017-03-27 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1215 When this does merge into master, it's probably worth updating the README.md indicating this is a breaking change (for the better). I would like to take a look at how some of the other runtime

[jira] [Updated] (THRIFT-4146) Appveyor builds are being triggered by apache master pushes

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4146: --- Description: When I commit and push something into the apache git repository for

[jira] [Created] (THRIFT-4146) Appveyor builds are being triggered by apache master pushes

2017-03-27 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4146: -- Summary: Appveyor builds are being triggered by apache master pushes Key: THRIFT-4146 URL: https://issues.apache.org/jira/browse/THRIFT-4146 Project:

[jira] [Resolved] (THRIFT-4141) Installation of haxe in docker files refers to a redirect link and fails

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4141. Resolution: Fixed Updated Dockerfile to use wget instead of curl, and to get

[jira] [Commented] (THRIFT-4141) Installation of haxe in docker files refers to a redirect link and fails

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943913#comment-15943913 ] ASF GitHub Bot commented on THRIFT-4141: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1225: THRIFT-4141: fix haxe installation in docker buil...

2017-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (THRIFT-4145) XHRConnection does not handle binary protocols

2017-03-27 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Håkon Hitland updated THRIFT-4145: -- Priority: Minor (was: Major) > XHRConnection does not handle binary protocols >

[jira] [Created] (THRIFT-4145) XHRConnection does not handle binary protocols

2017-03-27 Thread JIRA
Håkon Hitland created THRIFT-4145: - Summary: XHRConnection does not handle binary protocols Key: THRIFT-4145 URL: https://issues.apache.org/jira/browse/THRIFT-4145 Project: Thrift Issue

[jira] [Resolved] (THRIFT-4143) Order of struct and enum affect generation results

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4143. Resolution: Information Provided I'm resolving this as an answered question. The

[jira] [Updated] (THRIFT-4143) Order of struct and enum affect generation results

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4143: --- Issue Type: Question (was: Bug) > Order of struct and enum affect generation

[jira] [Assigned] (THRIFT-4143) Order of struct and enum affect generation results

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4143: -- Assignee: James E. King, III > Order of struct and enum affect generation

[jira] [Updated] (THRIFT-4143) Order of struct and enum affect generation results

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4143: --- Component/s: (was: Java - Compiler) Compiler (General) > Order

[jira] [Commented] (THRIFT-4143) Order of struct and enum affect generation results

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943519#comment-15943519 ] James E. King, III commented on THRIFT-4143: I do not see this as an error. The same thing

[jira] [Commented] (THRIFT-4141) Installation of haxe in docker files refers to a redirect link and fails

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943504#comment-15943504 ] ASF GitHub Bot commented on THRIFT-4141: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1225: THRIFT-4141: fix haxe installation in docker build for d...

2017-03-27 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1225 Job #5 of Build #3520 failed with something interesting and relevant: ``` PHP 5.5.9-1ubuntu4.21 Development Server started at Mon Mar 27 13:56:33 2017 Listening on http://127.0.0.1:9090

[jira] [Created] (THRIFT-4144) c_glib testbufferedtransport failed in a CI build

2017-03-27 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4144: -- Summary: c_glib testbufferedtransport failed in a CI build Key: THRIFT-4144 URL: https://issues.apache.org/jira/browse/THRIFT-4144 Project: Thrift

[jira] [Commented] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943466#comment-15943466 ] ASF GitHub Bot commented on THRIFT-4137: Github user jbapple-cloudera commented on the issue:

[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler

2017-03-27 Thread jbapple-cloudera
Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1223 I can take a look at the Boost problem next weekend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Created] (THRIFT-4143) Order of struct and enum affect generation results

2017-03-27 Thread Mykhailo Kozik (JIRA)
Mykhailo Kozik created THRIFT-4143: -- Summary: Order of struct and enum affect generation results Key: THRIFT-4143 URL: https://issues.apache.org/jira/browse/THRIFT-4143 Project: Thrift

[jira] [Resolved] (THRIFT-4114) Space after '///' in doc comments

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4114. Resolution: Fixed Fix Version/s: 0.11.0 > Space after '///' in doc comments

[jira] [Commented] (THRIFT-4114) Space after '///' in doc comments

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943209#comment-15943209 ] ASF GitHub Bot commented on THRIFT-4114: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1224: THRIFT-4114: Space after '///' in doc comments

2017-03-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (THRIFT-4114) Space after '///' in doc comments

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4114: -- Assignee: James E. King, III > Space after '///' in doc comments >

[jira] [Created] (THRIFT-4142) Add a functional test to check proper handling of required fields in structures

2017-03-27 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4142: -- Summary: Add a functional test to check proper handling of required fields in structures Key: THRIFT-4142 URL: https://issues.apache.org/jira/browse/THRIFT-4142

[GitHub] thrift pull request #1215: Thrift 4126

2017-03-27 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1215#discussion_r108155957 --- Diff: lib/php/src/ext/thrift_protocol/php_thrift_protocol.cpp --- @@ -728,6 +728,42 @@ inline bool ttypes_are_compatible(int8_t t1, int8_t t2) {

[GitHub] thrift issue #1215: Thrift 4126

2017-03-27 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1215 I'll open a story in Jira for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] thrift issue #1215: Thrift 4126

2017-03-27 Thread kufd
Github user kufd commented on the issue: https://github.com/apache/thrift/pull/1215 Yes I will add functional tests But it can take a few weeks, because i do not have enough free time now --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (THRIFT-4141) Installation of haxe in docker files refers to a redirect link and fails

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943126#comment-15943126 ] ASF GitHub Bot commented on THRIFT-4141: GitHub user jeking3 opened a pull request:

[jira] [Commented] (THRIFT-4069) All perl packages should have proper namespace and version syntax

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943125#comment-15943125 ] ASF GitHub Bot commented on THRIFT-4069: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1225: THRIFT-4141: fix haxe installation in docker buil...

2017-03-27 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1225 THRIFT-4141: fix haxe installation in docker build for debian, ubuntu You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[GitHub] thrift pull request #1220: THRIFT-4069: perl library cleanup - namespaces, v...

2017-03-27 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1220#discussion_r108151340 --- Diff: build/docker/debian/Dockerfile --- @@ -157,7 +157,7 @@ ENV PATH /usr/local/go/bin:$PATH # Haxe RUN mkdir -p /usr/lib/haxe && \

[jira] [Updated] (THRIFT-4141) Installation of haxe in docker files refers to a redirect link and fails

2017-03-27 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4141: --- Description: The link for haxe has been changed to a redirect, and curl isn't

[jira] [Created] (THRIFT-4141) Installation of haxe in docker files refers to a redirect link and fails

2017-03-27 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4141: -- Summary: Installation of haxe in docker files refers to a redirect link and fails Key: THRIFT-4141 URL: https://issues.apache.org/jira/browse/THRIFT-4141

[jira] [Commented] (THRIFT-4069) All perl packages should have proper namespace and version syntax

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943092#comment-15943092 ] ASF GitHub Bot commented on THRIFT-4069: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4069) All perl packages should have proper namespace and version syntax

2017-03-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15943095#comment-15943095 ] ASF GitHub Bot commented on THRIFT-4069: Github user jeking3 commented on a diff in the pull

[GitHub] thrift pull request #1220: THRIFT-4069: perl library cleanup - namespaces, v...

2017-03-27 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1220#discussion_r108147597 --- Diff: build/docker/debian/Dockerfile --- @@ -157,7 +157,7 @@ ENV PATH /usr/local/go/bin:$PATH # Haxe RUN mkdir -p /usr/lib/haxe && \

[GitHub] thrift pull request #1220: THRIFT-4069: perl library cleanup - namespaces, v...

2017-03-27 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1220#discussion_r108147499 --- Diff: build/docker/centos/Dockerfile --- @@ -74,10 +74,8 @@ RUN yum install -y \ perl-Bit-Vector \ perl-Class-Accessor \

[jira] [Created] (THRIFT-4140) Use of non-thread-safe function gmtime()

2017-03-27 Thread Adriaan Schmidt (JIRA)
Adriaan Schmidt created THRIFT-4140: --- Summary: Use of non-thread-safe function gmtime() Key: THRIFT-4140 URL: https://issues.apache.org/jira/browse/THRIFT-4140 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-4139) warning: 'register' storage class specifier is deprecated and incompatible with C++1z [-Wdeprecated-register]

2017-03-27 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4139: -- Summary: warning: 'register' storage class specifier is deprecated and incompatible with C++1z [-Wdeprecated-register] Key: THRIFT-4139 URL:

[GitHub] thrift issue #1215: Thrift 4126

2017-03-27 Thread kufd
Github user kufd commented on the issue: https://github.com/apache/thrift/pull/1215 Now all build jobs are success --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Assigned] (THRIFT-4137) Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

2017-03-27 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4137: -- Assignee: Jens Geyer > Fix remaining undefined behavior invalid vptr casts in Thrift Compiler

[GitHub] thrift issue #1223: THRIFT-4137 vptr @ compiler

2017-03-27 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1223 Yeah, but at least it looks as if we get the compiler ready. If there are no objections, I am going commit that part today, With UBSAN still left disabled of course. I only enabled it in