[jira] [Commented] (THRIFT-2939) JavaScript generated code for Node and browser is different

2017-04-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962017#comment-15962017 ] James E. King, III commented on THRIFT-2939: I found this towards the beginning of the PR

[jira] [Commented] (THRIFT-2939) JavaScript generated code for Node and browser is different

2017-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962014#comment-15962014 ] ASF GitHub Bot commented on THRIFT-2939: Github user jeking3 commented on the issue:

[GitHub] thrift issue #353: THRIFT-2939: Js on par with nodejs

2017-04-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/353 Tag THRIFT-2939 so the PR shows up in github as a linked PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (THRIFT-2939) JavaScript generated code for Node and browser is different

2017-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962013#comment-15962013 ] ASF GitHub Bot commented on THRIFT-2939: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1249: THRIFT-2939: reviving pr #353 to see if it still ...

2017-04-08 Thread jeking3
GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1249 THRIFT-2939: reviving pr #353 to see if it still works with crosstest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift

[GitHub] thrift issue #1187: Review for pull up of RUST extended namespace support, a...

2017-04-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1187 If @przygienda could close it, that would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] thrift issue #1187: Review for pull up of RUST extended namespace support, a...

2017-04-08 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1187 Yes please - that would be the best course of action. --- If your project is set up for it, you can

[GitHub] thrift issue #1187: Review for pull up of RUST extended namespace support, a...

2017-04-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1187 @allengeorge would you agree we should close this pull request and tackle each item individually per the open Jira items? --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (THRIFT-4158) minor issue in README-MSYS2.md

2017-04-08 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961913#comment-15961913 ] Mario Emmenlauer commented on THRIFT-4158: -- See the PR here: