[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...

2017-05-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1252 Great - well once I can commit again, I will. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1260 I believe that is intentional for backwards compatibility. A multiplexing server should be able to accept an older client and use the "default" service for it - at least in the Java multiplexing

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999648#comment-15999648 ] ASF GitHub Bot commented on THRIFT-4186: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...

2017-05-06 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1252 @jeking3 If you're willing to take this...I have some ruby experience, and this looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999617#comment-15999617 ] ASF GitHub Bot commented on THRIFT-4186: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1260 @Jens-G @jeking3 Can I get any guidance on how the clients/server get their arguments? I'm confident it's not a bug in the rust server. I can invoke the c_glib client and rust server manually

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1260 OK. I really don't understand `tests.json`. I'm confident that my code is doing the right thing - it's just that the server is invoked in multiplexed mode and the client is invoked in

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999610#comment-15999610 ] ASF GitHub Bot commented on THRIFT-4186: Github user allengeorge commented on the issue:

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999585#comment-15999585 ] ASF GitHub Bot commented on THRIFT-4186: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1260 Ah. Gotcha. Sorry - I should have realized that. I'll pay closer attention next time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999584#comment-15999584 ] ASF GitHub Bot commented on THRIFT-4186: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1260 One is clang and one is gcc; I recently lowered us from 25 to 19 build jobs and got rid of the ones we didn't need or were redundant. --- If your project is set up for it, you can reply to this

[jira] [Comment Edited] (THRIFT-4190) improve C# TThreadPoolServer defaults

2017-05-06 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999580#comment-15999580 ] Jens Geyer edited comment on THRIFT-4190 at 5/6/17 8:53 PM: That still does

[jira] [Commented] (THRIFT-4190) improve C# TThreadPoolServer defaults

2017-05-06 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999580#comment-15999580 ] Jens Geyer commented on THRIFT-4190: That still does not solve the problem, that one may (for

[jira] [Commented] (THRIFT-4190) improve C# TThreadPoolServer defaults

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999578#comment-15999578 ] ASF GitHub Bot commented on THRIFT-4190: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1262: THRIFT-4190 Improve C# TThreadPoolServer defaults

2017-05-06 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1262 THRIFT-4190 Improve C# TThreadPoolServer defaults Client: C# Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift

[jira] [Updated] (THRIFT-4190) improve C# TThreadPoolServer defaults

2017-05-06 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4190: --- Description: The TThreadPoolServer uses hardcoded values to specify min/max number of threads, if

[jira] [Created] (THRIFT-4190) improve C# TThreadPoolServer defaults

2017-05-06 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4190: -- Summary: improve C# TThreadPoolServer defaults Key: THRIFT-4190 URL: https://issues.apache.org/jira/browse/THRIFT-4190 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999509#comment-15999509 ] ASF GitHub Bot commented on THRIFT-4186: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1260 I had to split up binary/compact protocols because the builds were timing out with them together. And, AFAICT, the unit tests aren't running for builds 1 and 2. Also (I didn't change

[jira] [Commented] (THRIFT-4186) Build and test rust client in Travis

2017-05-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999459#comment-15999459 ] ASF GitHub Bot commented on THRIFT-4186: Github user allengeorge commented on the issue:

[GitHub] thrift issue #1260: THRIFT-4186 Add travis build for Rust

2017-05-06 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1260 I've rebalanced the matrix. Trying again. @jeking3 Having a weird problem with the c_glib client. It's using the "binary" or "compact" protocol only when invoked in multi/multic mode.