[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056824#comment-16056824
]
Eric Conner edited comment on THRIFT-2642 at 6/21/17 5:13 PM:
--
Hi everyone,
Github user econner commented on the issue:
https://github.com/apache/thrift/pull/1293
Ok, I've updated the PR to use a list (reference type) instead of a tuple.
I also added some serialization tests for recursive structures. Hopefully
everything works now.
---
If your project is
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057856#comment-16057856
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057851#comment-16057851
]
ASF GitHub Bot commented on THRIFT-2642:
GitHub user econner reopened a pull request:
GitHub user econner reopened a pull request:
https://github.com/apache/thrift/pull/1293
THRIFT-2642 Recursive structs don't work in python
See https://issues.apache.org/jira/browse/THRIFT-2642.
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056824#comment-16056824
]
Eric Conner edited comment on THRIFT-2642 at 6/21/17 5:06 PM:
--
Hi everyone,
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057819#comment-16057819
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057820#comment-16057820
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner closed the pull request at:
Github user econner closed the pull request at:
https://github.com/apache/thrift/pull/1293
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user econner commented on the issue:
https://github.com/apache/thrift/pull/1293
As written this will not work. The spec for a Struct needs to be a
reference type such as a list for recursion to work correctly so there is more
work to be done here.
---
If your project is set
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057106#comment-16057106
]
julien greard commented on THRIFT-2642:
---
Hi
Thanks for the work, I'll have a look this week. I
11 matches
Mail list logo