[jira] [Comment Edited] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread Eric Conner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056824#comment-16056824 ] Eric Conner edited comment on THRIFT-2642 at 6/21/17 5:13 PM: -- Hi everyone,

[GitHub] thrift issue #1293: THRIFT-2642 Recursive structs don't work in python

2017-06-21 Thread econner
Github user econner commented on the issue: https://github.com/apache/thrift/pull/1293 Ok, I've updated the PR to use a list (reference type) instead of a tuple. I also added some serialization tests for recursive structures. Hopefully everything works now. --- If your project is

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057856#comment-16057856 ] ASF GitHub Bot commented on THRIFT-2642: Github user econner commented on the issue:

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057851#comment-16057851 ] ASF GitHub Bot commented on THRIFT-2642: GitHub user econner reopened a pull request:

[GitHub] thrift pull request #1293: THRIFT-2642 Recursive structs don't work in pytho...

2017-06-21 Thread econner
GitHub user econner reopened a pull request: https://github.com/apache/thrift/pull/1293 THRIFT-2642 Recursive structs don't work in python See https://issues.apache.org/jira/browse/THRIFT-2642. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Comment Edited] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread Eric Conner (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056824#comment-16056824 ] Eric Conner edited comment on THRIFT-2642 at 6/21/17 5:06 PM: -- Hi everyone,

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057819#comment-16057819 ] ASF GitHub Bot commented on THRIFT-2642: Github user econner commented on the issue:

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057820#comment-16057820 ] ASF GitHub Bot commented on THRIFT-2642: Github user econner closed the pull request at:

[GitHub] thrift pull request #1293: THRIFT-2642 Recursive structs don't work in pytho...

2017-06-21 Thread econner
Github user econner closed the pull request at: https://github.com/apache/thrift/pull/1293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #1293: THRIFT-2642 Recursive structs don't work in python

2017-06-21 Thread econner
Github user econner commented on the issue: https://github.com/apache/thrift/pull/1293 As written this will not work. The spec for a Struct needs to be a reference type such as a list for recursion to work correctly so there is more work to be done here. --- If your project is set

[jira] [Commented] (THRIFT-2642) Recursive structs don't work in python

2017-06-21 Thread julien greard (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057106#comment-16057106 ] julien greard commented on THRIFT-2642: --- Hi Thanks for the work, I'll have a look this week. I