[
https://issues.apache.org/jira/browse/THRIFT-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078415#comment-16078415
]
Zach Wasserman commented on THRIFT-4237:
Eric, I'd encourage you to review it any
[
https://issues.apache.org/jira/browse/THRIFT-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078442#comment-16078442
]
ASF GitHub Bot commented on THRIFT-4237:
Github user econner commented on a diff
Github user econner commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1304#discussion_r126207049
--- Diff: lib/go/thrift/server_socket.go ---
@@ -68,15 +68,18 @@ func (p *TServerSocket) Listen() error {
func (p *TServerSocket) Accept() (TTrans
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1304#discussion_r126221534
--- Diff: lib/go/thrift/server_socket.go ---
@@ -68,15 +68,18 @@ func (p *TServerSocket) Listen() error {
func (p *TServerSocket) Accept() (TTransp
[
https://issues.apache.org/jira/browse/THRIFT-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078528#comment-16078528
]
ASF GitHub Bot commented on THRIFT-4237:
Github user Jens-G commented on a diff i
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user zwass commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1304#discussion_r126230574
--- Diff: lib/go/thrift/server_socket.go ---
@@ -68,15 +68,18 @@ func (p *TServerSocket) Listen() error {
func (p *TServerSocket) Accept() (TTranspo
[
https://issues.apache.org/jira/browse/THRIFT-4237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078585#comment-16078585
]
ASF GitHub Bot commented on THRIFT-4237:
Github user zwass commented on a diff in
