[jira] [Created] (THRIFT-4255) Go generator has type errors when in read/write functions for set

2017-07-17 Thread Davin Chia (JIRA)
Davin Chia created THRIFT-4255: -- Summary: Go generator has type errors when in read/write functions for set Key: THRIFT-4255 URL: https://issues.apache.org/jira/browse/THRIFT-4255 Project: Thrift

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:44 AM: -

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:15 AM: -

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:13 AM: -

[jira] [Created] (THRIFT-4254) Go generator does not respect typedef types when generating read/write functions.

2017-07-17 Thread Davin Chia (JIRA)
Davin Chia created THRIFT-4254: -- Summary: Go generator does not respect typedef types when generating read/write functions. Key: THRIFT-4254 URL: https://issues.apache.org/jira/browse/THRIFT-4254 Project

[jira] [Commented] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia commented on THRIFT-4253: Thanks for the quick reply [~jensg]. This is the

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090880#comment-16090880 ] Davin Chia commented on THRIFT-2063: Ah sorry for the noise. I am definitely going to

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090591#comment-16090591 ] Jens Geyer edited comment on THRIFT-4253 at 7/17/17 9:25 PM: -

[jira] [Commented] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090591#comment-16090591 ] Jens Geyer commented on THRIFT-4253: Confirmed, trying this ends up in a "{{cannot us

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090566#comment-16090566 ] Jens Geyer commented on THRIFT-2063: You can bump this in 5-Minutes intervals, but th

[jira] [Comment Edited] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087783#comment-16087783 ] Davin Chia edited comment on THRIFT-2063 at 7/17/17 8:57 PM: -

[jira] [Created] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
Davin Chia created THRIFT-4253: -- Summary: Go generator assigns strings to field in const instead of pointers. Key: THRIFT-4253 URL: https://issues.apache.org/jira/browse/THRIFT-4253 Project: Thrift

[jira] [Comment Edited] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087783#comment-16087783 ] Davin Chia edited comment on THRIFT-2063 at 7/17/17 8:00 PM: -

[GitHub] thrift pull request #1309: Use build tags to support context.

2017-07-17 Thread dcelasun
Github user dcelasun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r127776518 --- Diff: lib/go/thrift/multiplexed_processor.go --- @@ -1,3 +1,5 @@ +// +build go1.7 --- End diff -- Maybe this file should be named `mult

[GitHub] thrift pull request #1309: Use build tags to support context.

2017-07-17 Thread dcelasun
Github user dcelasun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r127775849 --- Diff: lib/go/thrift/simple_server2.go --- @@ -1,180 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more c

[GitHub] thrift pull request #1309: Use build tags to support context.

2017-07-17 Thread dcelasun
Github user dcelasun commented on a diff in the pull request: https://github.com/apache/thrift/pull/1309#discussion_r127774140 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -3746,4 +3746,4 @@ THRIFT_REGISTER_GENERATOR(go, "Go", "

[jira] [Commented] (THRIFT-4236) Support context in go generated code.

2017-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090063#comment-16090063 ] ASF GitHub Bot commented on THRIFT-4236: GitHub user taozle opened a pull request

[GitHub] thrift pull request #1309: Use build tags to support context.

2017-07-17 Thread taozle
GitHub user taozle opened a pull request: https://github.com/apache/thrift/pull/1309 Use build tags to support context. As the comment in https://issues.apache.org/jira/browse/THRIFT-4236, this PR use build tags to support context in go1.7 above. You can merge this pull request int

[jira] [Resolved] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions

2017-07-17 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer resolved THRIFT-4239. -- Resolution: Fixed > Latest thrift breaks java build with handleRuntimeExceptions >

[jira] [Closed] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions

2017-07-17 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer closed THRIFT-4239. Fixed, thanks. > Latest thrift breaks java build with handleRuntimeExceptions > --

[jira] [Commented] (THRIFT-4239) Latest thrift breaks java build with handleRuntimeExceptions

2017-07-17 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089776#comment-16089776 ] Mario Emmenlauer commented on THRIFT-4239: -- Dear [~ctubbsii], thanks a lot!!! Yo

[jira] [Updated] (THRIFT-4252) Cannot shutdown Java server when clients are still connected

2017-07-17 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer updated THRIFT-4252: - Description: I found issue https://issues.apache.org/jira/browse/THRIFT-2441 and I believ

[jira] [Created] (THRIFT-4252) Cannot shutdown Java server when clients are still connected

2017-07-17 Thread Mario Emmenlauer (JIRA)
Mario Emmenlauer created THRIFT-4252: Summary: Cannot shutdown Java server when clients are still connected Key: THRIFT-4252 URL: https://issues.apache.org/jira/browse/THRIFT-4252 Project: Thrift