Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1309
> I'll also be sending a PR to update the Go tutorial with the new handler
signature.
Please do. Right now the tutorial does not build.
```
handler.go:30:2: cannot find package "
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
[
https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097390#comment-16097390
]
ASF GitHub Bot commented on THRIFT-4236:
Github user asfgit closed the pull reque
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1311#discussion_r128901829
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield,
bool in_containe
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1309
Hmm, turns out @taozle already
[updated](https://github.com/apache/thrift/blob/c0d384a38c2b43ee47cef86b1cd054e3f84dc909/tutorial/go/Makefile.am#L37)
the Makefile for the tutorial, I just missed it
